BasicAuthModule::auth() - Code Metrics - Inspection of "Merge pull request #30365 from owncloud/bugfix/own..." - owncloud/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 664d98...03ed01 )

by Thomas

created 2018-02-13 17:11 UTC

BasicAuthModule::auth() C

↳ Parent: BasicAuthModule

Complexity

Conditions	7
Paths	7

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	16
nc	7
nop	1
dl	0
loc	25
rs	6.7272
c	0
b	0
f	0

<?php
/**
 * @author Thomas Müller <[email protected]>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */


namespace OC\User;


use OCP\Authentication\IAuthModule;
use OCP\IRequest;
use OCP\IUser;
use OCP\IUserManager;

class BasicAuthModule implements IAuthModule {

	/** @var IUserManager */
	private $manager;

	public function __construct(IUserManager $manager) {
		$this->manager = $manager;
	}

	/**
	 * @inheritdoc
	 */
	public function auth(IRequest $request) {
		if (!isset($request->server['PHP_AUTH_USER'], $request->server['PHP_AUTH_PW'])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			return null;
		}
		$authUser = $request->server['PHP_AUTH_USER'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$authPass = $request->server['PHP_AUTH_PW'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		if ($authUser === '' || $authPass === '') {
			return null;
		}

		// check uid and password
		$user = $this->manager->checkPassword($authUser, $authPass);
		if ($user instanceof IUser) {
			return $user;
		}
		// check email and password
		$users = $this->manager->getByEmail($authUser);
		if (count($users) === 1) {
			$user = $this->manager->checkPassword($users[0]->getUID(), $authPass);
		}
		if ($user instanceof IUser) {
			return $user;
		}
		throw new \Exception('Invalid credentials');
	}

	/**
	 * @inheritdoc
	 */
	public function getUserPassword(IRequest $request) {
		if (empty($request->server['PHP_AUTH_USER']) || empty($request->server['PHP_AUTH_PW'])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			return '';
		}

		return $request->server['PHP_AUTH_PW'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
	}
}


Push — master ( 664d98...03ed01 )

BasicAuthModule::auth() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* @author Thomas Müller <[email protected]>
4			*
5			* @copyright Copyright (c) 2018, ownCloud GmbH
6			* @license AGPL-3.0
7			*
8			* This code is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License, version 3,
10			* as published by the Free Software Foundation.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			* GNU Affero General Public License for more details.
16			*
17			* You should have received a copy of the GNU Affero General Public License, version 3,
18			* along with this program. If not, see <http://www.gnu.org/licenses/>
19			*
20			*/
21
22
23			namespace OC\User;
24
25
26			use OCP\Authentication\IAuthModule;
27			use OCP\IRequest;
28			use OCP\IUser;
29			use OCP\IUserManager;
30
31			class BasicAuthModule implements IAuthModule {
32
33			/** @var IUserManager */
34			private $manager;
35
36			public function __construct(IUserManager $manager) {
37			$this->manager = $manager;
38			}
39
40			/**
41			* @inheritdoc
42			*/
43			public function auth(IRequest $request) {
44			if (!isset($request->server['PHP_AUTH_USER'], $request->server['PHP_AUTH_PW'])) {
			0 ignored issues – show Bug introduced 2018-02-13 07:22 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `OCP\IRequest` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			return null;
46			}
47			$authUser = $request->server['PHP_AUTH_USER'];
			0 ignored issues – show Bug introduced 2016-04-22 13:57 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `OCP\IRequest` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48			$authPass = $request->server['PHP_AUTH_PW'];
			0 ignored issues – show Bug introduced 2018-02-13 07:22 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `OCP\IRequest` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49			if ($authUser === '' \|\| $authPass === '') {
50			return null;
51			}
52
53			// check uid and password
54			$user = $this->manager->checkPassword($authUser, $authPass);
55			if ($user instanceof IUser) {
56			return $user;
57			}
58			// check email and password
59			$users = $this->manager->getByEmail($authUser);
60			if (count($users) === 1) {
61			$user = $this->manager->checkPassword($users[0]->getUID(), $authPass);
62			}
63			if ($user instanceof IUser) {
64			return $user;
65			}
66			throw new \Exception('Invalid credentials');
67			}
68
69			/**
70			* @inheritdoc
71			*/
72			public function getUserPassword(IRequest $request) {
73			if (empty($request->server['PHP_AUTH_USER']) \|\| empty($request->server['PHP_AUTH_PW'])) {
			0 ignored issues – show Bug introduced 2016-05-08 11:09 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `OCP\IRequest` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
74			return '';
75			}
76
77			return $request->server['PHP_AUTH_PW'];
			0 ignored issues – show Bug introduced 2017-08-17 16:27 UTC by Report Bug Copy Issue Report Accessing `server` on the interface `OCP\IRequest` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
78			}
79			}
80

owncloud / core

Push — master ( 664d98...03ed01 )

BasicAuthModule::auth() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like