Completed
Pull Request — master (#24796)
by Lukas
15:57
created
lib/private/Files/Config/UserMountCache.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $fileId
209
+	 * @param integer $fileId
210 210
 	 * @return array
211 211
 	 * @throws \OCP\Files\NotFoundException
212 212
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -21,14 +21,11 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\Files\Config;
23 23
 
24
-use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
25
-use OC\Files\Filesystem;
26 24
 use OCP\DB\QueryBuilder\IQueryBuilder;
27 25
 use OCP\Files\Config\ICachedMountInfo;
28 26
 use OCP\Files\Config\IUserMountCache;
29 27
 use OCP\Files\Mount\IMountPoint;
30 28
 use OCP\Files\NotFoundException;
31
-use OCP\ICache;
32 29
 use OCP\IDBConnection;
33 30
 use OCP\ILogger;
34 31
 use OCP\IUser;
Please login to merge, or discard this patch.
lib/private/Files/Filesystem.php 2 patches
Doc Comments   +29 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,6 +337,9 @@  discard block
 block discarded – undo
337 337
 		}
338 338
 	}
339 339
 
340
+	/**
341
+	 * @param string $root
342
+	 */
340 343
 	static public function init($user, $root) {
341 344
 		if (self::$defaultInstance) {
342 345
 			return false;
@@ -517,7 +520,7 @@  discard block
 block discarded – undo
517 520
 	/**
518 521
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
519 522
 	 *
520
-	 * @param \OC\Files\Storage\Storage|string $class
523
+	 * @param string $class
521 524
 	 * @param array $arguments
522 525
 	 * @param string $mountpoint
523 526
 	 */
@@ -628,6 +631,7 @@  discard block
 block discarded – undo
628 631
 
629 632
 	/**
630 633
 	 * following functions are equivalent to their php builtin equivalents for arguments/return values.
634
+	 * @param string $path
631 635
 	 */
632 636
 	static public function mkdir($path) {
633 637
 		return self::$defaultInstance->mkdir($path);
@@ -649,6 +653,9 @@  discard block
 block discarded – undo
649 653
 		return self::$defaultInstance->is_dir($path);
650 654
 	}
651 655
 
656
+	/**
657
+	 * @param string $path
658
+	 */
652 659
 	static public function is_file($path) {
653 660
 		return self::$defaultInstance->is_file($path);
654 661
 	}
@@ -661,6 +668,9 @@  discard block
 block discarded – undo
661 668
 		return self::$defaultInstance->filetype($path);
662 669
 	}
663 670
 
671
+	/**
672
+	 * @param string $path
673
+	 */
664 674
 	static public function filesize($path) {
665 675
 		return self::$defaultInstance->filesize($path);
666 676
 	}
@@ -673,6 +683,9 @@  discard block
 block discarded – undo
673 683
 		return self::$defaultInstance->isCreatable($path);
674 684
 	}
675 685
 
686
+	/**
687
+	 * @param string $path
688
+	 */
676 689
 	static public function isReadable($path) {
677 690
 		return self::$defaultInstance->isReadable($path);
678 691
 	}
@@ -685,6 +698,9 @@  discard block
 block discarded – undo
685 698
 		return self::$defaultInstance->isDeletable($path);
686 699
 	}
687 700
 
701
+	/**
702
+	 * @param string $path
703
+	 */
688 704
 	static public function isSharable($path) {
689 705
 		return self::$defaultInstance->isSharable($path);
690 706
 	}
@@ -702,6 +718,7 @@  discard block
 block discarded – undo
702 718
 	}
703 719
 
704 720
 	/**
721
+	 * @param string $path
705 722
 	 * @return string
706 723
 	 */
707 724
 	static public function file_get_contents($path) {
@@ -724,6 +741,10 @@  discard block
 block discarded – undo
724 741
 		return self::$defaultInstance->copy($path1, $path2);
725 742
 	}
726 743
 
744
+	/**
745
+	 * @param string $path
746
+	 * @param string $mode
747
+	 */
727 748
 	static public function fopen($path, $mode) {
728 749
 		return self::$defaultInstance->fopen($path, $mode);
729 750
 	}
@@ -739,6 +760,9 @@  discard block
 block discarded – undo
739 760
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
740 761
 	}
741 762
 
763
+	/**
764
+	 * @param string $path
765
+	 */
742 766
 	static public function getMimeType($path) {
743 767
 		return self::$defaultInstance->getMimeType($path);
744 768
 	}
@@ -751,6 +775,9 @@  discard block
 block discarded – undo
751 775
 		return self::$defaultInstance->free_space($path);
752 776
 	}
753 777
 
778
+	/**
779
+	 * @param string $query
780
+	 */
754 781
 	static public function search($query) {
755 782
 		return self::$defaultInstance->search($query);
756 783
 	}
@@ -860,7 +887,7 @@  discard block
 block discarded – undo
860 887
 	 * @param string $path
861 888
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
862 889
 	 * defaults to true
863
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
890
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
864 891
 	 */
865 892
 	public static function getFileInfo($path, $includeMountPoints = true) {
866 893
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,6 @@
 block discarded – undo
62 62
 use OC\Files\Mount\MountPoint;
63 63
 use OC\Files\Storage\StorageFactory;
64 64
 use OCP\Files\Config\IMountProvider;
65
-use OCP\Files\Mount\IMountPoint;
66 65
 use OCP\Files\NotFoundException;
67 66
 use OCP\IUserManager;
68 67
 
Please login to merge, or discard this patch.
lib/private/Files/Node/LazyRoot.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	 * Magic method to first get the real rootFolder and then
35 35
 	 * call $method with $args on it
36 36
 	 *
37
-	 * @param $method
37
+	 * @param string $method
38 38
 	 * @param $args
39 39
 	 * @return mixed
40 40
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace OC\Files\Node;
4 4
 
5
-use OC\Files\Mount\MountPoint;
6 5
 use OCP\Files\IRootFolder;
7
-use OCP\Files\NotPermittedException;
8 6
 
9 7
 /**
10 8
  * Class LazyRoot
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/ObjectStoreStorage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Files/Storage/Flysystem.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Files/Storage/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
100 100
 	 * @param \OCP\Lock\ILockingProvider $provider
101 101
 	 * @throws \OCP\Lock\LockedException
102
+	 * @return void
102 103
 	 */
103 104
 	public function acquireLock($path, $type, ILockingProvider $provider);
104 105
 
@@ -106,6 +107,7 @@  discard block
 block discarded – undo
106 107
 	 * @param string $path The path of the file to release the lock for
107 108
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
108 109
 	 * @param \OCP\Lock\ILockingProvider $provider
110
+	 * @return void
109 111
 	 */
110 112
 	public function releaseLock($path, $type, ILockingProvider $provider);
111 113
 
@@ -114,6 +116,7 @@  discard block
 block discarded – undo
114 116
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
115 117
 	 * @param \OCP\Lock\ILockingProvider $provider
116 118
 	 * @throws \OCP\Lock\LockedException
119
+	 * @return void
117 120
 	 */
118 121
 	public function changeLock($path, $type, ILockingProvider $provider);
119 122
 }
Please login to merge, or discard this patch.
lib/private/Files/Storage/Wrapper/Encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -777,7 +777,7 @@
 block discarded – undo
777 777
 	/**
778 778
 	 * check if path points to a files version
779 779
 	 *
780
-	 * @param $path
780
+	 * @param string $path
781 781
 	 * @return bool
782 782
 	 */
783 783
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Wrapper/Quota.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
 	 * Checks whether the given path is a part file
160 160
 	 *
161 161
 	 * @param string $path Path that may identify a .part file
162
-	 * @return string File path without .part extension
162
+	 * @return boolean File path without .part extension
163 163
 	 * @note this is needed for reusing keys
164 164
 	 */
165 165
 	private function isPartFile($path) {
Please login to merge, or discard this patch.
lib/private/Files/Stream/StaticStream.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.