Completed
Pull Request — master (#28269)
by Cornelius
13:06
created
core/Controller/TokenController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	/**
53 53
 	 * @param string $appName
54 54
 	 * @param IRequest $request
55
-	 * @param Manager $userManager
55
+	 * @param UserManager $userManager
56 56
 	 * @param DefaultTokenProvider $tokenProvider
57 57
 	 * @param ISecureRandom $secureRandom
58 58
 	 */
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/Google.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@
 block discarded – undo
213 213
 	 *
214 214
 	 * @param \Google_Service_Drive_DriveFile
215 215
 	 *
216
-	 * @return true if the file is a Google Doc file, false otherwise
216
+	 * @return boolean if the file is a Google Doc file, false otherwise
217 217
 	 */
218 218
 	private function isGoogleDocFile($file) {
219 219
 		return $this->getGoogleDocExtension($file->getMimeType()) !== '';
Please login to merge, or discard this patch.
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@
 block discarded – undo
278 278
 	 * get default share folder
279 279
 	 *
280 280
 	 * @param \OC\Files\View
281
+	 * @param View $view
281 282
 	 * @return string
282 283
 	 */
283 284
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 * @param IRequest $request
301 301
 	 * @throws LoginException
302 302
 	 * @throws PasswordLoginForbiddenException
303
-	 * @return boolean
303
+	 * @return boolean|null
304 304
 	 */
305 305
 	public function logClientIn($user, $password, IRequest $request) {
306 306
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@  discard block
 block discarded – undo
340 340
 		return $this->config->getSystemValue('token_auth_enforced', false);
341 341
 	}
342 342
 
343
+	/**
344
+	 * @param string $username
345
+	 */
343 346
 	protected function isTwoFactorEnforced($username) {
344 347
 		Util::emitHook(
345 348
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/SMB.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 	}
57 57
 
58 58
 	/**
59
-	 * @param StorageConfig $storage
59
+	 * @param IStorageConfig $storage
60 60
 	 * @param IUser $user
61 61
 	 */
62 62
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\Files\External\Backend\Backend;
28 28
 use OCP\Files\External\IStorageConfig;
29 29
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
30
-
31 30
 use OCP\IUser;
32 31
 
33 32
 class SMB extends Backend {
Please login to merge, or discard this patch.
apps/dav/lib/DAV/PublicAuth.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	private $publicURLs;
31 31
 
32 32
 	/**
33
-	 * @param string[] $publicURLs
34 33
 	 */
35 34
 	public function __construct() {
36 35
 		$this->publicURLs = [
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Backend/AmazonS3.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -22,11 +22,9 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Lib\Backend;
23 23
 
24 24
 use OCP\IL10N;
25
-use OCP\Files\External\Auth\AuthMechanism;
26 25
 use OCP\Files\External\Backend\Backend;
27 26
 use OCP\Files\External\DefinitionParameter;
28 27
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
29
-
30 28
 use OCA\Files_External\Lib\Auth\AmazonS3\AccessKey;
31 29
 
32 30
 class AmazonS3 extends Backend {
Please login to merge, or discard this patch.
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 * @param array $groupSharesById
208 208
 	 * @param array $subShares
209 209
 	 *
210
-	 * @return true if the share is valid, false if it needs repair
210
+	 * @return boolean if the share is valid, false if it needs repair
211 211
 	 */
212 212
 	private function isThisShareValid($groupSharesById, $subShares) {
213 213
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 		return true;
112 112
 	}
113 113
 
114
+	/**
115
+	 * @param string[] $info
116
+	 */
114 117
 	public function getFileChunking($info) {
115 118
 		// FIXME: need a factory for better mocking support
116 119
 		return new \OC_FileChunking($info);
Please login to merge, or discard this patch.