Completed
Pull Request — master (#28269)
by Cornelius
13:06
created
lib/private/legacy/app.php 2 patches
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -807,9 +807,6 @@
 block discarded – undo
807 807
 	/**
808 808
 	 * List all apps, this is used in apps.php
809 809
 	 *
810
-	 * @param bool $onlyLocal
811
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
812
-	 *                                in the app store?
813 810
 	 * @return array
814 811
 	 */
815 812
 	public static function listAllApps() {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 use OC\App\Platform;
50 50
 use OC\Installer;
51 51
 use OC\Repair;
52
-use OC\HintException;
53 52
 
54 53
 /**
55 54
  * This class manages the apps. It allows them to register and integrate in the
Please login to merge, or discard this patch.
lib/private/AppFramework/Http/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 
449 449
 	/**
450 450
 	 * Checks if the CSRF check was correct
451
-	 * @return bool true if CSRF check passed
451
+	 * @return boolean|null true if CSRF check passed
452 452
 	 */
453 453
 	public function passesCSRFCheck() {
454 454
 		if($this->csrfTokenManager === null) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 namespace OCA\DAV\CalDAV\Publishing\Xml;
22 22
 
23
-use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin;
24 23
 use Sabre\Xml\Writer;
25 24
 use Sabre\Xml\XmlSerializable;
26 25
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return '"' . $this->info->getEtag() . '"';
237 237
 	}
238 238
 
239
+	/**
240
+	 * @param string $path
241
+	 */
239 242
 	private function getPartFileBasePath($path) {
240 243
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
241 244
 		if ($partFileInStorage) {
@@ -598,7 +601,7 @@  discard block
 block discarded – undo
598 601
 	/**
599 602
 	 * Set $algo to get a specific checksum, leave null to get all checksums
600 603
 	 * (space seperated)
601
-	 * @param null $algo
604
+	 * @param string $algo
602 605
 	 * @return string
603 606
 	 */
604 607
 	public function getChecksum($algo = null) {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Files/Storage/Home.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 	 * get the owner of a path
100 100
 	 *
101 101
 	 * @param string $path The path to get the owner
102
-	 * @return string uid or false
102
+	 * @return integer uid or false
103 103
 	 */
104 104
 	public function getOwner($path) {
105 105
 		return $this->user->getUID();
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Mapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
Please login to merge, or discard this patch.
lib/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 	/**
330 330
 	 * Checks if the version requires an update and shows
331 331
 	 * @param bool $showTemplate Whether an update screen should get shown
332
-	 * @return bool
332
+	 * @return null|boolean
333 333
 	 */
334 334
 	public static function checkUpgrade($showTemplate = true) {
335 335
 		if (\OCP\Util::needUpgrade()) {
Please login to merge, or discard this patch.
lib/private/User/Database.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
 	/**
309 309
 	 * counts the users in the database
310 310
 	 *
311
-	 * @return int|bool
311
+	 * @return integer
312 312
 	 */
313 313
 	public function countUsers() {
314 314
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');
Please login to merge, or discard this patch.