Completed
Pull Request — master (#28269)
by Cornelius
13:06
created
apps/files_external/lib/Lib/Storage/SFTP.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
  */
33 33
 namespace OCA\Files_External\Lib\Storage;
34 34
 use Icewind\Streams\IteratorDirectory;
35
-
36 35
 use Icewind\Streams\RetryWrapper;
37 36
 use phpseclib\Net\SFTP\Stream;
38 37
 
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -325,6 +325,9 @@
 block discarded – undo
325 325
 		return $result;
326 326
 	}
327 327
 
328
+	/**
329
+	 * @param string $mountPoint
330
+	 */
328 331
 	public function removeShare($mountPoint) {
329 332
 
330 333
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.
apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Files_Trashbin\BackgroundJob;
25 25
 
26
-use OCP\IConfig;
27 26
 use OCP\IUser;
28 27
 use OCP\IUserManager;
29 28
 use OCA\Files_Trashbin\AppInfo\Application;
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
 	 * check if it is a file located in data/user/files only files in the
110 110
 	 * 'files' directory should be moved to the trash
111 111
 	 *
112
-	 * @param $path
112
+	 * @param string $path
113 113
 	 * @return bool
114 114
 	 */
115 115
 	protected function shouldMoveToTrash($path){
Please login to merge, or discard this patch.
apps/testing/locking/provisioning.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 
81 81
 	/**
82 82
 	 * @param array $parameters
83
-	 * @return int
83
+	 * @return string
84 84
 	 */
85 85
 	protected function getPath($parameters) {
86 86
 		$node = \OC::$server->getRootFolder()
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\Testing\Locking;
23 23
 
24 24
 use OC\Lock\DBLockingProvider;
25
-use OC\Lock\MemcacheLockingProvider;
26 25
 use OC\User\NoUserException;
27 26
 use OCP\AppFramework\Http;
28 27
 use OCP\Files\NotFoundException;
Please login to merge, or discard this patch.
core/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OC\Core\Controller\CloudController;
34 34
 use OC\Core\Controller\LoginController;
35 35
 use OC\Core\Controller\LostController;
36
-use OC\Core\Controller\OccController;
37 36
 use OC\Core\Controller\TokenController;
38 37
 use OC\Core\Controller\TwoFactorChallengeController;
39 38
 use OC\Core\Controller\UserController;
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -101,6 +101,10 @@
 block discarded – undo
101 101
 		// TODO: dont check/enforce 2FA if a auth token is used
102 102
 	}
103 103
 
104
+	/**
105
+	 * @param Controller $controller
106
+	 * @param string $methodName
107
+	 */
104 108
 	private function checkTwoFactor($controller, $methodName) {
105 109
 		// If two-factor auth is in progress disallow access to any controllers
106 110
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -402,6 +402,9 @@
 block discarded – undo
402 402
 		}
403 403
 	}
404 404
 
405
+	/**
406
+	 * @param string $path
407
+	 */
405 408
 	private function getParentPath($path) {
406 409
 		$parent = dirname($path);
407 410
 		if ($parent === '.') {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 	/**
75 75
 	 * @param array $entry
76
-	 * @return array
76
+	 * @return string
77 77
 	 */
78 78
 	protected function formatCacheEntry($entry) {
79 79
 		if (isset($entry['path'])) {
@@ -192,6 +192,9 @@  discard block
 block discarded – undo
192 192
 		return $this->cache->getStatus($this->getSourcePath($file));
193 193
 	}
194 194
 
195
+	/**
196
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
197
+	 */
195 198
 	private function formatSearchResults($results) {
196 199
 		$results = array_filter($results, [$this, 'filterCacheEntry']);
197 200
 		$results = array_values($results);
Please login to merge, or discard this patch.