Completed
Pull Request — master (#24842)
by Joas
42:23
created
lib/private/Comments/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
 	/**
203 203
 	 * removes an entry from the comments run time cache
204 204
 	 *
205
-	 * @param mixed $id the comment's id
205
+	 * @param string $id the comment's id
206 206
 	 */
207 207
 	protected function uncache($id) {
208 208
 		$id = strval($id);
Please login to merge, or discard this patch.
lib/private/DB/Connection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 * If an SQLLogger is configured, the execution is logged.
168 168
 	 *
169 169
 	 * @param string                                      $query  The SQL query to execute.
170
-	 * @param array                                       $params The parameters to bind to the query, if any.
170
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
171 171
 	 * @param array                                       $types  The types the previous parameters are in.
172 172
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
173 173
 	 *
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * columns or sequences.
213 213
 	 *
214 214
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
215
-	 * @return string A string representation of the last inserted ID.
215
+	 * @return integer A string representation of the last inserted ID.
216 216
 	 */
217 217
 	public function lastInsertId($seqName = null)
218 218
 	{
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	private $noEmit = false;
61 61
 
62 62
 	/**
63
-	 * @param \Doctrine\DBAL\Connection|Connection $connection
63
+	 * @param Connection $connection
64 64
 	 * @param ISecureRandom $random
65 65
 	 * @param IConfig $config
66 66
 	 * @param EventDispatcher $dispatcher
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
274 274
 	}
275 275
 
276
+	/**
277
+	 * @param integer $step
278
+	 * @param integer $max
279
+	 */
276 280
 	protected function emit($sql, $step, $max) {
277 281
 		if ($this->noEmit) {
278 282
 			return;
@@ -283,6 +287,10 @@  discard block
 block discarded – undo
283 287
 		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
284 288
 	}
285 289
 
290
+	/**
291
+	 * @param integer $step
292
+	 * @param integer $max
293
+	 */
286 294
 	private function emitCheckStep($tableName, $step, $max) {
287 295
 		if(is_null($this->dispatcher)) {
288 296
 			return;
Please login to merge, or discard this patch.
lib/private/Memcache/APC.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
 	 * Set a value in the cache if it's not already stored
121 121
 	 *
122 122
 	 * @param string $key
123
-	 * @param mixed $value
123
+	 * @param integer $value
124 124
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
125 125
 	 * @return bool
126 126
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/APCu.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
 	 * Set a value in the cache if it's not already stored
121 121
 	 *
122 122
 	 * @param string $key
123
-	 * @param mixed $value
123
+	 * @param integer $value
124 124
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
125 125
 	 * @return bool
126 126
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/ArrayCache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
 	 * Set a value in the cache if it's not already stored
121 121
 	 *
122 122
 	 * @param string $key
123
-	 * @param mixed $value
123
+	 * @param integer $value
124 124
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
125 125
 	 * @return bool
126 126
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/Memcached.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
 	 * Set a value in the cache if it's not already stored
121 121
 	 *
122 122
 	 * @param string $key
123
-	 * @param mixed $value
123
+	 * @param integer $value
124 124
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
125 125
 	 * @return bool
126 126
 	 */
Please login to merge, or discard this patch.
lib/private/IntegrityCheck/Helpers/FileAccessHelper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * Wrapper around file_get_contents($filename, $data)
33 33
 	 *
34 34
 	 * @param string $filename
35
-	 * @return string|false
35
+	 * @return string
36 36
 	 */
37 37
 	public function file_get_contents($filename) {
38 38
 		return file_get_contents($filename);
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
 	 * Wrapper around file_put_contents($filename, $data)
53 53
 	 *
54 54
 	 * @param string $filename
55
-	 * @param $data
56
-	 * @return int|false
55
+	 * @param string $data
56
+	 * @return integer
57 57
 	 */
58 58
 	public function file_put_contents($filename, $data) {
59 59
 		return file_put_contents($filename, $data);
Please login to merge, or discard this patch.
lib/private/Cache/File.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,9 +90,9 @@
 block discarded – undo
90 90
 
91 91
 	/**
92 92
 	 * @param string $key
93
-	 * @param mixed $value
93
+	 * @param string|null $value
94 94
 	 * @param int $ttl
95
-	 * @return bool|mixed
95
+	 * @return boolean
96 96
 	 * @throws \OC\ForbiddenException
97 97
 	 */
98 98
 	public function set($key, $value, $ttl = 0) {
Please login to merge, or discard this patch.