owncloud /
core
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like OC often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use OC, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 62 | class OC { |
||
| 63 | /** |
||
| 64 | * Associative array for autoloading. classname => filename |
||
| 65 | */ |
||
| 66 | public static $CLASSPATH = array(); |
||
| 67 | /** |
||
| 68 | * The installation path for owncloud on the server (e.g. /srv/http/owncloud) |
||
| 69 | */ |
||
| 70 | public static $SERVERROOT = ''; |
||
| 71 | /** |
||
| 72 | * the current request path relative to the owncloud root (e.g. files/index.php) |
||
| 73 | */ |
||
| 74 | private static $SUBURI = ''; |
||
| 75 | /** |
||
| 76 | * the owncloud root path for http requests (e.g. owncloud/) |
||
| 77 | */ |
||
| 78 | public static $WEBROOT = ''; |
||
| 79 | /** |
||
| 80 | * The installation path of the 3rdparty folder on the server (e.g. /srv/http/owncloud/3rdparty) |
||
| 81 | */ |
||
| 82 | public static $THIRDPARTYROOT = ''; |
||
| 83 | /** |
||
| 84 | * the root path of the 3rdparty folder for http requests (e.g. owncloud/3rdparty) |
||
| 85 | */ |
||
| 86 | public static $THIRDPARTYWEBROOT = ''; |
||
| 87 | /** |
||
| 88 | * The installation path array of the apps folder on the server (e.g. /srv/http/owncloud) 'path' and |
||
| 89 | * web path in 'url' |
||
| 90 | */ |
||
| 91 | public static $APPSROOTS = array(); |
||
| 92 | |||
| 93 | public static $configDir; |
||
| 94 | |||
| 95 | /** |
||
| 96 | * requested app |
||
| 97 | */ |
||
| 98 | public static $REQUESTEDAPP = ''; |
||
| 99 | |||
| 100 | /** |
||
| 101 | * check if ownCloud runs in cli mode |
||
| 102 | */ |
||
| 103 | public static $CLI = false; |
||
| 104 | |||
| 105 | /** |
||
| 106 | * @var \OC\Autoloader $loader |
||
| 107 | */ |
||
| 108 | public static $loader = null; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @var \OC\Server |
||
| 112 | */ |
||
| 113 | public static $server = null; |
||
| 114 | |||
| 115 | /** |
||
| 116 | * @var \OC\Config |
||
| 117 | */ |
||
| 118 | private static $config = null; |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @throws \RuntimeException when the 3rdparty directory is missing or |
||
| 122 | * the app path list is empty or contains an invalid path |
||
| 123 | */ |
||
| 124 | public static function initPaths() { |
||
| 125 | if(defined('PHPUNIT_CONFIG_DIR')) { |
||
| 126 | self::$configDir = OC::$SERVERROOT . '/' . PHPUNIT_CONFIG_DIR . '/'; |
||
| 127 | } elseif(defined('PHPUNIT_RUN') and PHPUNIT_RUN and is_dir(OC::$SERVERROOT . '/tests/config/')) { |
||
| 128 | self::$configDir = OC::$SERVERROOT . '/tests/config/'; |
||
| 129 | } else { |
||
| 130 | self::$configDir = OC::$SERVERROOT . '/config/'; |
||
| 131 | } |
||
| 132 | self::$config = new \OC\Config(self::$configDir); |
||
| 133 | |||
| 134 | OC::$SUBURI = str_replace("\\", "/", substr(realpath($_SERVER["SCRIPT_FILENAME"]), strlen(OC::$SERVERROOT))); |
||
| 135 | /** |
||
| 136 | * FIXME: The following lines are required because we can't yet instantiiate |
||
| 137 | * \OC::$server->getRequest() since \OC::$server does not yet exist. |
||
| 138 | */ |
||
| 139 | $params = [ |
||
| 140 | 'server' => [ |
||
| 141 | 'SCRIPT_NAME' => $_SERVER['SCRIPT_NAME'], |
||
| 142 | 'SCRIPT_FILENAME' => $_SERVER['SCRIPT_FILENAME'], |
||
| 143 | ], |
||
| 144 | ]; |
||
| 145 | $fakeRequest = new \OC\AppFramework\Http\Request($params, null, new \OC\AllConfig(new \OC\SystemConfig(self::$config))); |
||
| 146 | $scriptName = $fakeRequest->getScriptName(); |
||
| 147 | if (substr($scriptName, -1) == '/') { |
||
| 148 | $scriptName .= 'index.php'; |
||
| 149 | //make sure suburi follows the same rules as scriptName |
||
| 150 | if (substr(OC::$SUBURI, -9) != 'index.php') { |
||
| 151 | if (substr(OC::$SUBURI, -1) != '/') { |
||
| 152 | OC::$SUBURI = OC::$SUBURI . '/'; |
||
| 153 | } |
||
| 154 | OC::$SUBURI = OC::$SUBURI . 'index.php'; |
||
| 155 | } |
||
| 156 | } |
||
| 157 | |||
| 158 | |||
| 159 | if (OC::$CLI) { |
||
| 160 | OC::$WEBROOT = self::$config->getValue('overwritewebroot', ''); |
||
| 161 | } else { |
||
| 162 | if (substr($scriptName, 0 - strlen(OC::$SUBURI)) === OC::$SUBURI) { |
||
| 163 | OC::$WEBROOT = substr($scriptName, 0, 0 - strlen(OC::$SUBURI)); |
||
| 164 | |||
| 165 | if (OC::$WEBROOT != '' && OC::$WEBROOT[0] !== '/') { |
||
| 166 | OC::$WEBROOT = '/' . OC::$WEBROOT; |
||
| 167 | } |
||
| 168 | } else { |
||
| 169 | // The scriptName is not ending with OC::$SUBURI |
||
| 170 | // This most likely means that we are calling from CLI. |
||
| 171 | // However some cron jobs still need to generate |
||
| 172 | // a web URL, so we use overwritewebroot as a fallback. |
||
| 173 | OC::$WEBROOT = self::$config->getValue('overwritewebroot', ''); |
||
| 174 | } |
||
| 175 | |||
| 176 | // Resolve /owncloud to /owncloud/ to ensure to always have a trailing |
||
| 177 | // slash which is required by URL generation. |
||
| 178 | if($_SERVER['REQUEST_URI'] === \OC::$WEBROOT && |
||
| 179 | substr($_SERVER['REQUEST_URI'], -1) !== '/') { |
||
| 180 | header('Location: '.\OC::$WEBROOT.'/'); |
||
| 181 | exit(); |
||
| 182 | } |
||
| 183 | } |
||
| 184 | |||
| 185 | // search the 3rdparty folder |
||
| 186 | OC::$THIRDPARTYROOT = self::$config->getValue('3rdpartyroot', null); |
||
| 187 | OC::$THIRDPARTYWEBROOT = self::$config->getValue('3rdpartyurl', null); |
||
| 188 | |||
| 189 | if (empty(OC::$THIRDPARTYROOT) && empty(OC::$THIRDPARTYWEBROOT)) { |
||
| 190 | if (file_exists(OC::$SERVERROOT . '/3rdparty')) { |
||
| 191 | OC::$THIRDPARTYROOT = OC::$SERVERROOT; |
||
| 192 | OC::$THIRDPARTYWEBROOT = OC::$WEBROOT; |
||
| 193 | } elseif (file_exists(OC::$SERVERROOT . '/../3rdparty')) { |
||
| 194 | OC::$THIRDPARTYWEBROOT = rtrim(dirname(OC::$WEBROOT), '/'); |
||
| 195 | OC::$THIRDPARTYROOT = rtrim(dirname(OC::$SERVERROOT), '/'); |
||
| 196 | } |
||
| 197 | } |
||
| 198 | if (empty(OC::$THIRDPARTYROOT) || !file_exists(OC::$THIRDPARTYROOT)) { |
||
| 199 | throw new \RuntimeException('3rdparty directory not found! Please put the ownCloud 3rdparty' |
||
| 200 | . ' folder in the ownCloud folder or the folder above.' |
||
| 201 | . ' You can also configure the location in the config.php file.'); |
||
| 202 | } |
||
| 203 | |||
| 204 | // search the apps folder |
||
| 205 | $config_paths = self::$config->getValue('apps_paths', array()); |
||
| 206 | if (!empty($config_paths)) { |
||
| 207 | foreach ($config_paths as $paths) { |
||
| 208 | if (isset($paths['url']) && isset($paths['path'])) { |
||
| 209 | $paths['url'] = rtrim($paths['url'], '/'); |
||
| 210 | $paths['path'] = rtrim($paths['path'], '/'); |
||
| 211 | OC::$APPSROOTS[] = $paths; |
||
| 212 | } |
||
| 213 | } |
||
| 214 | View Code Duplication | } elseif (file_exists(OC::$SERVERROOT . '/apps')) { |
|
|
|
|||
| 215 | OC::$APPSROOTS[] = array('path' => OC::$SERVERROOT . '/apps', 'url' => '/apps', 'writable' => true); |
||
| 216 | } elseif (file_exists(OC::$SERVERROOT . '/../apps')) { |
||
| 217 | OC::$APPSROOTS[] = array( |
||
| 218 | 'path' => rtrim(dirname(OC::$SERVERROOT), '/') . '/apps', |
||
| 219 | 'url' => '/apps', |
||
| 220 | 'writable' => true |
||
| 221 | ); |
||
| 222 | } |
||
| 223 | |||
| 224 | if (empty(OC::$APPSROOTS)) { |
||
| 225 | throw new \RuntimeException('apps directory not found! Please put the ownCloud apps folder in the ownCloud folder' |
||
| 226 | . ' or the folder above. You can also configure the location in the config.php file.'); |
||
| 227 | } |
||
| 228 | $paths = array(); |
||
| 229 | foreach (OC::$APPSROOTS as $path) { |
||
| 230 | $paths[] = $path['path']; |
||
| 231 | if (!is_dir($path['path'])) { |
||
| 232 | throw new \RuntimeException(sprintf('App directory "%s" not found! Please put the ownCloud apps folder in the' |
||
| 233 | . ' ownCloud folder or the folder above. You can also configure the location in the' |
||
| 234 | . ' config.php file.', $path['path'])); |
||
| 235 | } |
||
| 236 | } |
||
| 237 | |||
| 238 | // set the right include path |
||
| 239 | set_include_path( |
||
| 240 | OC::$SERVERROOT . '/lib/private' . PATH_SEPARATOR . |
||
| 241 | OC::$SERVERROOT . '/config' . PATH_SEPARATOR . |
||
| 242 | OC::$THIRDPARTYROOT . '/3rdparty' . PATH_SEPARATOR . |
||
| 243 | implode(PATH_SEPARATOR, $paths) . PATH_SEPARATOR . |
||
| 244 | get_include_path() . PATH_SEPARATOR . |
||
| 245 | OC::$SERVERROOT |
||
| 246 | ); |
||
| 247 | } |
||
| 248 | |||
| 249 | public static function checkConfig() { |
||
| 250 | $l = \OC::$server->getL10N('lib'); |
||
| 251 | |||
| 252 | // Create config if it does not already exist |
||
| 253 | $configFilePath = self::$configDir .'/config.php'; |
||
| 254 | if(!file_exists($configFilePath)) { |
||
| 255 | @touch($configFilePath); |
||
| 256 | } |
||
| 257 | |||
| 258 | // Check if config is writable |
||
| 259 | $configFileWritable = is_writable($configFilePath); |
||
| 260 | if (!$configFileWritable && !OC_Helper::isReadOnlyConfigEnabled() |
||
| 261 | || !$configFileWritable && self::checkUpgrade(false)) { |
||
| 262 | |||
| 263 | $urlGenerator = \OC::$server->getURLGenerator(); |
||
| 264 | |||
| 265 | if (self::$CLI) { |
||
| 266 | echo $l->t('Cannot write into "config" directory!')."\n"; |
||
| 267 | echo $l->t('This can usually be fixed by giving the webserver write access to the config directory')."\n"; |
||
| 268 | echo "\n"; |
||
| 269 | echo $l->t('See %s', [ $urlGenerator->linkToDocs('admin-dir_permissions') ])."\n"; |
||
| 270 | exit; |
||
| 271 | } else { |
||
| 272 | OC_Template::printErrorPage( |
||
| 273 | $l->t('Cannot write into "config" directory!'), |
||
| 274 | $l->t('This can usually be fixed by ' |
||
| 275 | . '%sgiving the webserver write access to the config directory%s.', |
||
| 276 | array('<a href="' . $urlGenerator->linkToDocs('admin-dir_permissions') . '" target="_blank">', '</a>')) |
||
| 277 | ); |
||
| 278 | } |
||
| 279 | } |
||
| 280 | } |
||
| 281 | |||
| 282 | public static function checkInstalled() { |
||
| 283 | if (defined('OC_CONSOLE')) { |
||
| 284 | return; |
||
| 285 | } |
||
| 286 | // Redirect to installer if not installed |
||
| 287 | if (!\OC::$server->getSystemConfig()->getValue('installed', false) && OC::$SUBURI != '/index.php') { |
||
| 288 | if (OC::$CLI) { |
||
| 289 | throw new Exception('Not installed'); |
||
| 290 | } else { |
||
| 291 | $url = 'http://' . $_SERVER['SERVER_NAME'] . OC::$WEBROOT . '/index.php'; |
||
| 292 | header('Location: ' . $url); |
||
| 293 | } |
||
| 294 | exit(); |
||
| 295 | } |
||
| 296 | } |
||
| 297 | |||
| 298 | public static function checkMaintenanceMode() { |
||
| 299 | // Allow ajax update script to execute without being stopped |
||
| 300 | if (\OC::$server->getSystemConfig()->getValue('maintenance', false) && OC::$SUBURI != '/core/ajax/update.php') { |
||
| 301 | // send http status 503 |
||
| 302 | header('HTTP/1.1 503 Service Temporarily Unavailable'); |
||
| 303 | header('Status: 503 Service Temporarily Unavailable'); |
||
| 304 | header('Retry-After: 120'); |
||
| 305 | |||
| 306 | // render error page |
||
| 307 | $template = new OC_Template('', 'update.user', 'guest'); |
||
| 308 | OC_Util::addscript('maintenance-check'); |
||
| 309 | $template->printPage(); |
||
| 310 | die(); |
||
| 311 | } |
||
| 312 | } |
||
| 313 | |||
| 314 | public static function checkSingleUserMode($lockIfNoUserLoggedIn = false) { |
||
| 315 | if (!\OC::$server->getSystemConfig()->getValue('singleuser', false)) { |
||
| 316 | return; |
||
| 317 | } |
||
| 318 | $user = OC_User::getUserSession()->getUser(); |
||
| 319 | if ($user) { |
||
| 320 | $group = \OC::$server->getGroupManager()->get('admin'); |
||
| 321 | if ($group->inGroup($user)) { |
||
| 322 | return; |
||
| 323 | } |
||
| 324 | } else { |
||
| 325 | if(!$lockIfNoUserLoggedIn) { |
||
| 326 | return; |
||
| 327 | } |
||
| 328 | } |
||
| 329 | // send http status 503 |
||
| 330 | header('HTTP/1.1 503 Service Temporarily Unavailable'); |
||
| 331 | header('Status: 503 Service Temporarily Unavailable'); |
||
| 332 | header('Retry-After: 120'); |
||
| 333 | |||
| 334 | // render error page |
||
| 335 | $template = new OC_Template('', 'singleuser.user', 'guest'); |
||
| 336 | $template->printPage(); |
||
| 337 | die(); |
||
| 338 | } |
||
| 339 | |||
| 340 | /** |
||
| 341 | * check if the instance needs to perform an upgrade |
||
| 342 | * |
||
| 343 | * @return bool |
||
| 344 | * @deprecated use \OCP\Util::needUpgrade() instead |
||
| 345 | */ |
||
| 346 | public static function needUpgrade() { |
||
| 347 | return \OCP\Util::needUpgrade(); |
||
| 348 | } |
||
| 349 | |||
| 350 | /** |
||
| 351 | * Checks if the version requires an update and shows |
||
| 352 | * @param bool $showTemplate Whether an update screen should get shown |
||
| 353 | * @return bool|void |
||
| 354 | */ |
||
| 355 | 21 | public static function checkUpgrade($showTemplate = true) { |
|
| 356 | 21 | if (\OCP\Util::needUpgrade()) { |
|
| 357 | $systemConfig = \OC::$server->getSystemConfig(); |
||
| 358 | if ($showTemplate && !$systemConfig->getValue('maintenance', false)) { |
||
| 359 | self::printUpgradePage(); |
||
| 360 | exit(); |
||
| 361 | } else { |
||
| 362 | return true; |
||
| 363 | } |
||
| 364 | } |
||
| 365 | 21 | return false; |
|
| 366 | } |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Prints the upgrade page |
||
| 370 | */ |
||
| 371 | private static function printUpgradePage() { |
||
| 372 | $systemConfig = \OC::$server->getSystemConfig(); |
||
| 373 | $oldTheme = $systemConfig->getValue('theme'); |
||
| 374 | $systemConfig->setValue('theme', ''); |
||
| 375 | \OCP\Util::addScript('config'); // needed for web root |
||
| 376 | \OCP\Util::addScript('update'); |
||
| 377 | |||
| 378 | // check whether this is a core update or apps update |
||
| 379 | $installedVersion = $systemConfig->getValue('version', '0.0.0'); |
||
| 380 | $currentVersion = implode('.', \OCP\Util::getVersion()); |
||
| 381 | |||
| 382 | $appManager = \OC::$server->getAppManager(); |
||
| 383 | |||
| 384 | $tmpl = new OC_Template('', 'update.admin', 'guest'); |
||
| 385 | $tmpl->assign('version', OC_Util::getVersionString()); |
||
| 386 | |||
| 387 | // if not a core upgrade, then it's apps upgrade |
||
| 388 | if (version_compare($currentVersion, $installedVersion, '=')) { |
||
| 389 | $tmpl->assign('isAppsOnlyUpgrade', true); |
||
| 390 | } else { |
||
| 391 | $tmpl->assign('isAppsOnlyUpgrade', false); |
||
| 392 | } |
||
| 393 | |||
| 394 | // get third party apps |
||
| 395 | $ocVersion = \OCP\Util::getVersion(); |
||
| 396 | $tmpl->assign('appsToUpgrade', $appManager->getAppsNeedingUpgrade($ocVersion)); |
||
| 397 | $tmpl->assign('incompatibleAppsList', $appManager->getIncompatibleApps($ocVersion)); |
||
| 398 | $tmpl->assign('productName', 'ownCloud'); // for now |
||
| 399 | $tmpl->assign('oldTheme', $oldTheme); |
||
| 400 | $tmpl->printPage(); |
||
| 401 | } |
||
| 402 | |||
| 403 | public static function initSession() { |
||
| 404 | // prevents javascript from accessing php session cookies |
||
| 405 | ini_set('session.cookie_httponly', true); |
||
| 406 | |||
| 407 | // set the cookie path to the ownCloud directory |
||
| 408 | $cookie_path = OC::$WEBROOT ? : '/'; |
||
| 409 | ini_set('session.cookie_path', $cookie_path); |
||
| 410 | |||
| 411 | // Let the session name be changed in the initSession Hook |
||
| 412 | $sessionName = OC_Util::getInstanceId(); |
||
| 413 | |||
| 414 | try { |
||
| 415 | // Allow session apps to create a custom session object |
||
| 416 | $useCustomSession = false; |
||
| 417 | $session = self::$server->getSession(); |
||
| 418 | OC_Hook::emit('OC', 'initSession', array('session' => &$session, 'sessionName' => &$sessionName, 'useCustomSession' => &$useCustomSession)); |
||
| 419 | if (!$useCustomSession) { |
||
| 420 | // set the session name to the instance id - which is unique |
||
| 421 | $session = new \OC\Session\Internal($sessionName); |
||
| 422 | } |
||
| 423 | |||
| 424 | $cryptoWrapper = \OC::$server->getSessionCryptoWrapper(); |
||
| 425 | $session = $cryptoWrapper->wrapSession($session); |
||
| 426 | self::$server->setSession($session); |
||
| 427 | |||
| 428 | // if session cant be started break with http 500 error |
||
| 429 | } catch (Exception $e) { |
||
| 430 | \OCP\Util::logException('base', $e); |
||
| 431 | //show the user a detailed error page |
||
| 432 | OC_Response::setStatus(OC_Response::STATUS_INTERNAL_SERVER_ERROR); |
||
| 433 | OC_Template::printExceptionErrorPage($e); |
||
| 434 | die(); |
||
| 435 | } |
||
| 436 | |||
| 437 | $sessionLifeTime = self::getSessionLifeTime(); |
||
| 438 | |||
| 439 | // session timeout |
||
| 440 | if ($session->exists('LAST_ACTIVITY') && (time() - $session->get('LAST_ACTIVITY') > $sessionLifeTime)) { |
||
| 441 | if (isset($_COOKIE[session_name()])) { |
||
| 442 | setcookie(session_name(), null, -1, self::$WEBROOT ? : '/'); |
||
| 443 | } |
||
| 444 | $session->clear(); |
||
| 445 | } |
||
| 446 | |||
| 447 | $session->set('LAST_ACTIVITY', time()); |
||
| 448 | } |
||
| 449 | |||
| 450 | /** |
||
| 451 | * @return string |
||
| 452 | */ |
||
| 453 | private static function getSessionLifeTime() { |
||
| 456 | |||
| 457 | public static function loadAppClassPaths() { |
||
| 458 | foreach (OC_APP::getEnabledApps() as $app) { |
||
| 459 | $appPath = OC_App::getAppPath($app); |
||
| 460 | if ($appPath === false) { |
||
| 461 | continue; |
||
| 462 | } |
||
| 463 | |||
| 464 | $file = $appPath . '/appinfo/classpath.php'; |
||
| 465 | if (file_exists($file)) { |
||
| 470 | |||
| 471 | /** |
||
| 472 | * Try to set some values to the required ownCloud default |
||
| 473 | */ |
||
| 474 | public static function setRequiredIniValues() { |
||
| 477 | |||
| 478 | public static function init() { |
||
| 701 | |||
| 702 | private static function registerLocalAddressBook() { |
||
| 709 | |||
| 710 | /** |
||
| 711 | * register hooks for the cache |
||
| 712 | */ |
||
| 713 | 570 | public static function registerCacheHooks() { |
|
| 731 | |||
| 732 | private static function registerEncryptionWrapper() { |
||
| 735 | |||
| 736 | private static function registerEncryptionHooks() { |
||
| 745 | |||
| 746 | /** |
||
| 747 | * register hooks for the cache |
||
| 748 | */ |
||
| 749 | public static function registerLogRotate() { |
||
| 757 | |||
| 758 | /** |
||
| 759 | * register hooks for the filesystem |
||
| 760 | */ |
||
| 761 | public static function registerFilesystemHooks() { |
||
| 766 | |||
| 767 | /** |
||
| 768 | * register hooks for previews |
||
| 769 | */ |
||
| 770 | public static function registerPreviewHooks() { |
||
| 780 | |||
| 781 | /** |
||
| 782 | * register hooks for sharing |
||
| 783 | */ |
||
| 784 | 90 | public static function registerShareHooks() { |
|
| 793 | |||
| 794 | protected static function registerAutoloaderCache() { |
||
| 810 | |||
| 811 | /** |
||
| 812 | * Handle the request |
||
| 813 | */ |
||
| 814 | public static function handleRequest() { |
||
| 924 | |||
| 925 | protected static function handleAuthHeaders() { |
||
| 945 | |||
| 946 | protected static function handleLogin() { |
||
| 972 | |||
| 973 | /** |
||
| 974 | * Remove outdated and therefore invalid tokens for a user |
||
| 975 | * @param string $user |
||
| 976 | */ |
||
| 977 | protected static function cleanupLoginTokens($user) { |
||
| 988 | |||
| 989 | /** |
||
| 990 | * Try to login a user via HTTP authentication |
||
| 991 | * @return bool|void |
||
| 992 | */ |
||
| 993 | protected static function tryApacheAuth() { |
||
| 1006 | |||
| 1007 | /** |
||
| 1008 | * Try to login a user using the remember me cookie. |
||
| 1009 | * @return bool Whether the provided cookie was valid |
||
| 1010 | */ |
||
| 1011 | protected static function tryRememberLogin() { |
||
| 1045 | |||
| 1046 | /** |
||
| 1047 | * Tries to login a user using the form based authentication |
||
| 1048 | * @return bool|void |
||
| 1049 | */ |
||
| 1050 | protected static function tryFormLogin() { |
||
| 1089 | |||
| 1090 | } |
||
| 1091 | |||
| 1094 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.