owncloud / core

apps/dav/lib/Upload/FutureFileZsync.php

Unused Use Statements -2 removed lines

@@ -20,8 +20,6 @@
  */
 namespace OCA\DAV\Upload;
 
-use OCA\DAV\Connector\Sabre\Directory;
-use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\IFile;
 
 /**

lib/private/User/Manager.php

Doc Comments +3 added lines

@@ -432,6 +432,9 @@
 		}, $accounts);
 	}
 
+	/**
+	 * @param string $backendClass
+	 */
 	public function getBackend($backendClass) {
 		if (isset($this->backends[$backendClass])) {
 			return $this->backends[$backendClass];

lib/private/Share/Share.php

Doc Comments +1 added lines, -1 removed lines

@@ -2870,7 +2870,7 @@
 	}
 
 	/**
-	 * @param $user
+	 * @param string|boolean $user
 	 * @return Group[]
 	 */
 	private static function getGroupsForUser($user) {

lib/private/App/CodeChecker/NodeVisitor.php

Doc Comments +3 added lines

@@ -296,6 +296,9 @@
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function buildReason($name, $errorCode) {
 		if (isset($this->errorMessages[$errorCode])) {
 			$desc = $this->list->getDescription($errorCode, $name);

lib/private/L10N/L10N.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
 	/**
 	 * Translating
 	 * @param string $text The text we need a translation for
-	 * @param array $parameters default:array() Parameters for sprintf
+	 * @param string[] $parameters default:array() Parameters for sprintf
 	 * @return string Translation or the same text
 	 *
 	 * Returns the translation. If no translation is found, $text will be
@@ -172,7 +172,7 @@ 
 	 * Returns an associative array with all translations
 	 *
 	 * Called by String
-	 * @return array
+	 * @return string[]
 	 */
 	public function getTranslations() {
 		return $this->translations;

apps/files/lib/Command/Scan.php

Doc Comments +5 added lines

@@ -311,6 +311,11 @@
 		}
 	}
 
+	/**
+	 * @param InputInterface $input
+	 * @param OutputInterface $output
+	 * @param boolean $shouldRepairStoragesIndividually
+	 */
 	protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
 		# no messaging level option means: no full printout but statistics
 		# $quiet   means no print at all

lib/private/User/Session.php

Doc Comments +8 added lines, -2 removed lines

@@ -323,7 +323,7 @@ 
 	 * @throws \InvalidArgumentException
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -366,6 +366,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -988,6 +991,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		$shallLogout = false;
 		try {
@@ -1019,7 +1025,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 

lib/private/Notification/Manager.php

Doc Comments +2 added lines

@@ -113,6 +113,8 @@
 	 * INTERNAL USE ONLY!! This method isn't part of the IManager interface
 	 * @internal This should only be used by the RegisterNotifierEventImpl (the real implementation).
 	 * Do NOT use this method outside as it might not work as expected.
+	 * @param string $id
+	 * @param string $name
 	 */
 	public function registerBuiltNotifier(INotifier $notifier, $id, $name) {
 		if (!isset($this->builtNotifiersHolder[$id]) && !isset($this->notifiersInfo[$id])) {