Completed
Pull Request — master (#32767)
by Thomas
14:30
created
lib/public/Util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -657,7 +657,7 @@
 block discarded – undo
657 657
 	/**
658 658
 	 * Determine if the string is, strictly-speaking, empty or not
659 659
 	 *
660
-	 * @param $value
660
+	 * @param string $value
661 661
 	 * @return bool
662 662
 	 * @since 10.0.1
663 663
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,8 @@  discard block
 block discarded – undo
223 223
 	}
224 224
 
225 225
 	/**
226
-	 * @param $addressBookUri
226
+	 * @param string $addressBookUri
227
+	 * @param string $principal
227 228
 	 * @return array|null
228 229
 	 */
229 230
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -912,6 +913,7 @@  discard block
 block discarded – undo
912 913
 	 *   * readOnly - boolean
913 914
 	 *   * summary - Optional, a description for the share
914 915
 	 *
916
+	 * @param integer $addressBookId
915 917
 	 * @return array
916 918
 	 */
917 919
 	public function getShares($addressBookId) {
@@ -1017,7 +1019,7 @@  discard block
 block discarded – undo
1017 1019
 
1018 1020
 	/**
1019 1021
 	 * For shared address books the sharee is set in the ACL of the address book
1020
-	 * @param $addressBookId
1022
+	 * @param integer $addressBookId
1021 1023
 	 * @param $acl
1022 1024
 	 * @return array
1023 1025
 	 */
@@ -1025,6 +1027,9 @@  discard block
 block discarded – undo
1025 1027
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1026 1028
 	}
1027 1029
 
1030
+	/**
1031
+	 * @param boolean $toV2
1032
+	 */
1028 1033
 	private function convertPrincipal($principalUri, $toV2 = null) {
1029 1034
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1030 1035
 			list(, $name) = \Sabre\Uri\split($principalUri);
Please login to merge, or discard this patch.
core/Command/Db/Migrations/GenerateCommand.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -146,6 +146,9 @@
 block discarded – undo
146 146
 		return $path;
147 147
 	}
148 148
 
149
+	/**
150
+	 * @param string $kind
151
+	 */
149 152
 	private function getTemplate($kind) {
150 153
 		if ($kind === 'simple') {
151 154
 			return self::$_templateSimple;
Please login to merge, or discard this patch.
core/Command/Encryption/ChangeKeyStorageRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
 	/**
247 247
 	 * check if target already exists
248 248
 	 *
249
-	 * @param $path
249
+	 * @param string $path
250 250
 	 * @return bool
251 251
 	 * @throws \Exception
252 252
 	 */
Please login to merge, or discard this patch.
core/Command/User/ResetPassword.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -32,12 +32,7 @@
 block discarded – undo
32 32
 use OC\Helper\EnvironmentHelper;
33 33
 use OCP\AppFramework\Utility\ITimeFactory;
34 34
 use OCP\IConfig;
35
-use OCP\IL10N;
36
-use OCP\IURLGenerator;
37 35
 use OCP\IUserManager;
38
-use OCP\Mail\IMailer;
39
-use OCP\Security\ISecureRandom;
40
-use OCP\Util;
41 36
 use Symfony\Component\Console\Command\Command;
42 37
 use Symfony\Component\Console\Input\InputInterface;
43 38
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.