owncloud / core

apps/files_trashbin/lib/Trashbin.php

Doc Comments +6 added lines, -2 removed lines

@@ -259,6 +259,9 @@ 
 
 	/**
 	 *
+	 * @param string $targetFilename
+	 * @param string $targetLocation
+	 * @param integer $timestamp
 	 */
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -784,7 +787,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -818,7 +821,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */
@@ -888,6 +891,7 @@ 
 	 *
 	 * @param string $filename name of the file which should be restored
 	 * @param int $timestamp timestamp when the file was deleted
+	 * @param string|boolean $user
 	 * @return array
 	 */
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {

lib/private/Files/Storage/Common.php

Doc Comments +1 added lines, -1 removed lines

@@ -708,7 +708,7 @@
 	}
 
 	/**
-	 * @param $internalPath
+	 * @param string $internalPath
 	 * @return array
 	 */
 	public function convertInternalPathToGlobalPath($internalPath) {

Unused Use Statements -1 removed lines

@@ -53,7 +53,6 @@
 use OCP\Files\InvalidPathException;
 use OCP\Files\ReservedWordException;
 use OCP\Files\Storage\ILockingStorage;
-use OCP\Files\Storage\IStorage;
 use OCP\Files\Storage\IPersistentLockingStorage;
 use OCP\Files\Storage\IVersionedStorage;
 use OCP\Lock\ILockingProvider;

apps/dav/lib/Connector/Sabre/Auth.php

Doc Comments +1 added lines, -1 removed lines

@@ -255,7 +255,7 @@
 	}
 
 	/**
-	 * @param $user
+	 * @param \OCP\IUser|null $user
 	 * @throws ServiceUnavailable
 	 */
 	private function checkAccountModule($user) {

apps/files_versions/lib/Storage.php

Doc Comments +3 added lines

@@ -315,6 +315,9 @@
 		}
 	}
 
+	/**
+	 * @param string $revision
+	 */
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
 		if (\OC::$server->getConfig()->getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
 			return false;

lib/private/Files/Storage/FailedStorage.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OC\Files\Storage;
 
 use OC\Files\Cache\FailedCache;
-use OCP\Files\Storage\IStorage;
 use \OCP\Lock\ILockingProvider;
 use \OCP\Files\StorageNotAvailableException;
 

lib/private/Files/Storage/Local.php

Unused Use Statements -1 removed lines

@@ -37,7 +37,6 @@
 namespace OC\Files\Storage;
 
 use OCP\Files\ForbiddenException;
-use OCP\Files\Storage\IStorage;
 
 /**
  * for local filestore, we only have to map the paths

apps/federatedfilesharing/lib/FederatedShareProvider.php

Doc Comments +8 added lines, -8 removed lines

@@ -394,7 +394,7 @@ 
 	/**
 	 * store remote ID in federated reShare table
 	 *
-	 * @param $shareId
+	 * @param integer $shareId
 	 * @param $remoteId
 	 */
 	public function storeRemoteId($shareId, $remoteId) {
@@ -801,7 +801,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */
@@ -1001,12 +1001,12 @@ 
 	}
 
 	/**
-	 * @param $remote
-	 * @param $token
-	 * @param $name
-	 * @param $owner
-	 * @param $shareWith
-	 * @param $remoteId
+	 * @param string $remote
+	 * @param string $token
+	 * @param string $name
+	 * @param string $owner
+	 * @param string $shareWith
+	 * @param integer $remoteId
 	 *
 	 * @return int
 	 */

lib/private/Lock/Persistent/Lock.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 	/**
 	 * Unix timestamp when lock was created
 	 *
-	 * @return mixed
+	 * @return integer
 	 * @since 11.0.0
 	 */
 	public function getCreatedAt(): int {

core/Controller/LostController.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */
@@ -281,7 +281,7 @@ 
 
 	/**
 	 * @param string $userId
-	 * @return array
+	 * @return string[]
 	 */
 	public function generateTokenAndLink($userId) {
 		$token = $this->secureRandom->generate(21,