owncloud / core

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -284,6 +284,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -673,7 +676,7 @@ 
 	 * if smb.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -700,6 +703,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) {
 			Util::writeLog('smb', "$function swallowing ".get_class($exception)

lib/private/Share/MailNotifications.php

Doc Comments +3 added lines, -3 removed lines

@@ -180,10 +180,10 @@
 	 * inform recipient about public link share
 	 *
 	 * @param string $recipient recipient email address
-	 * @param string $filename the shared file
-	 * @param string $link the public link
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
-	 * @param int $expiration expiration date (timestamp)
+	 * @param string $subject
+	 * @param boolean|string $htmlBody
+	 * @param boolean|string $textBody
 	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = array()) {

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -270,6 +270,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1279,7 +1282,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 * @throws Forbidden
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/User/Session.php

Doc Comments +8 added lines, -2 removed lines

@@ -323,7 +323,7 @@ 
 	 * @throws \InvalidArgumentException
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -366,6 +366,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -988,6 +991,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		$shallLogout = false;
 		try {
@@ -1019,7 +1025,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;