Completed
Pull Request — master (#29107)
by Piotr
09:39
created
lib/private/Preview/Movie.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	}
82 82
 
83 83
 	/**
84
-	 * @param $absPath
85
-	 * @return bool|string
84
+	 * @param string $absPath
85
+	 * @return false|string
86 86
 	 */
87 87
 	private function extractMp4CoverArtwork($absPath) {
88 88
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	}
119 119
 
120 120
 	/**
121
-	 * @param $absPath
122
-	 * @param $second
123
-	 * @return bool|string
121
+	 * @param string $absPath
122
+	 * @param integer $second
123
+	 * @return string|false
124 124
 	 */
125 125
 	private function generateFromMovie($absPath, $second) {
126 126
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
Please login to merge, or discard this patch.
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * @param string $version
364
-	 * @return mixed
364
+	 * @return \Doctrine\DBAL\Schema\Schema
365 365
 	 * @throws \Exception
366 366
 	 */
367 367
 	protected function createInstance($version) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -319,6 +319,7 @@
 block discarded – undo
319 319
 		* @param string $error_msg The error message to show
320 320
 		* @param string $hint An optional hint message - needs to be properly escaped
321 321
 		* @param int HTTP Status Code
322
+		* @param integer $httpStatusCode
322 323
 		*/
323 324
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
324 325
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
 	 * Returns an associative array with all translations
172 172
 	 *
173 173
 	 * Called by String
174
-	 * @return array
174
+	 * @return string[]
175 175
 	 */
176 176
 	public function getTranslations() {
177 177
 		return $this->translations;
Please login to merge, or discard this patch.
lib/public/Template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.
settings/Controller/CorsController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,6 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Removes a WhiteListed Domain
133 133
 	 *
134
-	 * @param string $domain Domain to remove
135 134
 	 * @return RedirectResponse Redirection to the settings page.
136 135
 	 */
137 136
 	public function removeDomain($id) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
 
219 219
 	/**
220 220
 	 *
221
+	 * @param string $targetFilename
222
+	 * @param string $targetLocation
223
+	 * @param integer $timestamp
221 224
 	 */
222 225
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
223 226
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@  discard block
 block discarded – undo
330 333
 	 * @param string $ownerPath path relative to the owner's home storage
331 334
 	 * @param integer $timestamp when the file was deleted
332 335
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
336
+	 * @param \OC\Files\Storage\Storage $sourceStorage
333 337
 	 */
334 338
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
335 339
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@  discard block
 block discarded – undo
780 784
 	 * if the size limit for the trash bin is reached, we delete the oldest
781 785
 	 * files in the trash bin until we meet the limit again
782 786
 	 *
783
-	 * @param array $files
787
+	 * @param \OCP\Files\FileInfo[] $files
784 788
 	 * @param string $user
785 789
 	 * @param int $availableSpace available disc space
786 790
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@  discard block
 block discarded – undo
808 812
 	/**
809 813
 	 * delete files older then max storage time
810 814
 	 *
811
-	 * @param array $files list of files sorted by mtime
815
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
812 816
 	 * @param string $user
813 817
 	 * @return integer[] size of deleted files and number of deleted files
814 818
 	 */
Please login to merge, or discard this patch.
core/Command/Security/ListRoutes.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -122,6 +122,9 @@
 block discarded – undo
122 122
 		}
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param integer $name
127
+	 */
125 128
 	private function buildController($name) {
126 129
 		$parts = explode('.', $name);
127 130
 		if (count($parts) === 4 && $parts[0] === 'ocs') {
Please login to merge, or discard this patch.
lib/private/Files/Storage/CacheableFlysystem.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@
 block discarded – undo
50 50
 		return $location;
51 51
 	}
52 52
 
53
+	/**
54
+	 * @param string $path
55
+	 */
53 56
 	public function buildPath($path) {
54 57
 		$location = parent::buildPath($path);
55 58
 		if ($this->isCaseInsensitiveStorage) {
Please login to merge, or discard this patch.