Completed
Pull Request — master (#26112)
by Thomas
12:39
created
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1036,7 +1036,7 @@  discard block
 block discarded – undo
1036 1036
 	 * @param string $principalUri
1037 1037
 	 * @param string $uri
1038 1038
 	 * @param array $properties
1039
-	 * @return mixed
1039
+	 * @return integer
1040 1040
 	 */
1041 1041
 	function createSubscription($principalUri, $uri, array $properties) {
1042 1042
 
@@ -1377,6 +1377,9 @@  discard block
 block discarded – undo
1377 1377
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1378 1378
 	}
1379 1379
 
1380
+	/**
1381
+	 * @param boolean $toV2
1382
+	 */
1380 1383
 	private function convertPrincipal($principalUri, $toV2) {
1381 1384
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1382 1385
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -187,7 +187,8 @@  discard block
 block discarded – undo
187 187
 	}
188 188
 
189 189
 	/**
190
-	 * @param $addressBookUri
190
+	 * @param string $addressBookUri
191
+	 * @param string $principal
191 192
 	 * @return array|null
192 193
 	 */
193 194
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -867,6 +868,7 @@  discard block
 block discarded – undo
867 868
 	 *   * readOnly - boolean
868 869
 	 *   * summary - Optional, a description for the share
869 870
 	 *
871
+	 * @param integer $addressBookId
870 872
 	 * @return array
871 873
 	 */
872 874
 	public function getShares($addressBookId) {
@@ -966,7 +968,7 @@  discard block
 block discarded – undo
966 968
 
967 969
 	/**
968 970
 	 * For shared address books the sharee is set in the ACL of the address book
969
-	 * @param $addressBookId
971
+	 * @param integer $addressBookId
970 972
 	 * @param $acl
971 973
 	 * @return array
972 974
 	 */
@@ -974,6 +976,9 @@  discard block
 block discarded – undo
974 976
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
975 977
 	}
976 978
 
979
+	/**
980
+	 * @param boolean $toV2
981
+	 */
977 982
 	private function convertPrincipal($principalUri, $toV2) {
978 983
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
979 984
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
 	}
228 228
 
229 229
 	/**
230
-	 * @return array|null
230
+	 * @return string
231 231
 	 */
232 232
 	public function getLocalSystemAddressBook() {
233 233
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/Xml/Groups.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Comments/CommentNode.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/CommentsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	/**
107 107
 	 * Returns an array with all the child nodes
108 108
 	 *
109
-	 * @return \Sabre\DAV\INode[]
109
+	 * @return CommentNode[]
110 110
 	 */
111 111
 	function getChildren() {
112 112
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/LegacyDAVACL.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		);
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param boolean $toV2
64
+	 */
62 65
 	private function convertPrincipal($principal, $toV2) {
63 66
 		list(, $name) = URLUtil::splitPath($principal);
64 67
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.