Completed
Pull Request — master (#31547)
by Jörn Friedrich
47:11 queued 30:29
created
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,12 +39,9 @@
 block discarded – undo
39 39
 use OC\Settings\Controller\AuthSettingsController;
40 40
 use OC\Settings\Controller\CertificateController;
41 41
 use OC\Settings\Controller\CheckSetupController;
42
-use OC\Settings\Controller\GroupsController;
43 42
 use OC\Settings\Controller\LegalSettingsController;
44 43
 use OC\Settings\Controller\LogSettingsController;
45 44
 use OC\Settings\Controller\MailSettingsController;
46
-use OC\Settings\Controller\UsersController;
47
-use OC\Settings\Middleware\SubadminMiddleware;
48 45
 use OCP\AppFramework\App;
49 46
 use OCP\IContainer;
50 47
 use OCP\Util;
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Share20OCS.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
 	/**
512 512
 	 * @param \OCP\Files\File|\OCP\Files\Folder $node
513 513
 	 * @param boolean $includeTags include tags in response
514
-	 * @param int|null $stateFilter state filter or empty for all, defaults to 0 (accepted)
514
+	 * @param integer $stateFilter state filter or empty for all, defaults to 0 (accepted)
515 515
 	 * @return \OC\OCS\Result
516 516
 	 */
517 517
 	private function getSharedWithMe($node = null, $includeTags, $stateFilter = 0) {
@@ -870,7 +870,7 @@  discard block
 block discarded – undo
870 870
 	}
871 871
 
872 872
 	/**
873
-	 * @param $id
873
+	 * @param integer $id
874 874
 	 * @param $state
875 875
 	 * @return \OC\OCS\Result
876 876
 	 */
@@ -1041,6 +1041,7 @@  discard block
 block discarded – undo
1041 1041
 	 * not support this we need to check all backends.
1042 1042
 	 *
1043 1043
 	 * @param string $id
1044
+	 * @param string $recipient
1044 1045
 	 * @return \OCP\Share\IShare
1045 1046
 	 * @throws ShareNotFound
1046 1047
 	 */
Please login to merge, or discard this patch.