Completed
Pull Request — master (#20515)
by Georg
11:16
created
apps/dav/lib/Comments/CommentNode.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/CommentsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Comments/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	/**
107 107
 	 * Returns an array with all the child nodes
108 108
 	 *
109
-	 * @return \Sabre\DAV\INode[]
109
+	 * @return CommentNode[]
110 110
 	 */
111 111
 	function getChildren() {
112 112
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/LegacyDAVACL.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		);
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param boolean $toV2
64
+	 */
62 65
 	private function convertPrincipal($principal, $toV2) {
63 66
 		list(, $name) = URLUtil::splitPath($principal);
64 67
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 	private $cache = [];
76 76
 
77 77
 	/**
78
-	 * @param Tree $tree node tree
78
+	 * @param ObjectTree $tree node tree
79 79
 	 * @param IDBConnection $connection database connection
80 80
 	 * @param IUser $user owner of the tree and properties
81 81
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/DavAclPlugin.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -22,14 +22,11 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Connector\Sabre;
23 23
 
24 24
 use Sabre\DAV\Exception\NotFound;
25
-use Sabre\DAV\IFile;
26 25
 use Sabre\DAV\INode;
27 26
 use \Sabre\DAV\PropFind;
28 27
 use \Sabre\DAV\PropPatch;
29
-use Sabre\DAVACL\Exception\NeedPrivileges;
30 28
 use \Sabre\HTTP\RequestInterface;
31 29
 use \Sabre\HTTP\ResponseInterface;
32
-use Sabre\HTTP\URLUtil;
33 30
 
34 31
 /**
35 32
  * Class DavAclPlugin is a wrapper around \Sabre\DAVACL\Plugin that returns 404
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	private $userFolder;
89 89
 
90 90
 	/**
91
-	 * @param Tree $tree
91
+	 * @param ObjectTree $tree
92 92
 	 * @param View $view
93 93
 	 */
94 94
 	public function __construct(Tree $tree,
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 	 * This will be used in the {DAV:}supported-report-set property.
134 134
 	 *
135 135
 	 * @param string $uri
136
-	 * @return array
136
+	 * @return string[]
137 137
 	 */
138 138
 	public function getSupportedReportSet($uri) {
139 139
 		return [self::REPORT_NAME];
@@ -264,6 +264,7 @@  discard block
 block discarded – undo
264 264
 	 *
265 265
 	 * @param string[] $requestedProps requested properties
266 266
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
267
+	 * @param Node[] $nodes
267 268
 	 * @return Response[]
268 269
 	 */
269 270
 	public function prepareResponses($requestedProps, $nodes) {
Please login to merge, or discard this patch.