Completed
Pull Request — master (#20515)
by Georg
11:16
created
lib/private/Repair/RemoveOldShares.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 	/**
21 21
 	 * RemoveOldCalendarShares constructor.
22 22
 	 *
23
-	 * @param IDBConnection $db
24 23
 	 */
25 24
 	public function __construct(IDBConnection $connection) {
26 25
 		$this->connection = $connection;
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	 *
54 54
 	 * @param RequestInterface $request
55 55
 	 * @param ResponseInterface $response
56
-	 * @return bool|void
56
+	 * @return boolean
57 57
 	 */
58 58
 	function httpGet(RequestInterface $request, ResponseInterface $response) {
59 59
 
Please login to merge, or discard this patch.
apps/dav/lib/AppInfo/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@  discard block
 block discarded – undo
26 26
 use OCA\DAV\CalDAV\CalDavBackend;
27 27
 use OCA\DAV\CardDAV\CardDavBackend;
28 28
 use OCA\DAV\CardDAV\ContactsManager;
29
-use OCA\DAV\CardDAV\SyncJob;
30 29
 use OCA\DAV\CardDAV\SyncService;
31 30
 use OCA\DAV\Connector\Sabre\Principal;
32 31
 use OCA\DAV\DAV\GroupPrincipalBackend;
@@ -36,8 +35,6 @@  discard block
 block discarded – undo
36 35
 use \OCP\AppFramework\App;
37 36
 use OCP\AppFramework\IAppContainer;
38 37
 use OCP\Contacts\IManager;
39
-use OCP\IUser;
40
-use Sabre\VObject\Reader;
41 38
 use Symfony\Component\EventDispatcher\GenericEvent;
42 39
 
43 40
 class Application extends App {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@
 block discarded – undo
278 278
 	 * get default share folder
279 279
 	 *
280 280
 	 * @param \OC\Files\View
281
+	 * @param View $view
281 282
 	 * @return string
282 283
 	 */
283 284
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 	 *
262 262
 	 * @param string $uid
263 263
 	 * @param string $password
264
-	 * @return boolean|null
264
+	 * @return boolean
265 265
 	 * @throws LoginException
266 266
 	 */
267 267
 	public function login($uid, $password) {
@@ -360,6 +360,9 @@  discard block
 block discarded – undo
360 360
 		return $this->config->getSystemValue('token_auth_enforced', false);
361 361
 	}
362 362
 
363
+	/**
364
+	 * @param string $username
365
+	 */
363 366
 	protected function isTwoFactorEnforced($username) {
364 367
 		Util::emitHook(
365 368
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -431,6 +434,9 @@  discard block
 block discarded – undo
431 434
 		return false;
432 435
 	}
433 436
 
437
+	/**
438
+	 * @param string $token
439
+	 */
434 440
 	private function loginWithToken($token) {
435 441
 		try {
436 442
 			$dbToken = $this->tokenProvider->getToken($token);
Please login to merge, or discard this patch.