owncloud / core

lib/private/share20/manager.php

Unused Use Statements -2 removed lines

@@ -25,7 +25,6 @@ 
 use OCP\IUserManager;
 use OCP\Share\IManager;
 use OCP\Share\IProviderFactory;
-use OC\Share20\Exception\BackendError;
 use OCP\IConfig;
 use OCP\IL10N;
 use OCP\ILogger;
@@ -35,7 +34,6 @@ 
 use OCP\IGroupManager;
 use OCP\Files\File;
 use OCP\Files\Folder;
-
 use OCP\Share\Exceptions\ShareNotFound;
 use OCP\Share\Exceptions\GenericShareException;
 

Doc Comments +1 added lines, -1 removed lines

@@ -224,7 +224,7 @@
 	 * Validate if the expiration date fits the system settings
 	 *
 	 * @param \OCP\Share\IShare $share The share to validate the expiration date of
-	 * @return \OCP\Share\IShare The expiration date or null if $expireDate was null and it is not required
+	 * @return \DateTime The expiration date or null if $expireDate was null and it is not required
 	 * @throws GenericShareException
 	 * @throws \InvalidArgumentException
 	 * @throws \Exception

apps/dav/lib/carddav/carddavbackend.php

Doc Comments +4 added lines

@@ -817,6 +817,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -922,6 +923,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/federatedfilesharing/lib/federatedshareprovider.php

Doc Comments +1 added lines, -1 removed lines

@@ -463,7 +463,7 @@
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */

apps/files_external/command/backends.php

Unused Use Statements -6 removed lines

@@ -22,18 +22,12 @@
 namespace OCA\Files_External\Command;
 
 use OC\Core\Command\Base;
-use OCA\Files_External\Lib\Auth\AuthMechanism;
 use OCA\Files_External\Lib\Backend\Backend;
 use OCA\Files_External\Lib\DefinitionParameter;
 use OCA\Files_External\Service\BackendService;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
-use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Backends extends Base {

apps/files_external/command/create.php

Unused Use Statements -4 removed lines

@@ -30,18 +30,14 @@
 use OCA\Files_external\Lib\StorageConfig;
 use OCA\Files_External\Service\BackendService;
 use OCA\Files_external\Service\GlobalStoragesService;
-use OCA\Files_external\Service\ImportLegacyStoragesService;
 use OCA\Files_external\Service\UserStoragesService;
 use OCP\IUserManager;
 use OCP\IUserSession;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Create extends Base {

apps/files_external/command/verify.php

Unused Use Statements -2 removed lines

@@ -28,8 +28,6 @@
 use OCP\IGroupManager;
 use OCP\IUserManager;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;

apps/dav/lib/connector/sabre/checksumlist.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 namespace OCA\DAV\Connector\Sabre;
 
 use Sabre\Xml\XmlSerializable;
-use Sabre\Xml\Element;
 use Sabre\Xml\Writer;
 
 /**

apps/dav/lib/migration/migratecalendars.php

Unused Use Statements -4 removed lines

@@ -5,10 +5,6 @@
 use OCA\DAV\CardDAV\AddressBook;
 use OCA\DAV\CardDAV\CardDavBackend;
 use Sabre\CardDAV\Plugin;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputArgument;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
 
 class MigrateAddressbooks {
 

lib/private/user/user.php

Doc Comments +5 added lines, -1 removed lines

@@ -332,7 +332,7 @@ 
 	/**
 	 * get the users email address
 	 *
-	 * @return string|null
+	 * @return string
 	 * @since 9.0.0
 	 */
 	public function getEMailAddress() {
@@ -417,6 +417,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter) {
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));