Completed
Pull Request — master (#23919)
by Roeland
08:49
created
apps/dav/lib/carddav/carddavbackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -187,7 +187,8 @@  discard block
 block discarded – undo
187 187
 	}
188 188
 
189 189
 	/**
190
-	 * @param $addressBookUri
190
+	 * @param string $addressBookUri
191
+	 * @param string $principal
191 192
 	 * @return array|null
192 193
 	 */
193 194
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -867,6 +868,7 @@  discard block
 block discarded – undo
867 868
 	 *   * readOnly - boolean
868 869
 	 *   * summary - Optional, a description for the share
869 870
 	 *
871
+	 * @param integer $addressBookId
870 872
 	 * @return array
871 873
 	 */
872 874
 	public function getShares($addressBookId) {
@@ -966,7 +968,7 @@  discard block
 block discarded – undo
966 968
 
967 969
 	/**
968 970
 	 * For shared address books the sharee is set in the ACL of the address book
969
-	 * @param $addressBookId
971
+	 * @param integer $addressBookId
970 972
 	 * @param $acl
971 973
 	 * @return array
972 974
 	 */
@@ -974,6 +976,9 @@  discard block
 block discarded – undo
974 976
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
975 977
 	}
976 978
 
979
+	/**
980
+	 * @param boolean $toV2
981
+	 */
977 982
 	private function convertPrincipal($principalUri, $toV2) {
978 983
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
979 984
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/files_sharing/lib/sharedstorage.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -262,6 +262,9 @@  discard block
 block discarded – undo
262 262
 		return $this->newShare->getTarget();
263 263
 	}
264 264
 
265
+	/**
266
+	 * @param string $path
267
+	 */
265 268
 	public function setMountPoint($path) {
266 269
 		$this->newShare->setTarget($path);
267 270
 	}
@@ -273,7 +276,7 @@  discard block
 block discarded – undo
273 276
 	/**
274 277
 	 * get share ID
275 278
 	 *
276
-	 * @return integer unique share ID
279
+	 * @return string unique share ID
277 280
 	 */
278 281
 	public function getShareId() {
279 282
 		return $this->newShare->getId();
Please login to merge, or discard this patch.