owncloud / core

lib/private/connector/sabre/file.php

Doc Comments +8 added lines, -2 removed lines

@@ -213,6 +213,9 @@ 
 		return '"' . $this->info->getEtag() . '"';
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function emitPreHooks($exists, $path = null) {
 		if (is_null($path)) {
 			$path = $this->path;
@@ -238,6 +241,9 @@ 
 		return $run;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function emitPostHooks($exists, $path = null) {
 		if (is_null($path)) {
 			$path = $this->path;
@@ -260,7 +266,7 @@ 
 	/**
 	 * Returns the data
 	 *
-	 * @return string|resource
+	 * @return resource
 	 * @throws Forbidden
 	 * @throws ServiceUnavailable
 	 */
@@ -314,7 +320,7 @@ 
 	 *
 	 * If null is returned, we'll assume application/octet-stream
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	public function getContentType() {
 		$mimeType = $this->info->getMimetype();

lib/private/connector/sabre/lockplugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	private $tree;
 
 	/**
-	 * @param \Sabre\DAV\Tree $tree tree
+	 * @param ObjectTree $tree tree
 	 */
 	public function __construct(Tree $tree) {
 		$this->tree = $tree;

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use Sabre\DAV\ServerPlugin;
 use Sabre\DAV\Tree;
 use Sabre\HTTP\RequestInterface;
-use Sabre\HTTP\ResponseInterface;
 
 class LockPlugin extends ServerPlugin {
 	/**

lib/private/connector/sabre/node.php

Doc Comments +2 added lines, -2 removed lines

@@ -184,7 +184,7 @@ 
 	/**
 	 * Returns the size of the node, in bytes
 	 *
-	 * @return int|float
+	 * @return integer
 	 */
 	public function getSize() {
 		return $this->info->getSize();
@@ -213,7 +213,7 @@ 
 	}
 
 	/**
-	 * @return string|null
+	 * @return string
 	 */
 	public function getDavPermissions() {
 		$p = '';

lib/private/connector/sabre/principal.php

Doc Comments +1 added lines, -1 removed lines

@@ -168,7 +168,7 @@
 	 * The principals should be passed as a list of uri's.
 	 *
 	 * @param string $principal
-	 * @param array $members
+	 * @param string[] $members
 	 * @throws \Sabre\DAV\Exception
 	 */
 	public function setGroupMemberSet($principal, array $members) {

lib/private/files/storage/wrapper/encryption.php

Doc Comments +2 added lines, -2 removed lines

@@ -190,7 +190,7 @@ 
 	 *
 	 * @param string $path
 	 * @param string $data
-	 * @return bool
+	 * @return integer
 	 */
 	public function file_put_contents($path, $data) {
 		// file put content will always be translated to a stream write
@@ -769,7 +769,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

lib/private/files/view.php

Doc Comments +5 added lines, -2 removed lines

@@ -189,7 +189,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -873,7 +873,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|string
+	 * @return string|false
 	 * @throws \OCP\Files\InvalidPathException
 	 */
 	public function toTmpFile($path) {
@@ -1593,6 +1593,9 @@ 
 		return null;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function assertPathLength($path) {
 		$maxLen = min(PHP_MAXPATHLEN, 4000);
 		// Check for the string length - performed using isset() instead of strlen()

lib/private/share/mailnotifications.php

Doc Comments +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
 	 * @param string $filename the shared file
 	 * @param string $link the public link
 	 * @param int $expiration expiration date (timestamp)
-	 * @return array $result of failed recipients
+	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMail($recipient, $filename, $link, $expiration) {
 		$subject = (string)$this->l->t('%s shared »%s« with you', [$this->senderDisplayName, $filename]);

lib/private/subadmin.php

Doc Comments +5 added lines

@@ -166,6 +166,11 @@
 	/*
 	 * alias for self::isSubAdminofGroup()
 	 */
+
+	/**
+	 * @param string $subadmin
+	 * @param string $group
+	 */
 	public static function isGroupAccessible($subadmin, $group) {
 		return self::isSubAdminofGroup($subadmin, $group);
 	}

tests/lib/connector/sabre/file.php

Doc Comments +4 added lines, -1 removed lines

@@ -40,6 +40,9 @@ 
 		parent::tearDown();
 	}
 
+	/**
+	 * @return \OC\Files\Storage\Storage
+	 */
 	private function getMockStorage() {
 		$storage = $this->getMock('\OCP\Files\Storage');
 		$storage->expects($this->any())
@@ -243,7 +246,7 @@ 
 	 * @param string $path path to put the file into
 	 * @param string $viewRoot root to use for the view
 	 *
-	 * @return result of the PUT operaiton which is usually the etag
+	 * @return string|null of the PUT operaiton which is usually the etag
 	 */
 	private function doPut($path, $viewRoot = null) {
 		$view = \OC\Files\Filesystem::getView();