Completed
Pull Request — master (#28854)
by Matthew
08:12
created
lib/public/Template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -248,6 +248,9 @@  discard block
 block discarded – undo
248 248
 		return '"' . $this->info->getEtag() . '"';
249 249
 	}
250 250
 
251
+	/**
252
+	 * @param string $path
253
+	 */
251 254
 	private function getPartFileBasePath($path) {
252 255
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
253 256
 		if ($partFileInStorage) {
@@ -617,7 +620,7 @@  discard block
 block discarded – undo
617 620
 	/**
618 621
 	 * Set $algo to get a specific checksum, leave null to get all checksums
619 622
 	 * (space seperated)
620
-	 * @param null $algo
623
+	 * @param string $algo
621 624
 	 * @return string
622 625
 	 */
623 626
 	public function getChecksum($algo = null) {
@@ -640,6 +643,9 @@  discard block
 block discarded – undo
640 643
 		return '';
641 644
 	}
642 645
 
646
+	/**
647
+	 * @param string $string
648
+	 */
643 649
 	protected function header($string) {
644 650
 		\header($string);
645 651
 	}
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -31,10 +31,8 @@
 block discarded – undo
31 31
 
32 32
 namespace OC\Settings;
33 33
 
34
-use OC\Files\View;
35 34
 use OC\Server;
36 35
 use OC\AppFramework\Utility\TimeFactory;
37
-use OC\Settings\Controller\CorsController;
38 36
 use OC\Settings\Controller\SettingsPageController;
39 37
 use OC\Settings\Controller\AppSettingsController;
40 38
 use OC\Settings\Controller\AuthSettingsController;
Please login to merge, or discard this patch.
settings/Controller/CorsController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,6 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Removes a WhiteListed Domain
133 133
 	 *
134
-	 * @param string $domain Domain to remove
135 134
 	 * @return RedirectResponse Redirection to the settings page.
136 135
 	 */
137 136
 	public function removeDomain($id) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CorsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * @param RequestInterface $request
89 89
 	 * @param ResponseInterface $response
90 90
 	 *
91
-	 * @return false
91
+	 * @return false|null
92 92
 	 */
93 93
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
94 94
 		$authorization = $request->getHeader('Authorization');
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Remote.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 namespace OCA\Files_Sharing\API;
25 25
 
26 26
 use OC\Files\Filesystem;
27
-use OCA\FederatedFileSharing\DiscoveryManager;
28 27
 use OCA\Files_Sharing\External\Manager;
29 28
 use Symfony\Component\EventDispatcher\GenericEvent;
30 29
 
Please login to merge, or discard this patch.
lib/private/AppFramework/Middleware/Security/CORSMiddleware.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 
28 28
 use OC\AppFramework\Middleware\Security\Exceptions\SecurityException;
29 29
 use OC\AppFramework\Utility\ControllerMethodReflector;
30
-use OC\Authentication\Exceptions\PasswordLoginForbiddenException;
31 30
 use OCP\AppFramework\Controller;
32 31
 use OCP\AppFramework\Http;
33 32
 use OCP\AppFramework\Http\JSONResponse;
Please login to merge, or discard this patch.