Completed
Pull Request — master (#29786)
by Matthew
14:11 queued 04:35
created
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
 
362 362
 	/**
363 363
 	 * @param string $version
364
-	 * @return mixed
364
+	 * @return \Doctrine\DBAL\Schema\Schema
365 365
 	 * @throws \Exception
366 366
 	 */
367 367
 	protected function createInstance($version) {
Please login to merge, or discard this patch.
lib/private/legacy/template.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -319,6 +319,7 @@
 block discarded – undo
319 319
 		* @param string $error_msg The error message to show
320 320
 		* @param string $hint An optional hint message - needs to be properly escaped
321 321
 		* @param int HTTP Status Code
322
+		* @param integer $httpStatusCode
322 323
 		*/
323 324
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
324 325
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPlugin.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 	 *
91 91
 	 * @param string $path source path
92 92
 	 * @param string $destination destination path
93
-	 * @return bool|void false to stop handling, void to skip this handler
93
+	 * @return null|false false to stop handling, void to skip this handler
94 94
 	 */
95 95
 	public function performMove($path, $destination) {
96 96
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OCA\DAV\Upload;
24 24
 
25 25
 
26
-use OCA\DAV\Connector\Sabre\File;
27 26
 use Sabre\DAV\Exception\BadRequest;
28 27
 use Sabre\DAV\Server;
29 28
 use Sabre\DAV\ServerPlugin;
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
 	 * Returns an associative array with all translations
172 172
 	 *
173 173
 	 * Called by String
174
-	 * @return array
174
+	 * @return string[]
175 175
 	 */
176 176
 	public function getTranslations() {
177 177
 		return $this->translations;
Please login to merge, or discard this patch.
lib/public/Template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 
32 32
 namespace OC\Settings;
33 33
 
34
-use OC\Files\View;
35 34
 use OC\Server;
36 35
 use OC\AppFramework\Utility\TimeFactory;
37 36
 use OC\Settings\Controller\CorsController;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -248,6 +248,9 @@  discard block
 block discarded – undo
248 248
 		return '"' . $this->info->getEtag() . '"';
249 249
 	}
250 250
 
251
+	/**
252
+	 * @param string $path
253
+	 */
251 254
 	private function getPartFileBasePath($path) {
252 255
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
253 256
 		if ($partFileInStorage) {
@@ -617,7 +620,7 @@  discard block
 block discarded – undo
617 620
 	/**
618 621
 	 * Set $algo to get a specific checksum, leave null to get all checksums
619 622
 	 * (space seperated)
620
-	 * @param null $algo
623
+	 * @param string $algo
621 624
 	 * @return string
622 625
 	 */
623 626
 	public function getChecksum($algo = null) {
@@ -640,6 +643,9 @@  discard block
 block discarded – undo
640 643
 		return '';
641 644
 	}
642 645
 
646
+	/**
647
+	 * @param string $string
648
+	 */
643 649
 	protected function header($string) {
644 650
 		\header($string);
645 651
 	}
Please login to merge, or discard this patch.
settings/Controller/CorsController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,6 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Removes a WhiteListed Domain
133 133
 	 *
134
-	 * @param string $domain Domain to remove
135 134
 	 * @return RedirectResponse Redirection to the settings page.
136 135
 	 */
137 136
 	public function removeDomain($id) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CorsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * @param RequestInterface $request
89 89
 	 * @param ResponseInterface $response
90 90
 	 *
91
-	 * @return false
91
+	 * @return false|null
92 92
 	 */
93 93
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
94 94
 		$authorization = $request->getHeader('Authorization');
Please login to merge, or discard this patch.