owncloud / core

lib/private/User/Session.php

Doc Comments +8 added lines, -2 removed lines

@@ -323,7 +323,7 @@ 
 	 * @throws \InvalidArgumentException
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -366,6 +366,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -988,6 +991,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		$shallLogout = false;
 		try {
@@ -1019,7 +1025,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/User/User.php

Unused Use Statements -1 removed lines

@@ -43,7 +43,6 @@
 use OCP\IUserBackend;
 use OCP\IUserSession;
 use OCP\User\IChangePasswordBackend;
-use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

Doc Comments +5 added lines, -1 removed lines

@@ -82,7 +82,7 @@ 
 	 *
 	 * @param Account $account
 	 * @param AccountMapper $mapper
-	 * @param null $emitter
+	 * @param Manager $emitter
 	 * @param IConfig|null $config
 	 * @param null $urlGenerator
 	 * @param EventDispatcher|null $eventDispatcher
@@ -473,6 +473,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter && \in_array($feature, $this->account->getUpdatedFields())) {
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 

core/Command/User/SyncBackend.php

Doc Comments +4 added lines, -4 removed lines

@@ -172,7 +172,7 @@ 
 	 * @param SyncService $syncService
 	 * @param UserInterface $backend
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncMultipleUsers (
 		InputInterface $input,
@@ -220,7 +220,7 @@ 
 	 * @param UserInterface $backend
 	 * @param string $uid
 	 * @param string $missingAccountsAction
-	 * @param array $validActions
+	 * @param string[] $validActions
 	 */
 	private function syncSingleUser(
 		InputInterface $input,
@@ -255,7 +255,7 @@ 
 	}
 
 	/**
-	 * @param array $uids a list of uids to the the action
+	 * @param string[] $uids a list of uids to the the action
 	 * @param callable $callbackExists the callback used if the account for the uid exists. The
 	 * uid and the specific account will be passed as parameter to the callback in that order
 	 * @param callable $callbackMissing the callback used if the account doesn't exists. The uid (not
@@ -276,7 +276,7 @@ 
 	 * @param string[] $unknownUsers
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @param $missingAccountsAction
+	 * @param string $missingAccountsAction
 	 * @param $validActions
 	 */
 	private function handleUnknownUsers(array $unknownUsers, InputInterface $input, OutputInterface $output, $missingAccountsAction, $validActions) {

lib/private/Notification/Manager.php

Doc Comments +2 added lines

@@ -113,6 +113,8 @@
 	 * INTERNAL USE ONLY!! This method isn't part of the IManager interface
 	 * @internal This should only be used by the RegisterNotifierEventImpl (the real implementation).
 	 * Do NOT use this method outside as it might not work as expected.
+	 * @param string $id
+	 * @param string $name
 	 */
 	public function registerBuiltNotifier(INotifier $notifier, $id, $name) {
 		if (!isset($this->builtNotifiersHolder[$id]) && !isset($this->notifiersInfo[$id])) {

settings/Controller/CorsController.php

Doc Comments -1 removed lines

@@ -134,7 +134,6 @@
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
 	 *
-	 * @param string $domain Domain to remove
 	 * @return RedirectResponse Redirection to the settings page.
 	 */
 	public function removeDomain($id) {

core/Middleware/TwoFactorMiddleware.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
 	}
 
 	/**
-	 * @param $controller
-	 * @param $methodName
+	 * @param Controller $controller
+	 * @param string $methodName
 	 * @throws TwoFactorAuthRequiredException
 	 * @throws UserAlreadyLoggedInException
 	 */

lib/private/legacy/response.php

Doc Comments +2 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
 	 * @param string $userId
 	 * @param string $domain
 	 * @param \OCP\IConfig $config
-	 * @param array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [
@@ -318,7 +318,7 @@ 
 	 * This function adds the CORS headers for all domains
 	 *
 	 * @param Sabre\HTTP\ResponseInterface $response
-	 * @param Array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [

settings/Application.php

Unused Use Statements -3 removed lines

@@ -39,11 +39,8 @@
 use OC\Settings\Controller\AuthSettingsController;
 use OC\Settings\Controller\CertificateController;
 use OC\Settings\Controller\CheckSetupController;
-use OC\Settings\Controller\GroupsController;
 use OC\Settings\Controller\LogSettingsController;
 use OC\Settings\Controller\MailSettingsController;
-use OC\Settings\Controller\UsersController;
-use OC\Settings\Middleware\SubadminMiddleware;
 use OCP\AppFramework\App;
 use OCP\IContainer;
 use OCP\Util;