owncloud / core

lib/private/Repair/Apps.php

Doc Comments +2 added lines, -1 removed lines

@@ -125,6 +125,7 @@ 
 	 *
 	 * @param IOutput $output
 	 * @param string[] $appList
+	 * @param string $event
 	 * @return array
 	 * @throws AppManagerException
 	 */
@@ -160,7 +161,7 @@ 
 	/**
 	 * Get app list separated as compatible/incompatible/missing
 	 *
-	 * @return array
+	 * @return IOutput
 	 */
 	protected function getAppsToUpgrade() {
 		$installedApps = $this->appManager->getInstalledApps();

apps/dav/lib/Connector/LegacyDAVACL.php

Doc Comments +4 added lines

@@ -49,6 +49,10 @@
 		);
 	}
 
+	/**
+	 * @param string $principal
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principal, $toV2) {
 		list(, $name) = URLUtil::splitPath($principal);
 		if ($toV2) {

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -267,6 +267,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1262,7 +1265,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1665,6 +1668,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/CardDAV/CardDavBackend.php

Doc Comments +8 added lines, -3 removed lines

@@ -214,7 +214,8 @@ 
 	}
 
 	/**
-	 * @param $addressBookUri
+	 * @param string $addressBookUri
+	 * @param string $principal
 	 * @return array|null
 	 */
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -896,6 +897,7 @@ 
 	 *   * readOnly - boolean
 	 *   * summary - Optional, a description for the share
 	 *
+	 * @param integer $addressBookId
 	 * @return array
 	 */
 	public function getShares($addressBookId) {
@@ -949,7 +951,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);
@@ -995,7 +997,7 @@ 
 
 	/**
 	 * For shared address books the sharee is set in the ACL of the address book
-	 * @param $addressBookId
+	 * @param integer $addressBookId
 	 * @param $acl
 	 * @return array
 	 */
@@ -1003,6 +1005,9 @@ 
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

core/Migrations/Version20170221114437.php

Unused Use Statements -2 removed lines

@@ -1,12 +1,10 @@
 <?php
 namespace OC\Migrations;
 
-use OC\User\Account;
 use OC\User\AccountMapper;
 use OC\User\AccountTermMapper;
 use OC\User\Database;
 use OC\User\SyncService;
-use OCP\IConfig;
 use OCP\Migration\ISimpleMigration;
 use OCP\Migration\IOutput;
 

lib/private/User/AccountMapper.php

Doc Comments +14 added lines, -3 removed lines

@@ -40,8 +40,8 @@ 
 
 	/**
 	 * Pass through call to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
-	 * @param array $terms
+	 * @param integer $account_id
+	 * @param string[] $terms
 	 */
 	public function setTermsForAccount($account_id, array $terms) {
 		$this->termMapper->setTermsForAccount($account_id, $terms);
@@ -49,7 +49,7 @@ 
 
 	/**
 	 * Pass through call to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @return AccountTerm[] $terms
 	 */
 	public function findByAccountId($account_id) {
@@ -158,6 +158,9 @@ 
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCountPerBackend($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -180,6 +183,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCount($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -196,6 +202,11 @@ 
 		return (int) $data['count'];
 	}
 
+	/**
+	 * @param \Closure $callback
+	 * @param string $search
+	 * @param boolean $onlySeen
+	 */
 	public function callForAllUsers($callback, $search, $onlySeen) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['*'])