Completed
Pull Request — master (#29381)
by Kai
08:07
created
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	/**
151 151
 	 * saves database schema to xml file
152 152
 	 * @param string $file name of file
153
-	 * @param int $mode
154 153
 	 * @return bool
155 154
 	 *
156 155
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
lib/private/Files/Config/LazyStorageMountInfo.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -21,10 +21,7 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\Files\Config;
23 23
 
24
-use OC\Files\Filesystem;
25
-use OCP\Files\Config\ICachedMountInfo;
26 24
 use OCP\Files\Mount\IMountPoint;
27
-use OCP\Files\Node;
28 25
 use OCP\IUser;
29 26
 
30 27
 class LazyStorageMountInfo extends CachedMountInfo {
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -241,6 +241,9 @@  discard block
 block discarded – undo
241 241
 		}
242 242
 	}
243 243
 
244
+	/**
245
+	 * @param string $name
246
+	 */
244 247
 	private function checkBlackList($name, $errorCode, Node $node) {
245 248
 		$lowerName = strtolower($name);
246 249
 
@@ -254,6 +257,9 @@  discard block
 block discarded – undo
254 257
 		}
255 258
 	}
256 259
 
260
+	/**
261
+	 * @param string $constantName
262
+	 */
257 263
 	private function checkBlackListConstant($class, $constantName, Node $node) {
258 264
 		$name = $class . '::' . $constantName;
259 265
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@  discard block
 block discarded – undo
268 274
 		}
269 275
 	}
270 276
 
277
+	/**
278
+	 * @param string $class
279
+	 */
271 280
 	private function checkBlackListFunction($class, $functionName, Node $node) {
272 281
 		$name = $class . '::' . $functionName;
273 282
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@  discard block
 block discarded – undo
282 291
 		}
283 292
 	}
284 293
 
294
+	/**
295
+	 * @param string $class
296
+	 */
285 297
 	private function checkBlackListMethod($class, $functionName, Node $node) {
286 298
 		$name = $class . '::' . $functionName;
287 299
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@  discard block
 block discarded – undo
296 308
 		}
297 309
 	}
298 310
 
311
+	/**
312
+	 * @param string $name
313
+	 */
299 314
 	private function buildReason($name, $errorCode) {
300 315
 		if (isset($this->errorMessages[$errorCode])) {
301 316
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/SMB.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -260,6 +260,9 @@  discard block
 block discarded – undo
260 260
 		return $this->leave(__FUNCTION__, $result);
261 261
 	}
262 262
 
263
+	/**
264
+	 * @param string $path
265
+	 */
263 266
 	private function removeFromCache($path) {
264 267
 		$path = trim($path, '/');
265 268
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@  discard block
 block discarded – undo
632 635
 	 * if wnd.logging.enable is set to true in the config will log a leave line
633 636
 	 * with the given function, the return value or the exception
634 637
 	 *
635
-	 * @param $function
638
+	 * @param string $function
636 639
 	 * @param mixed $result an exception will be logged and then returned
637 640
 	 * @return mixed
638 641
 	 */
@@ -659,6 +662,9 @@  discard block
 block discarded – undo
659 662
 		return $result;
660 663
 	}
661 664
 
665
+	/**
666
+	 * @param string $function
667
+	 */
662 668
 	private function swallow($function, \Exception $exception) {
663 669
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
664 670
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)
Please login to merge, or discard this patch.
core/Controller/OccController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
 
132 132
 	/**
133 133
 	 * Check if command is allowed and has a valid security token
134
-	 * @param $command
135
-	 * @param $token
134
+	 * @param string $command
135
+	 * @param string $token
136 136
 	 */
137 137
 	protected function validateRequest($command, $token){
138 138
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return null|ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return null|TagList
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/AddressBookImpl.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 * @param AddressBook $addressBook
52 52
 	 * @param array $addressBookInfo
53 53
 	 * @param CardDavBackend $backend
54
-	 * @param IUrlGenerator $urlGenerator
54
+	 * @param IURLGenerator $urlGenerator
55 55
 	 */
56 56
 	public function __construct(
57 57
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	}
135 135
 
136 136
 	/**
137
-	 * @return mixed
137
+	 * @return integer
138 138
 	 * @since 5.0.0
139 139
 	 */
140 140
 	public function getPermissions() {
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * read vCard data into a vCard object
173 173
 	 *
174 174
 	 * @param string $cardData
175
-	 * @return VCard
175
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
176 176
 	 */
177 177
 	protected function readCard($cardData) {
178 178
 		return  Reader::read($cardData);
Please login to merge, or discard this patch.
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.