Completed
Pull Request — master (#29381)
by Kai
08:07
created
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
 	 * @param array $groupSharesById
208 208
 	 * @param array $subShares
209 209
 	 *
210
-	 * @return true if the share is valid, false if it needs repair
210
+	 * @return boolean if the share is valid, false if it needs repair
211 211
 	 */
212 212
 	private function isThisShareValid($groupSharesById, $subShares) {
213 213
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/QuotaPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 		return true;
112 112
 	}
113 113
 
114
+	/**
115
+	 * @param string[] $info
116
+	 */
114 117
 	public function getFileChunking($info) {
115 118
 		// FIXME: need a factory for better mocking support
116 119
 		return new \OC_FileChunking($info);
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
 	 *
192 192
 	 * @param ISystemTag $tag
193 193
 	 *
194
-	 * @return SystemTagNode
194
+	 * @return SystemTagMappingNode
195 195
 	 */
196 196
 	private function makeNode(ISystemTag $tag) {
197 197
 		return new SystemTagMappingNode(
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use Sabre\DAV\Exception\BadRequest;
27 27
 use Sabre\DAV\Exception\PreconditionFailed;
28 28
 use Sabre\DAV\ICollection;
29
-
30 29
 use OCP\SystemTag\ISystemTagManager;
31 30
 use OCP\SystemTag\ISystemTagObjectMapper;
32 31
 use OCP\SystemTag\ISystemTag;
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/CodeChecker.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,8 +25,6 @@
 block discarded – undo
25 25
 
26 26
 use OC\Hooks\BasicEmitter;
27 27
 use PhpParser\Lexer;
28
-use PhpParser\Node;
29
-use PhpParser\Node\Name;
30 28
 use PhpParser\NodeTraverser;
31 29
 use PhpParser\Parser;
32 30
 use RecursiveCallbackFilterIterator;
Please login to merge, or discard this patch.
lib/private/Console/TimestampFormatter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 	 * Checks if output formatter has style with specified name.
72 72
 	 *
73 73
 	 * @param string $name
74
-	 * @return bool
74
+	 * @return boolean|null
75 75
 	 */
76 76
 	public function hasStyle($name) {
77 77
 		$this->formatter->hasStyle($name);
Please login to merge, or discard this patch.
lib/private/DB/Adapter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 
44 44
 	/**
45 45
 	 * @param string $table name
46
-	 * @return int id of last insert statement
46
+	 * @return string id of last insert statement
47 47
 	 */
48 48
 	public function lastInsertId($table) {
49 49
 		return $this->conn->realLastInsertId($table);
Please login to merge, or discard this patch.
lib/private/DB/Connection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@
 block discarded – undo
173 173
 	 * If an SQLLogger is configured, the execution is logged.
174 174
 	 *
175 175
 	 * @param string                                      $query  The SQL query to execute.
176
-	 * @param array                                       $params The parameters to bind to the query, if any.
176
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
177 177
 	 * @param array                                       $types  The types the previous parameters are in.
178 178
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
179 179
 	 *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -34,14 +34,12 @@
 block discarded – undo
34 34
 use Doctrine\DBAL\Cache\QueryCacheProfile;
35 35
 use Doctrine\Common\EventManager;
36 36
 use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
37
-use Doctrine\DBAL\Exception\ConstraintViolationException;
38 37
 use Doctrine\DBAL\Platforms\MySqlPlatform;
39 38
 use Doctrine\DBAL\Schema\Schema;
40 39
 use OC\DB\QueryBuilder\QueryBuilder;
41 40
 use OCP\DB\QueryBuilder\IQueryBuilder;
42 41
 use OCP\IDBConnection;
43 42
 use OCP\PreConditionNotMetException;
44
-use OCP\Util;
45 43
 
46 44
 class Connection extends \Doctrine\DBAL\Connection implements IDBConnection {
47 45
 	/**
Please login to merge, or discard this patch.
lib/private/legacy/db/statementwrapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@
 block discarded – undo
44 44
 
45 45
 	/**
46 46
 	 * @param boolean $isManipulation
47
+	 * @param Doctrine\DBAL\Driver\Statement $statement
47 48
 	 */
48 49
 	public function __construct($statement, $isManipulation) {
49 50
 		$this->statement = $statement;
Please login to merge, or discard this patch.
lib/private/Mail/Message.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	/**
110 110
 	 * Returns the Reply-To address of this message
111 111
 	 *
112
-	 * @return array
112
+	 * @return string
113 113
 	 */
114 114
 	public function getReplyTo() {
115 115
 		return $this->swiftMessage->getReplyTo();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 	/**
163 163
 	 * Set the BCC recipients of this message.
164 164
 	 *
165
-	 * @param array $recipients Example: array('[email protected]', '[email protected]' => 'A name')
165
+	 * @param string[] $recipients Example: array('[email protected]', '[email protected]' => 'A name')
166 166
 	 * @return $this
167 167
 	 */
168 168
 	public function setBcc(array $recipients) {
Please login to merge, or discard this patch.