Completed
Pull Request — master (#29381)
by Kai
08:07
created
lib/private/Memcache/Memcached.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 	 * Set a value in the cache if it's not already stored
159 159
 	 *
160 160
 	 * @param string $key
161
-	 * @param mixed $value
161
+	 * @param integer $value
162 162
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
163 163
 	 * @return bool
164 164
 	 * @throws \Exception
Please login to merge, or discard this patch.
lib/private/Security/CredentialsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 use OCP\Security\ICrypto;
25 25
 use OCP\IDBConnection;
26 26
 use OCP\Security\ICredentialsManager;
27
-use OCP\IConfig;
28 27
 
29 28
 /**
30 29
  * Store and retrieve credentials for external services
Please login to merge, or discard this patch.
lib/private/Server.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1166,7 +1166,7 @@
 block discarded – undo
1166 1166
 	 * Get the certificate manager for the user
1167 1167
 	 *
1168 1168
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
1169
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
1169
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
1170 1170
 	 */
1171 1171
 	public function getCertificateManager($userId = '') {
1172 1172
 		if ($userId === '') {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -46,8 +46,6 @@
 block discarded – undo
46 46
 use OC\AppFramework\Utility\TimeFactory;
47 47
 use OC\Command\AsyncBus;
48 48
 use OC\Diagnostics\EventLogger;
49
-use OC\Diagnostics\NullEventLogger;
50
-use OC\Diagnostics\NullQueryLogger;
51 49
 use OC\Diagnostics\QueryLogger;
52 50
 use OC\Files\Config\UserMountCache;
53 51
 use OC\Files\Config\UserMountCacheListener;
Please login to merge, or discard this patch.
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return array_search(strtolower($needle), array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return strtolower(call_user_func([$tag, $mem]));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/public/Files/StorageAuthException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageAuthException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/public/Files/StorageBadConfigException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * ExtStorageBadConfigException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/public/Files/StorageConnectionException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 	 * StorageConnectionException constructor.
31 31
 	 *
32 32
 	 * @param string $message
33
-	 * @param int $code
34 33
 	 * @param \Exception $previous
35 34
 	 * @since 9.0.0
36 35
 	 */
Please login to merge, or discard this patch.
lib/public/Migration/IOutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,18 +32,21 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param string $message
34 34
 	 * @since 9.1.0
35
+	 * @return void
35 36
 	 */
36 37
 	public function info($message);
37 38
 
38 39
 	/**
39 40
 	 * @param string $message
40 41
 	 * @since 9.1.0
42
+	 * @return void
41 43
 	 */
42 44
 	public function warning($message);
43 45
 
44 46
 	/**
45 47
 	 * @param int $max
46 48
 	 * @since 9.1.0
49
+	 * @return void
47 50
 	 */
48 51
 	public function startProgress($max = 0);
49 52
 
@@ -51,12 +54,13 @@  discard block
 block discarded – undo
51 54
 	 * @param int $step
52 55
 	 * @param string $description
53 56
 	 * @since 9.1.0
57
+	 * @return void
54 58
 	 */
55 59
 	public function advance($step = 1, $description = '');
56 60
 
57 61
 	/**
58
-	 * @param int $max
59 62
 	 * @since 9.1.0
63
+	 * @return void
60 64
 	 */
61 65
 	public function finishProgress();
62 66
 
Please login to merge, or discard this patch.
lib/private/legacy/app.php 2 patches
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -807,9 +807,6 @@
 block discarded – undo
807 807
 	/**
808 808
 	 * List all apps, this is used in apps.php
809 809
 	 *
810
-	 * @param bool $onlyLocal
811
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
812
-	 *                                in the app store?
813 810
 	 * @return array
814 811
 	 */
815 812
 	public static function listAllApps() {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 use OC\App\Platform;
50 50
 use OC\Installer;
51 51
 use OC\Repair;
52
-use OC\HintException;
53 52
 
54 53
 /**
55 54
  * This class manages the apps. It allows them to register and integrate in the
Please login to merge, or discard this patch.