Completed
Pull Request — master (#30106)
by Juan Pablo
32:44 queued 20:23
created
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			\hash_update($ctx, $data);
@@ -199,7 +202,7 @@  discard block
 block discarded – undo
199 202
 	}
200 203
 
201 204
 	/**
202
-	 * @return mixed
205
+	 * @return string
203 206
 	 * @return string
204 207
 	 */
205 208
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.
lib/private/Files/Stream/StaticStream.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -145,6 +145,9 @@
 block discarded – undo
145 145
 		return true;
146 146
 	}
147 147
 
148
+	/**
149
+	 * @param string $path
150
+	 */
148 151
 	public function url_stat($path) {
149 152
 		if (isset(self::$data[$path])) {
150 153
 			$size = \strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!\is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return \array_search(\strtolower($needle), \array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return \strtolower(\call_user_func([$tag, $mem]));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/private/Files/Utils/Scanner.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
 	/**
171 171
 	 * Returns whether the given mount point should be scanned
172 172
 	 *
173
-	 * @param $mount mount point
173
+	 * @param \OC\Files\Mount\MountPoint|null $mount mount point
174 174
 	 * @return bool true to scan, false to skip
175 175
 	 */
176 176
 	private function shouldScan($mount) {
Please login to merge, or discard this patch.
lib/private/Share/MailNotifications.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -189,10 +189,10 @@
 block discarded – undo
189 189
 	 * inform recipient about public link share
190 190
 	 *
191 191
 	 * @param string $recipient recipient email address
192
-	 * @param string $filename the shared file
193
-	 * @param string $link the public link
194 192
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
195
-	 * @param int $expiration expiration date (timestamp)
193
+	 * @param string $subject
194
+	 * @param boolean|string $htmlBody
195
+	 * @param boolean|string $textBody
196 196
 	 * @return string[] $result of failed recipients
197 197
 	 */
198 198
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {
Please login to merge, or discard this patch.
lib/public/Share/IShareProvider.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,6 +63,7 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @param \OCP\Share\IShare $share
65 65
 	 * @since 9.0.0
66
+	 * @return void
66 67
 	 */
67 68
 	public function delete(\OCP\Share\IShare $share);
68 69
 
@@ -74,6 +75,7 @@  discard block
 block discarded – undo
74 75
 	 * @param \OCP\Share\IShare $share
75 76
 	 * @param string $recipient UserId of the recipient
76 77
 	 * @since 9.0.0
78
+	 * @return void
77 79
 	 */
78 80
 	public function deleteFromSelf(\OCP\Share\IShare $share, $recipient);
79 81
 
@@ -181,6 +183,7 @@  discard block
 block discarded – undo
181 183
 	 * @param string $uid
182 184
 	 * @param int $shareType
183 185
 	 * @since 9.1.0
186
+	 * @return void
184 187
 	 */
185 188
 	public function userDeleted($uid, $shareType);
186 189
 
@@ -191,6 +194,7 @@  discard block
 block discarded – undo
191 194
 	 *
192 195
 	 * @param string $gid
193 196
 	 * @since 9.1.0
197
+	 * @return void
194 198
 	 */
195 199
 	public function groupDeleted($gid);
196 200
 
@@ -202,6 +206,7 @@  discard block
 block discarded – undo
202 206
 	 * @param string $uid
203 207
 	 * @param string $gid
204 208
 	 * @since 9.1.0
209
+	 * @return void
205 210
 	 */
206 211
 	public function userDeletedFromGroup($uid, $gid);
207 212
 
@@ -213,7 +218,6 @@  discard block
 block discarded – undo
213 218
 	 *
214 219
 	 * @param \OCP\Share\IShare $share
215 220
 	 * @param string $recipient userId of recipient
216
-	 * @param int $state state to set
217 221
 	 * @return \OCP\Share\IShare
218 222
 	 * @since 10.0.9
219 223
 	 */
Please login to merge, or discard this patch.