owncloud / core

lib/private/allconfig.php

Doc Comments +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
 	 * Looks up a system wide defined value
 	 *
 	 * @param string $key the key of the value, under which it was saved
-	 * @param mixed $default the default value to be returned if the value isn't set
+	 * @param string $default the default value to be returned if the value isn't set
 	 * @return mixed the value or $default
 	 */
 	public function getSystemValue($key, $default = '') {
@@ -264,7 +264,7 @@ 
 	 * @param string $userId the userId of the user that we want to store the value under
 	 * @param string $appName the appName that we stored the value under
 	 * @param string $key the key under which the value is being stored
-	 * @param mixed $default the default value to be returned if the value isn't set
+	 * @param null|string $default the default value to be returned if the value isn't set
 	 * @return string
 	 */
 	public function getUserValue($userId, $appName, $key, $default = '') {
@@ -381,7 +381,7 @@ 
 	 *
 	 * @param string $appName app to get the value for
 	 * @param string $key the key to get the value for
-	 * @param array $userIds the user IDs to fetch the values for
+	 * @param string[] $userIds the user IDs to fetch the values for
 	 * @return array Mapped values: userId => value
 	 */
 	public function getUserValueForUsers($appName, $key, $userIds) {

lib/private/api.php

Doc Comments +3 added lines, -2 removed lines

@@ -188,7 +188,7 @@ 
 	/**
 	 * merge the returned result objects into one response
 	 * @param array $responses
-	 * @return array|\OC_OCS_Result
+	 * @return OC_OCS_Result
 	 */
 	public static function mergeResponses($responses) {
 		// Sort into shipped and third-party
@@ -334,7 +334,7 @@ 
 
 	/**
 	 * http basic auth
-	 * @return string|false (username, or false on failure)
+	 * @return string (username, or false on failure)
 	 */
 	private static function loginUser() {
 		if(self::$isLoggedIn === true) {
@@ -440,6 +440,7 @@ 
 
 	/**
 	 * Based on the requested format the response content type is set
+	 * @param string $format
 	 */
 	public static function setContentType($format = null) {
 		$format = is_null($format) ? self::requestedFormat() : $format;

lib/private/app/dependencyanalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 	 * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1
 	 * @param string $first
 	 * @param string $second
-	 * @return array first element is the first version, second element is the
+	 * @return string[] first element is the first version, second element is the
 	 * second version
 	 */
 	private function normalizeVersions($first, $second) {

lib/private/app/platformrepository.php

Doc Comments +3 added lines

@@ -206,6 +206,9 @@
 		throw new \UnexpectedValueException('Invalid version string "' . $version . '"' . $extraMessage);
 	}
 
+	/**
+	 * @param string $stability
+	 */
 	private function expandStability($stability) {
 		$stability = strtolower($stability);
 		switch ($stability) {

lib/private/appframework/utility/simplecontainer.php

Doc Comments +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
 
 	/**
 	 * @param string $name
-	 * @param mixed $value
+	 * @param string $value
 	 */
 	public function registerParameter($name, $value) {
 		$this[$name] = $value;

Unused Use Statements -2 removed lines

@@ -29,9 +29,7 @@
 use ReflectionClass;
 use ReflectionException;
 use Closure;
-
 use Pimple\Container;
-
 use OCP\AppFramework\QueryException;
 use OCP\IContainer;
 

lib/private/db.php

Doc Comments +2 added lines, -3 removed lines

@@ -160,7 +160,7 @@ 
 	/**
 	 * gets last value of autoincrement
 	 * @param string $table The optional table name (will replace *PREFIX*) and add sequence suffix
-	 * @return string id
+	 * @return integer id
 	 * @throws \OC\DatabaseException
 	 *
 	 * \Doctrine\DBAL\Connection lastInsertId
@@ -196,7 +196,6 @@ 
 	/**
 	 * saves database schema to xml file
 	 * @param string $file name of file
-	 * @param int $mode
 	 * @return bool
 	 *
 	 * TODO: write more documentation
@@ -240,7 +239,7 @@ 
 	 * simulate the database schema update
 	 * @param string $file file to read structure from
 	 * @throws Exception
-	 * @return string|boolean
+	 * @return boolean
 	 */
 	public static function simulateUpdateDbFromStructure($file) {
 		$schemaManager = self::getMDB2SchemaManager();

lib/private/db/connection.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
 	 * If an SQLLogger is configured, the execution is logged.
 	 *
 	 * @param string                                      $query  The SQL query to execute.
-	 * @param array                                       $params The parameters to bind to the query, if any.
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
 	 * @param array                                       $types  The types the previous parameters are in.
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
 	 *
@@ -212,7 +212,7 @@ 
 	 * columns or sequences.
 	 *
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
-	 * @return string A string representation of the last inserted ID.
+	 * @return integer A string representation of the last inserted ID.
 	 */
 	public function lastInsertId($seqName = null)
 	{

lib/private/db/mdb2schemamanager.php

Doc Comments +1 added lines, -2 removed lines

@@ -49,7 +49,6 @@ 
 	/**
 	 * saves database scheme to xml file
 	 * @param string $file name of file
-	 * @param int|string $mode
 	 * @return bool
 	 *
 	 * TODO: write more documentation
@@ -123,7 +122,7 @@ 
 	/**
 	 * update the database scheme
 	 * @param string $file file to read structure from
-	 * @return string|boolean
+	 * @return boolean
 	 */
 	public function simulateUpdateDbFromStructure($file) {
 		$toSchema = $this->readSchemaFromFile($file);

lib/private/db/migrator.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 	protected $config;
 
 	/**
-	 * @param \Doctrine\DBAL\Connection $connection
+	 * @param Connection $connection
 	 * @param ISecureRandom $random
 	 * @param IConfig $config
 	 */