owncloud / core

apps/federatedfilesharing/lib/FederatedShareProvider.php

Doc Comments +8 added lines, -8 removed lines

@@ -394,7 +394,7 @@ 
 	/**
 	 * store remote ID in federated reShare table
 	 *
-	 * @param $shareId
+	 * @param integer $shareId
 	 * @param $remoteId
 	 */
 	public function storeRemoteId($shareId, $remoteId) {
@@ -801,7 +801,7 @@ 
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return array
 	 * @throws ShareNotFound
 	 */
@@ -1001,12 +1001,12 @@ 
 	}
 
 	/**
-	 * @param $remote
-	 * @param $token
-	 * @param $name
-	 * @param $owner
-	 * @param $shareWith
-	 * @param $remoteId
+	 * @param string $remote
+	 * @param string $token
+	 * @param string $name
+	 * @param string $owner
+	 * @param string $shareWith
+	 * @param integer $remoteId
 	 *
 	 * @return int
 	 */

lib/private/Lock/Persistent/Lock.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 	/**
 	 * Unix timestamp when lock was created
 	 *
-	 * @return mixed
+	 * @return integer
 	 * @since 11.0.0
 	 */
 	public function getCreatedAt(): int {

core/Controller/LostController.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */
@@ -281,7 +281,7 @@ 
 
 	/**
 	 * @param string $userId
-	 * @return array
+	 * @return string[]
 	 */
 	public function generateTokenAndLink($userId) {
 		$token = $this->secureRandom->generate(21,

lib/public/Util.php

Doc Comments +1 added lines, -1 removed lines

@@ -657,7 +657,7 @@
 	/**
 	 * Determine if the string is, strictly-speaking, empty or not
 	 *
-	 * @param $value
+	 * @param string $value
 	 * @return bool
 	 * @since 10.0.1
 	 */

core/Command/Db/Migrations/GenerateCommand.php

Doc Comments +3 added lines

@@ -146,6 +146,9 @@
 		return $path;
 	}
 
+	/**
+	 * @param string $kind
+	 */
 	private function getTemplate($kind) {
 		if ($kind === 'simple') {
 			return self::$_templateSimple;

core/Command/Encryption/ChangeKeyStorageRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
 	/**
 	 * check if target already exists
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 * @throws \Exception
 	 */

core/Command/User/ResetPassword.php

Unused Use Statements -5 removed lines

@@ -32,12 +32,7 @@
 use OC\Helper\EnvironmentHelper;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\IConfig;
-use OCP\IL10N;
-use OCP\IURLGenerator;
 use OCP\IUserManager;
-use OCP\Mail\IMailer;
-use OCP\Security\ISecureRandom;
-use OCP\Util;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputArgument;

apps/files_sharing/lib/Controller/Share20OcsController.php

Doc Comments +3 added lines, -2 removed lines

@@ -515,7 +515,7 @@ 
 	/**
 	 * @param \OCP\Files\File|\OCP\Files\Folder $node
 	 * @param boolean $includeTags include tags in response
-	 * @param int|null $stateFilter state filter or empty for all, defaults to 0 (accepted)
+	 * @param integer $stateFilter state filter or empty for all, defaults to 0 (accepted)
 	 * @return Result
 	 */
 	private function getSharedWithMe($node = null, $includeTags, $stateFilter = 0) {
@@ -968,7 +968,7 @@ 
 	}
 
 	/**
-	 * @param $id
+	 * @param integer $id
 	 * @param $state
 	 * @return Result
 	 */
@@ -1154,6 +1154,7 @@ 
 	 * not support this we need to check all backends.
 	 *
 	 * @param string $id
+	 * @param string $recipient
 	 * @return IShare
 	 * @throws ShareNotFound
 	 */

lib/private/Share/MailNotifications.php

Doc Comments +4 added lines, -4 removed lines

@@ -129,7 +129,7 @@ 
 	/**
 	 * inform users if a file was shared with them
 	 *
-	 * @param Node shared node
+	 * @param Node Node node
 	 * @param string $shareType share type
 	 * @param IUser[] $recipientList list of recipients
 	 *
@@ -238,10 +238,10 @@ 
 	 * inform recipient about public link share
 	 *
 	 * @param string $recipient recipient email address
-	 * @param string $filename the shared file
-	 * @param string $link the public link
 	 * @param array $options allows ['to], ['cc'] and ['bcc'] recipients
-	 * @param int $expiration expiration date (timestamp)
+	 * @param string $subject
+	 * @param boolean|string $htmlBody
+	 * @param boolean|string $textBody
 	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {