owncloud / core

lib/private/User/Session.php

Doc Comments +9 added lines, -3 removed lines

@@ -304,7 +304,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -347,6 +347,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -790,7 +793,7 @@ 
 	/**
 	 * logout the user from the session
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function logout() {
 
@@ -871,6 +874,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		foreach ($this->getAuthModules(true) as $module) {
 			$user = $module->auth($request);
@@ -890,7 +896,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +4 added lines, -4 removed lines

@@ -672,7 +672,7 @@ 
 	 * Set the flag to true, so that the file would be
 	 * in the decrypted state.
 	 *
-	 * @param $isDisabled bool
+	 * @param boolean $isDisabled bool
 	 */
 	public static function setDisableWriteEncryption($isDisabled) {
 		self::$disableWriteEncryption = $isDisabled;
@@ -929,7 +929,7 @@ 
 	/**
 	 * return header size of given file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return int
 	 */
 	protected function getHeaderSize($path) {
@@ -980,7 +980,7 @@ 
 	/**
 	 * read header from file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return array
 	 */
 	protected function getHeader($path) {
@@ -1076,7 +1076,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

lib/private/AllConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * In some environments the system config file is readonly. Find out if this
 	 * is the case.
 	 *
-	 * @return boolean
+	 * @return false|string
 	 * @since 10.0.3
 	 */
 	public function isSystemConfigReadOnly() {

lib/private/DB/MySqlSchemaColumnDefinitionListener.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 namespace OC\DB;
 
 use Doctrine\DBAL\DBALException;
-use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
 use Doctrine\DBAL\Event\SchemaColumnDefinitionEventArgs;
 use Doctrine\DBAL\Platforms\MySqlPlatform;
 use Doctrine\DBAL\Schema\Column;

lib/private/Files/Storage/Common.php

Doc Comments +1 added lines, -1 removed lines

@@ -699,7 +699,7 @@
 	}
 
 	/**
-	 * @param $internalPath
+	 * @param string $internalPath
 	 * @return array
 	 */
 	private function convertInternalPathToGlobalPath($internalPath) {

apps/files_versions/lib/Storage.php

Doc Comments +3 added lines

@@ -310,6 +310,9 @@
 	}
 
 
+	/**
+	 * @param string $revision
+	 */
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
 		if(\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
 			return false;

lib/private/App/AppManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -122,7 +122,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppManagerException
 	 */
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

core/Command/App/Enable.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace OC\Core\Command\App;
 
 use OCP\App\IAppManager;
-use OCP\ILogger;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;