owncloud / core

core/Application.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OC\Core\Controller\AvatarController;
 use OC\Core\Controller\LoginController;
 use OC\Core\Controller\LostController;
-use OC\Core\Controller\OccController;
 use OC\Core\Controller\TokenController;
 use OC\Core\Controller\TwoFactorChallengeController;
 use OC\Core\Controller\UserController;

apps/files_sharing/lib/Controller/ShareesController.php

Doc Comments +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -164,6 +164,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return hash_equals($storedToken, $token);

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -262,6 +262,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1254,7 +1257,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
 
@@ -1657,6 +1660,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

Doc Comments +4 added lines, -3 removed lines

@@ -104,7 +104,7 @@ 
 	 * @param ITagManager $fileTagger manager for private tags
 	 * @param IUserSession $userSession
 	 * @param IGroupManager $groupManager
-	 * @param Folder $userfolder
+	 * @param Folder $userFolder
 	 */
 	public function __construct(Tree $tree,
 								View $view,
@@ -150,7 +150,7 @@ 
 	 * This will be used in the {DAV:}supported-report-set property.
 	 *
 	 * @param string $uri
-	 * @return array
+	 * @return string[]
 	 */
 	public function getSupportedReportSet($uri) {
 		return [self::REPORT_NAME];
@@ -162,7 +162,7 @@ 
 	 * @param string $reportName
 	 * @param [] $report
 	 * @param string $uri
-	 * @return bool
+	 * @return null|false
 	 * @throws NotFound
 	 * @throws ReportNotSupported
 	 */
@@ -335,6 +335,7 @@ 
 	 * with a leading slash but no trailing slash
 	 * @param string[] $requestedProps requested properties
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
+	 * @param Node[] $nodes
 	 * @return Response[]
 	 */
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {

lib/private/User/Manager.php

Doc Comments -1 removed lines

@@ -379,7 +379,6 @@
 
 	/**
 	 * @param \Closure $callback
-	 * @param string $search
 	 * @since 9.0.0
 	 */
 	public function callForSeenUsers (\Closure $callback) {

lib/public/IUserManager.php

Doc Comments +6 added lines, -2 removed lines

@@ -45,6 +45,7 @@ 
 	 *
 	 * @param \OCP\UserInterface $backend
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function registerBackend($backend);
 
@@ -60,12 +61,14 @@ 
 	 *
 	 * @param \OCP\UserInterface $backend
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function removeBackend($backend);
 
 	/**
 	 * remove all user backends
 	 * @since 8.0.0
+	 * @return void
 	 */
 	public function clearBackends() ;
 
@@ -131,7 +134,7 @@ 
 	/**
 	 * returns how many users per backend exist (if supported by backend)
 	 *
-	 * @return array an array of backend class as key and count number as value
+	 * @return integer an array of backend class as key and count number as value
 	 * @since 8.0.0
 	 */
 	public function countUsers();
@@ -140,6 +143,7 @@ 
 	 * @param \Closure $callback
 	 * @param string $search
 	 * @since 9.0.0
+	 * @return void
 	 */
 	public function callForAllUsers (\Closure $callback, $search = '');
 
@@ -153,8 +157,8 @@ 
 
 	/**
 	 * @param \Closure $callback
-	 * @param string $search
 	 * @since 9.2.0
+	 * @return void
 	 */
 	public function callForSeenUsers (\Closure $callback);
 

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
 		return explode('/', $avatar);

lib/private/legacy/app.php

Doc Comments +3 added lines, -3 removed lines

@@ -164,7 +164,7 @@ 
 
 	/**
 	 * Enables the app as a theme if it has the type "theme"
-	 * @param $app
+	 * @param string $app
 	 */
 	private static function enableTheme($app) {
 		if (self::isType($app, 'theme')) {
@@ -1365,8 +1365,8 @@ 
 	}
 
 	/**
-	 * @param $config
-	 * @param $l
+	 * @param OCP\IConfig $config
+	 * @param OCP\IL10N $l
 	 * @param $info
 	 * @throws Exception
 	 */