Completed
Pull Request — master (#28122)
by Tom
19:46 queued 09:28
created
lib/public/Migration/IOutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,18 +32,21 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param string $message
34 34
 	 * @since 9.1.0
35
+	 * @return void
35 36
 	 */
36 37
 	public function info($message);
37 38
 
38 39
 	/**
39 40
 	 * @param string $message
40 41
 	 * @since 9.1.0
42
+	 * @return void
41 43
 	 */
42 44
 	public function warning($message);
43 45
 
44 46
 	/**
45 47
 	 * @param int $max
46 48
 	 * @since 9.1.0
49
+	 * @return void
47 50
 	 */
48 51
 	public function startProgress($max = 0);
49 52
 
@@ -51,12 +54,13 @@  discard block
 block discarded – undo
51 54
 	 * @param int $step
52 55
 	 * @param string $description
53 56
 	 * @since 9.1.0
57
+	 * @return void
54 58
 	 */
55 59
 	public function advance($step = 1, $description = '');
56 60
 
57 61
 	/**
58
-	 * @param int $max
59 62
 	 * @since 9.1.0
63
+	 * @return void
60 64
 	 */
61 65
 	public function finishProgress();
62 66
 
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -213,6 +213,10 @@  discard block
 block discarded – undo
213 213
 
214 214
 	/**
215 215
 	 *
216
+	 * @param string $user
217
+	 * @param string $targetFilename
218
+	 * @param string $targetLocation
219
+	 * @param integer $timestamp
216 220
 	 */
217 221
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
218 222
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -756,7 +760,7 @@  discard block
 block discarded – undo
756 760
 	 * if the size limit for the trash bin is reached, we delete the oldest
757 761
 	 * files in the trash bin until we meet the limit again
758 762
 	 *
759
-	 * @param array $files
763
+	 * @param \OCP\Files\FileInfo[] $files
760 764
 	 * @param string $user
761 765
 	 * @param int $availableSpace available disc space
762 766
 	 * @return int size of deleted files
@@ -784,7 +788,7 @@  discard block
 block discarded – undo
784 788
 	/**
785 789
 	 * delete files older then max storage time
786 790
 	 *
787
-	 * @param array $files list of files sorted by mtime
791
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
788 792
 	 * @param string $user
789 793
 	 * @return integer[] size of deleted files and number of deleted files
790 794
 	 */
Please login to merge, or discard this patch.
lib/private/legacy/app.php 2 patches
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -807,9 +807,6 @@
 block discarded – undo
807 807
 	/**
808 808
 	 * List all apps, this is used in apps.php
809 809
 	 *
810
-	 * @param bool $onlyLocal
811
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
812
-	 *                                in the app store?
813 810
 	 * @return array
814 811
 	 */
815 812
 	public static function listAllApps() {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 use OC\App\Platform;
50 50
 use OC\Installer;
51 51
 use OC\Repair;
52
-use OC\HintException;
53 52
 
54 53
 /**
55 54
  * This class manages the apps. It allows them to register and integrate in the
Please login to merge, or discard this patch.
lib/private/AppFramework/Http/Request.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 
449 449
 	/**
450 450
 	 * Checks if the CSRF check was correct
451
-	 * @return bool true if CSRF check passed
451
+	 * @return boolean|null true if CSRF check passed
452 452
 	 */
453 453
 	public function passesCSRFCheck() {
454 454
 		if($this->csrfTokenManager === null) {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 namespace OCA\DAV\CalDAV\Publishing\Xml;
22 22
 
23
-use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin;
24 23
 use Sabre\Xml\Writer;
25 24
 use Sabre\Xml\XmlSerializable;
26 25
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return '"' . $this->info->getEtag() . '"';
237 237
 	}
238 238
 
239
+	/**
240
+	 * @param string $path
241
+	 */
239 242
 	private function getPartFileBasePath($path) {
240 243
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
241 244
 		if ($partFileInStorage) {
@@ -598,7 +601,7 @@  discard block
 block discarded – undo
598 601
 	/**
599 602
 	 * Set $algo to get a specific checksum, leave null to get all checksums
600 603
 	 * (space seperated)
601
-	 * @param null $algo
604
+	 * @param string $algo
602 605
 	 * @return string
603 606
 	 */
604 607
 	public function getChecksum($algo = null) {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Files/Storage/Home.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 	 * get the owner of a path
100 100
 	 *
101 101
 	 * @param string $path The path to get the owner
102
-	 * @return string uid or false
102
+	 * @return integer uid or false
103 103
 	 */
104 104
 	public function getOwner($path) {
105 105
 		return $this->user->getUID();
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 *
72 72
 	 * @param Account $account
73 73
 	 * @param AccountMapper $mapper
74
-	 * @param null $emitter
74
+	 * @param Manager $emitter
75 75
 	 * @param IConfig|null $config
76 76
 	 * @param null $urlGenerator
77 77
 	 * @param EventDispatcher|null $eventDispatcher
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	/**
97 97
 	 * get the user id
98 98
 	 *
99
-	 * @return string
99
+	 * @return integer
100 100
 	 */
101 101
 	public function getUID() {
102 102
 		return $this->account->getUserId();
@@ -413,6 +413,10 @@  discard block
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.