@@ -274,7 +274,7 @@ discard block |
||
| 274 | 274 | * @param string $userId |
| 275 | 275 | * @param string $domain |
| 276 | 276 | * @param \OCP\IConfig $config |
| 277 | - * @param array $headers |
|
| 277 | + * @param string[] $headers |
|
| 278 | 278 | * |
| 279 | 279 | * Format of $headers: |
| 280 | 280 | * Array [ |
@@ -318,7 +318,7 @@ discard block |
||
| 318 | 318 | * This function adds the CORS headers for all domains |
| 319 | 319 | * |
| 320 | 320 | * @param Sabre\HTTP\ResponseInterface $response |
| 321 | - * @param Array $headers |
|
| 321 | + * @param string[] $headers |
|
| 322 | 322 | * |
| 323 | 323 | * Format of $headers: |
| 324 | 324 | * Array [ |
@@ -173,7 +173,7 @@ discard block |
||
| 173 | 173 | |
| 174 | 174 | /** |
| 175 | 175 | * @param Node $node |
| 176 | - * @param $correctChecksum |
|
| 176 | + * @param string $correctChecksum |
|
| 177 | 177 | * @throws NotFoundException |
| 178 | 178 | * @throws \OCP\Files\InvalidPathException |
| 179 | 179 | * @throws \OCP\Files\StorageNotAvailableException |
@@ -188,7 +188,7 @@ discard block |
||
| 188 | 188 | } |
| 189 | 189 | |
| 190 | 190 | /** |
| 191 | - * @param $path |
|
| 191 | + * @param string $path |
|
| 192 | 192 | * @param IStorage $storage |
| 193 | 193 | * @return string |
| 194 | 194 | * @throws \OCP\Files\StorageNotAvailableException |
@@ -73,6 +73,11 @@ |
||
| 73 | 73 | return self::writeExtra($app, $message, $level, $conditionalLogFile, []); |
| 74 | 74 | } |
| 75 | 75 | |
| 76 | + /** |
|
| 77 | + * @param string $app |
|
| 78 | + * @param string $message |
|
| 79 | + * @param integer $level |
|
| 80 | + */ |
|
| 76 | 81 | public static function writeExtra($app, $message, $level, $conditionalLogFile, $extraFields = []) { |
| 77 | 82 | $config = \OC::$server->getSystemConfig(); |
| 78 | 83 | |
@@ -172,6 +172,10 @@ |
||
| 172 | 172 | 'data' => ['sharedSecret' => $sharedSecret]]; |
| 173 | 173 | } |
| 174 | 174 | |
| 175 | + /** |
|
| 176 | + * @param string $url |
|
| 177 | + * @param string $token |
|
| 178 | + */ |
|
| 175 | 179 | protected function isValidToken($url, $token) { |
| 176 | 180 | $storedToken = $this->dbHandler->getToken($url); |
| 177 | 181 | return \hash_equals($storedToken, $token); |
@@ -284,6 +284,9 @@ discard block |
||
| 284 | 284 | return $this->leave(__FUNCTION__, $result); |
| 285 | 285 | } |
| 286 | 286 | |
| 287 | + /** |
|
| 288 | + * @param string $path |
|
| 289 | + */ |
|
| 287 | 290 | private function removeFromCache($path) { |
| 288 | 291 | $path = \trim($path, '/'); |
| 289 | 292 | // TODO The CappedCache does not really clear by prefix. It just clears all. |
@@ -673,7 +676,7 @@ discard block |
||
| 673 | 676 | * if smb.logging.enable is set to true in the config will log a leave line |
| 674 | 677 | * with the given function, the return value or the exception |
| 675 | 678 | * |
| 676 | - * @param $function |
|
| 679 | + * @param string $function |
|
| 677 | 680 | * @param mixed $result an exception will be logged and then returned |
| 678 | 681 | * @return mixed |
| 679 | 682 | */ |
@@ -700,6 +703,9 @@ discard block |
||
| 700 | 703 | return $result; |
| 701 | 704 | } |
| 702 | 705 | |
| 706 | + /** |
|
| 707 | + * @param string $function |
|
| 708 | + */ |
|
| 703 | 709 | private function swallow($function, \Exception $exception) { |
| 704 | 710 | if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) { |
| 705 | 711 | Util::writeLog('smb', "$function swallowing ".\get_class($exception) |
@@ -443,7 +443,7 @@ discard block |
||
| 443 | 443 | * split user and remote from federated cloud id |
| 444 | 444 | * |
| 445 | 445 | * @param string $address federated share address |
| 446 | - * @return array [user, remoteURL] |
|
| 446 | + * @return string[] [user, remoteURL] |
|
| 447 | 447 | * @throws \Exception |
| 448 | 448 | */ |
| 449 | 449 | public function splitUserRemote($address) { |
@@ -658,7 +658,7 @@ discard block |
||
| 658 | 658 | * trusted domain entries |
| 659 | 659 | * |
| 660 | 660 | * @param string $target target |
| 661 | - * @return true if one match was found, false otherwise |
|
| 661 | + * @return boolean if one match was found, false otherwise |
|
| 662 | 662 | */ |
| 663 | 663 | protected function isInstanceDomain($target) { |
| 664 | 664 | if (\strpos($target, '/') !== false) { |
@@ -109,7 +109,7 @@ discard block |
||
| 109 | 109 | * |
| 110 | 110 | * @param string $newPath |
| 111 | 111 | * @param \OCP\Share\IShare $share |
| 112 | - * @return bool |
|
| 112 | + * @return boolean|null |
|
| 113 | 113 | */ |
| 114 | 114 | private function updateFileTarget($newPath, &$share) { |
| 115 | 115 | $share->setTarget($newPath); |
@@ -125,7 +125,7 @@ discard block |
||
| 125 | 125 | * @param string $path |
| 126 | 126 | * @param View $view |
| 127 | 127 | * @param SharedMount[] $mountpoints |
| 128 | - * @return mixed |
|
| 128 | + * @return string |
|
| 129 | 129 | */ |
| 130 | 130 | private function generateUniqueTarget($path, $view, array $mountpoints) { |
| 131 | 131 | $pathinfo = \pathinfo($path); |
@@ -121,6 +121,9 @@ |
||
| 121 | 121 | } |
| 122 | 122 | } |
| 123 | 123 | |
| 124 | + /** |
|
| 125 | + * @param integer $name |
|
| 126 | + */ |
|
| 124 | 127 | private function buildController($name) { |
| 125 | 128 | $parts = \explode('.', $name); |
| 126 | 129 | if (\count($parts) === 4 && $parts[0] === 'ocs') { |
@@ -132,7 +132,7 @@ discard block |
||
| 132 | 132 | /** |
| 133 | 133 | * List all installed apps |
| 134 | 134 | * |
| 135 | - * @return string[] |
|
| 135 | + * @return integer[] |
|
| 136 | 136 | */ |
| 137 | 137 | public function getInstalledApps() { |
| 138 | 138 | return \array_keys($this->getInstalledAppsValues()); |
@@ -241,7 +241,7 @@ discard block |
||
| 241 | 241 | /** |
| 242 | 242 | * Do not allow more than one active app-theme |
| 243 | 243 | * |
| 244 | - * @param $appId |
|
| 244 | + * @param string $appId |
|
| 245 | 245 | * @throws AppManagerException |
| 246 | 246 | */ |
| 247 | 247 | protected function canEnableTheme($appId) { |
@@ -400,6 +400,9 @@ discard block |
||
| 400 | 400 | return \in_array($appId, $this->shippedApps); |
| 401 | 401 | } |
| 402 | 402 | |
| 403 | + /** |
|
| 404 | + * @param string $appId |
|
| 405 | + */ |
|
| 403 | 406 | private function isAlwaysEnabled($appId) { |
| 404 | 407 | $alwaysEnabled = $this->getAlwaysEnabledApps(); |
| 405 | 408 | return \in_array($appId, $alwaysEnabled); |
@@ -428,7 +431,7 @@ discard block |
||
| 428 | 431 | /** |
| 429 | 432 | * @param string $package package path |
| 430 | 433 | * @param bool $skipMigrations whether to skip migrations, which would only install the code |
| 431 | - * @return string|false app id or false in case of error |
|
| 434 | + * @return integer app id or false in case of error |
|
| 432 | 435 | * @since 10.0 |
| 433 | 436 | */ |
| 434 | 437 | public function installApp($package, $skipMigrations = false) { |
@@ -441,7 +444,7 @@ discard block |
||
| 441 | 444 | |
| 442 | 445 | /** |
| 443 | 446 | * @param string $package |
| 444 | - * @return mixed |
|
| 447 | + * @return boolean |
|
| 445 | 448 | * @since 10.0 |
| 446 | 449 | */ |
| 447 | 450 | public function updateApp($package) { |