Completed
Pull Request — master (#31988)
by Jörn Friedrich
16:09 queued 04:45
created
lib/public/Files.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
 	/**
68 68
 	 * Search for files by mimetype
69 69
 	 * @param string $mimetype
70
-	 * @return array
70
+	 * @return \OC\Files\FileInfo[]
71 71
 	 * @since 6.0.0
72 72
 	 */
73 73
 	public static function searchByMime($mimetype) {
Please login to merge, or discard this patch.
lib/public/Migration/IOutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,18 +32,21 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param string $message
34 34
 	 * @since 9.1.0
35
+	 * @return void
35 36
 	 */
36 37
 	public function info($message);
37 38
 
38 39
 	/**
39 40
 	 * @param string $message
40 41
 	 * @since 9.1.0
42
+	 * @return void
41 43
 	 */
42 44
 	public function warning($message);
43 45
 
44 46
 	/**
45 47
 	 * @param int $max
46 48
 	 * @since 9.1.0
49
+	 * @return void
47 50
 	 */
48 51
 	public function startProgress($max = 0);
49 52
 
@@ -51,12 +54,13 @@  discard block
 block discarded – undo
51 54
 	 * @param int $step
52 55
 	 * @param string $description
53 56
 	 * @since 9.1.0
57
+	 * @return void
54 58
 	 */
55 59
 	public function advance($step = 1, $description = '');
56 60
 
57 61
 	/**
58
-	 * @param int $max
59 62
 	 * @since 9.1.0
63
+	 * @return void
60 64
 	 */
61 65
 	public function finishProgress();
62 66
 }
Please login to merge, or discard this patch.
settings/ChangePassword/Controller.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@
 block discarded – undo
67 67
 		}
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param string|boolean $username
72
+	 */
70 73
 	private static function sendNotificationMail($username) {
71 74
 		$userObject = \OC::$server->getUserManager()->get($username);
72 75
 		$email = $userObject->getEMailAddress();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,12 +39,9 @@
 block discarded – undo
39 39
 use OC\Settings\Controller\AuthSettingsController;
40 40
 use OC\Settings\Controller\CertificateController;
41 41
 use OC\Settings\Controller\CheckSetupController;
42
-use OC\Settings\Controller\GroupsController;
43 42
 use OC\Settings\Controller\LegalSettingsController;
44 43
 use OC\Settings\Controller\LogSettingsController;
45 44
 use OC\Settings\Controller\MailSettingsController;
46
-use OC\Settings\Controller\UsersController;
47
-use OC\Settings\Middleware\SubadminMiddleware;
48 45
 use OCP\AppFramework\App;
49 46
 use OCP\IContainer;
50 47
 use OCP\Util;
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Share20OCS.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
 	/**
512 512
 	 * @param \OCP\Files\File|\OCP\Files\Folder $node
513 513
 	 * @param boolean $includeTags include tags in response
514
-	 * @param int|null $stateFilter state filter or empty for all, defaults to 0 (accepted)
514
+	 * @param integer $stateFilter state filter or empty for all, defaults to 0 (accepted)
515 515
 	 * @return \OC\OCS\Result
516 516
 	 */
517 517
 	private function getSharedWithMe($node = null, $includeTags, $stateFilter = 0) {
@@ -870,7 +870,7 @@  discard block
 block discarded – undo
870 870
 	}
871 871
 
872 872
 	/**
873
-	 * @param $id
873
+	 * @param integer $id
874 874
 	 * @param $state
875 875
 	 * @return \OC\OCS\Result
876 876
 	 */
@@ -1041,6 +1041,7 @@  discard block
 block discarded – undo
1041 1041
 	 * not support this we need to check all backends.
1042 1042
 	 *
1043 1043
 	 * @param string $id
1044
+	 * @param string $recipient
1044 1045
 	 * @return \OCP\Share\IShare
1045 1046
 	 * @throws ShareNotFound
1046 1047
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/AutorenamePlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 	/**
60 60
 	 * @param RequestInterface $request
61 61
 	 * @param ResponseInterface $response
62
-	 * @return bool|void
62
+	 * @return null|false
63 63
 	 * @throws \Sabre\DAV\Exception\BadRequest
64 64
 	 * @throws \Sabre\DAV\Exception\Conflict
65 65
 	 * @throws \Sabre\DAV\Exception\NotFound
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,6 +259,9 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 *
262
+	 * @param string $targetFilename
263
+	 * @param string $targetLocation
264
+	 * @param integer $timestamp
262 265
 	 */
263 266
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
264 267
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -784,7 +787,7 @@  discard block
 block discarded – undo
784 787
 	 * if the size limit for the trash bin is reached, we delete the oldest
785 788
 	 * files in the trash bin until we meet the limit again
786 789
 	 *
787
-	 * @param array $files
790
+	 * @param \OCP\Files\FileInfo[] $files
788 791
 	 * @param string $user
789 792
 	 * @param int $availableSpace available disc space
790 793
 	 * @return int size of deleted files
@@ -818,7 +821,7 @@  discard block
 block discarded – undo
818 821
 	/**
819 822
 	 * delete files older then max storage time
820 823
 	 *
821
-	 * @param array $files list of files sorted by mtime
824
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
822 825
 	 * @param string $user
823 826
 	 * @return integer[] size of deleted files and number of deleted files
824 827
 	 */
@@ -888,6 +891,7 @@  discard block
 block discarded – undo
888 891
 	 *
889 892
 	 * @param string $filename name of the file which should be restored
890 893
 	 * @param int $timestamp timestamp when the file was deleted
894
+	 * @param string|boolean $user
891 895
 	 * @return array
892 896
 	 */
893 897
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {
Please login to merge, or discard this patch.