OC\SystemConfig

Complexity

Total Complexity

18

Size/Duplication

Total Lines	153
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getKeys()	0	3	1
A	setValue()	0	3	1
A	setValues()	0	3	1
A	getValue()	0	3	1
A	getFilteredValue()	0	9	2
A	deleteValue()	0	3	1
B	removeSensitiveValue()	0	28	9
A	isReadOnly()	0	3	1

<?php
/**
 * @author Joas Schilling <coding@schilljs.com>
 * @author Jonathan Kawohl <john@owncloud.com>
 * @author Lukas Reschke <lukas@statuscode.ch>
 * @author Morris Jobke <hey@morrisjobke.de>
 * @author Roeland Jago Douma <rullzer@owncloud.com>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OC;

use OCP\IConfig;

/**
 * Class which provides access to the system config values stored in config.php
 * Internal class for bootstrap only.
 * fixes cyclic DI: AllConfig needs AppConfig needs Database needs AllConfig
 */
class SystemConfig {

	/** @var array */
	protected $sensitiveValues = [
		'dbpassword' => true,
		'dbuser' => true,
		'mail_smtpname' => true,
		'mail_smtppassword' => true,
		'mail_from_address' => true,
		'mail_domain' => true,
		'mail_smtphost' => true,
		'passwordsalt' => true,
		'secret' => true,
		'updater.secret' => true,
		'ldap_agent_password' => true,
		'proxyuserpwd' => true,
		'marketplace.key' => true,
		'log.condition' => [
			[
			'shared_secret' => true,
			]
		],
		'log.conditions' => [
			[
			'shared_secret' => true,
			]
		],
		'license-key' => true,
		'redis' => [
			'password' => true,
		],
		'objectstore' => [
			'arguments' => [
				'password' => true,
				'options' => [
					'credentials' =>[
						'key' => true,
						'secret' => true,
					],
				],
			],
		],
	];
	/** @var Config */
	private $config;

	public function __construct(Config $config) {
		$this->config = $config;
	}

	/**
	 * Lists all available config keys
	 * @return array an array of key names
	 */
	public function getKeys() {
		return $this->config->getKeys();
	}

	/**
	 * Sets a new system wide value
	 *
	 * @param string $key the key of the value, under which will be saved
	 * @param mixed $value the value that should be stored
	 */
	public function setValue($key, $value) {
		$this->config->setValue($key, $value);
	}

	/**
	 * Sets and deletes values and writes the config.php
	 *
	 * @param array $configs Associative array with `key => value` pairs
	 *                       If value is null, the config key will be deleted
	 */
	public function setValues(array $configs) {
		$this->config->setValues($configs);
	}

	/**
	 * Looks up a system wide defined value
	 *
	 * @param string $key the key of the value, under which it was saved
	 * @param mixed $default the default value to be returned if the value isn't set
	 * @return mixed the value or $default
	 */
	public function getValue($key, $default = '') {
		return $this->config->getValue($key, $default);
	}

	/**
	 * Looks up a system wide defined value and filters out sensitive data
	 *
	 * @param string $key the key of the value, under which it was saved
	 * @param mixed $default the default value to be returned if the value isn't set
	 * @return mixed the value or $default
	 */
	public function getFilteredValue($key, $default = '') {
		$value = $this->getValue($key, $default);

		if (isset($this->sensitiveValues[$key])) {
			$value = $this->removeSensitiveValue($this->sensitiveValues[$key], $value);
		}

		return $value;
	}

	/**
	 * Delete a system wide defined value
	 *
	 * @param string $key the key of the value, under which it was saved
	 */
	public function deleteValue($key) {
		$this->config->deleteKey($key);
	}

	/**
	 * @param bool|array $keysToRemove
	 * @param mixed $value
	 * @return mixed
	 */
	protected function removeSensitiveValue($keysToRemove, $value) {
		if ($keysToRemove === true) {
			return IConfig::SENSITIVE_VALUE;
		}

		if (\is_array($value)) {
			foreach ($keysToRemove as $keyToRemove => $valueToRemove) {

The expression $keysToRemove of type boolean|array is not guaranteed to be traversable. How about adding an additional type check?

				if ($keyToRemove === 0) {
					/*
					 * The 0 key in keysToRemove indicates a possibly repeating
					 * array of actual entries 0,1,2,3...
					 * Remove any sensitive values from all actual entries.
					 */
					foreach ($value as $valueKey => $valueData) {
						if (\is_int($valueKey) && ($valueKey >= 0)) {
							$value[$valueKey] = $this->removeSensitiveValue($valueToRemove, $value[$valueKey]);
						}
					}
				} else {
					if (isset($value[$keyToRemove])) {
						$value[$keyToRemove] = $this->removeSensitiveValue($valueToRemove, $value[$keyToRemove]);
					}
				}
			}
		}

		return $value;
	}

	public function isReadOnly() {
		return $this->config->isReadOnly();
	}
}