owncloud / core

apps/dav/lib/Upload/ChunkingPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
 	 *
 	 * @param string $path source path
 	 * @param string $destination destination path
-	 * @return bool|void false to stop handling, void to skip this handler
+	 * @return null|false false to stop handling, void to skip this handler
 	 */
 	public function performMove($path, $destination) {
 		if (!$this->server->tree->nodeExists($destination)) {

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 namespace OCA\DAV\Upload;
 
 
-use OCA\DAV\Connector\Sabre\File;
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Server;
 use Sabre\DAV\ServerPlugin;

lib/private/L10N/L10N.php

Doc Comments +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
 	 * Returns an associative array with all translations
 	 *
 	 * Called by String
-	 * @return array
+	 * @return string[]
 	 */
 	public function getTranslations() {
 		return $this->translations;

lib/public/Template.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
 /**
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
  * @param int $timestamp unix timestamp
- * @param boolean $dateOnly
- * @return \OC\L10N\L10NString human readable interpretation of the timestamp
+ * @param integer $dateOnly
+ * @return string human readable interpretation of the timestamp
  *
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
  */

apps/dav/lib/Connector/Sabre/File.php

Doc Comments +7 added lines, -1 removed lines

@@ -248,6 +248,9 @@ 
 		return '"' . $this->info->getEtag() . '"';
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function getPartFileBasePath($path) {
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
 		if ($partFileInStorage) {
@@ -617,7 +620,7 @@ 
 	/**
 	 * Set $algo to get a specific checksum, leave null to get all checksums
 	 * (space seperated)
-	 * @param null $algo
+	 * @param string $algo
 	 * @return string
 	 */
 	public function getChecksum($algo = null) {
@@ -640,6 +643,9 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $string
+	 */
 	protected function header($string) {
 		\header($string);
 	}

apps/files/lib/Command/TransferOwnership.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use OC\Encryption\Manager;
 use OC\Files\CustomView;
 use OC\Files\Filesystem;
-use OC\Files\Storage\Wrapper\Wrapper;
 use OC\Files\View;
 use OC\Memcache\ArrayCache;
 use OCP\Files\FileInfo;

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +1 added lines, -3 removed lines

@@ -628,7 +628,6 @@ 
 	 * @param string $sourceInternalPath
 	 * @param string $targetInternalPath
 	 * @param bool $preserveMtime
-	 * @param bool $isRename
 	 * @return bool
 	 */
 	public function copyFromStorage(Storage $sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime = false) {
@@ -692,7 +691,6 @@ 
 	 * @param string $sourceInternalPath
 	 * @param string $targetInternalPath
 	 * @param bool $preserveMtime
-	 * @param bool $isRename
 	 * @return bool
 	 * @throws \Exception
 	 */
@@ -999,7 +997,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

lib/private/Files/CustomView.php

Unused Use Statements -3 removed lines

@@ -21,12 +21,9 @@
 
 namespace  OC\Files;
 
-use OC\Encryption\CustomEncryptionWrapper;
-use OC\Encryption\Manager;
 use OC\Files\Cache;
 use OC\Files\Filesystem;
 use OC\Files\Storage\Storage;
-use OC\Memcache\ArrayCache;
 use OCP\Files\Mount\IMountPoint;
 use OCP\Lock\ILockingProvider;
 use OC\Files\Mount\MoveableMount;

Doc Comments +4 added lines, -4 removed lines

@@ -139,7 +139,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -453,7 +453,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|mixed
+	 * @return string|boolean
 	 */
 	public function file_exists($path) {
 		if ($path == '/') {
@@ -862,9 +862,9 @@ 
 	 *
 	 * @param string $operation
 	 * @param string $path
-	 * @param array $hooks (optional)
+	 * @param string[] $hooks (optional)
 	 * @param mixed $extraParam (optional)
-	 * @return mixed
+	 * @return string
 	 * @throws \Exception
 	 *
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing

lib/private/Files/Storage/Wrapper/CustomEncryption.php

Doc Comments +6 added lines, -3 removed lines

@@ -98,7 +98,6 @@ 
 	 * @param Update $update
 	 * @param Manager $mountManager
 	 * @param ArrayCache $arrayCache
-	 * @param Encryption $encryptionWrapper
 	 */
 	public function __construct(
 		$parameters,
@@ -148,7 +147,7 @@ 
 	 * @param string $path
 	 * @param string $mode
 	 * @param string|null $sourceFileOfRename
-	 * @return resource|bool
+	 * @return resource
 	 * @throws GenericEncryptionException
 	 * @throws ModuleDoesNotExistsException
 	 */
@@ -257,6 +256,10 @@ 
 		return $this->storage->fopen($path, $mode);
 	}
 
+	/**
+	 * @param string $path
+	 * @param string $mode
+	 */
 	public function fopenStorage($path, $mode) {
 		return fopen($this->storage->getSourcePath($path), $mode);
 	}
@@ -590,7 +593,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

Unused Use Statements -2 removed lines

@@ -24,7 +24,6 @@ 
 use OC\Encryption\Exceptions\ModuleDoesNotExistsException;
 use OC\Encryption\Update;
 use OC\Encryption\Util;
-use OC\Files\Cache\CacheEntry;
 use OC\Files\Filesystem;
 use OC\Files\Mount\Manager;
 use OC\Files\Storage\LocalTempFileTrait;
@@ -36,7 +35,6 @@ 
 use OCP\Files\Mount\IMountPoint;
 use OCP\Files\Storage;
 use OCP\ILogger;
-use OCP\Files\Cache\ICacheEntry;
 
 class CustomEncryption extends Wrapper {