Lock::setToken() - Code Metrics - Inspection of "Introduce persistent and explicit locking of file..." - owncloud/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#31651)

by Thomas

created 2018-08-06 12:11 UTC

Lock::setToken() A

↳ Parent: Lock

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/**
 * @author Thomas Müller <[email protected]>
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 */

namespace OC\Lock\Persistent;

use OCP\AppFramework\Db\Entity;
use OCP\Lock\Persistent\ILock;

/**
 * Class Lock
 *
 * @method int getFileId()
 * @method string getOwner()
 * @method int getTimeout()
 * @method int getCreatedAt()
 * @method string getToken()
 * @method string getTokenHash()
 * @method int getScope()
 * @method int getDepth()
 * @method string getPath()
 * @method string getUriV1()
 * @method string getUriV2()
 * @method string getOwnerAccountId()
 *
 * @method setFileId(int $fileId)
 * @method setCreatedAt(int $timestamp)
 * @method setTimeout(int $timeout)
 * @method setScope(int $scope)
 * @method setDepth(int $depth)
 *
 * @package OC\Lock\Persistent
 */
class Lock extends Entity implements ILock {

	/** @var int BIGINT - foreign key to oc_filecache.fileid */
	protected $fileId;
	/** @var string - plain text field as transmitted by clients*/
	protected $owner;
	/** @var int - seconds of lock life time */
	protected $timeout;
	/** @var int - unix timestamp when lock was created*/
	protected $createdAt;
	/** @var string - uuid in WebDAV */
	protected $token;
	/** @var string - md5 of token */
	protected $tokenHash;
	/** @var int - LOCK_SCOPE_EXCLUSIVE or LOCK_SCOPE_SHARED */
	protected $scope;
	/** @var int: 0, 1 or infinite */
	protected $depth;
	/** @var int - foreign key zu oc_account.id */
	protected $ownerAccountId;

	/** @var string - joined with oc_filecache */
	protected $path;
	/** @var string - computed value */
	protected $globalUserId;
	/** @var string - computed value */
	protected $globalFileName;

	public function __construct() {
		$this->addType('fileId', 'integer');
		$this->addType('timeout', 'integer');
		$this->addType('createdAt', 'integer');
		$this->addType('scope', 'integer');
		$this->addType('depth', 'integer');
		$this->addType('ownerAccountId', 'integer');
	}

	/**
	 * @param $token
	 */
	public function setToken($token) {
		parent::setter('token', [$token]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
		parent::setter('tokenHash', [\md5($token)]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}
}


1			<?php
2			/**
3			* @author Thomas Müller <[email protected]>
4			* @copyright Copyright (c) 2018, ownCloud GmbH
5			* @license AGPL-3.0
6			*
7			* This code is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU Affero General Public License, version 3,
9			* as published by the Free Software Foundation.
10			*
11			* This program is distributed in the hope that it will be useful,
12			* but WITHOUT ANY WARRANTY; without even the implied warranty of
13			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14			* GNU Affero General Public License for more details.
15			*
16			* You should have received a copy of the GNU Affero General Public License, version 3,
17			* along with this program. If not, see <http://www.gnu.org/licenses/>
18			*/
19
20			namespace OC\Lock\Persistent;
21
22			use OCP\AppFramework\Db\Entity;
23			use OCP\Lock\Persistent\ILock;
24
25			/**
26			* Class Lock
27			*
28			* @method int getFileId()
29			* @method string getOwner()
30			* @method int getTimeout()
31			* @method int getCreatedAt()
32			* @method string getToken()
33			* @method string getTokenHash()
34			* @method int getScope()
35			* @method int getDepth()
36			* @method string getPath()
37			* @method string getUriV1()
38			* @method string getUriV2()
39			* @method string getOwnerAccountId()
40			*
41			* @method setFileId(int $fileId)
42			* @method setCreatedAt(int $timestamp)
43			* @method setTimeout(int $timeout)
44			* @method setScope(int $scope)
45			* @method setDepth(int $depth)
46			*
47			* @package OC\Lock\Persistent
48			*/
49			class Lock extends Entity implements ILock {
50
51			/** @var int BIGINT - foreign key to oc_filecache.fileid */
52			protected $fileId;
53			/** @var string - plain text field as transmitted by clients*/
54			protected $owner;
55			/** @var int - seconds of lock life time */
56			protected $timeout;
57			/** @var int - unix timestamp when lock was created*/
58			protected $createdAt;
59			/** @var string - uuid in WebDAV */
60			protected $token;
61			/** @var string - md5 of token */
62			protected $tokenHash;
63			/** @var int - LOCK_SCOPE_EXCLUSIVE or LOCK_SCOPE_SHARED */
64			protected $scope;
65			/** @var int: 0, 1 or infinite */
66			protected $depth;
67			/** @var int - foreign key zu oc_account.id */
68			protected $ownerAccountId;
69
70			/** @var string - joined with oc_filecache */
71			protected $path;
72			/** @var string - computed value */
73			protected $globalUserId;
74			/** @var string - computed value */
75			protected $globalFileName;
76
77			public function __construct() {
78			$this->addType('fileId', 'integer');
79			$this->addType('timeout', 'integer');
80			$this->addType('createdAt', 'integer');
81			$this->addType('scope', 'integer');
82			$this->addType('depth', 'integer');
83			$this->addType('ownerAccountId', 'integer');
84			}
85
86			/**
87			* @param $token
88			*/
89			public function setToken($token) {
90			parent::setter('token', [$token]);
			0 ignored issues – show Comprehensibility Bug introduced 2018-06-29 14:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setter()` instead of `setToken()`). Are you sure this is correct? If so, you might want to change this to `$this->setter()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
91			parent::setter('tokenHash', [\md5($token)]);
			0 ignored issues – show Comprehensibility Bug introduced 2018-06-29 14:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setter()` instead of `setToken()`). Are you sure this is correct? If so, you might want to change this to `$this->setter()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
92			}
93			}
94

owncloud / core

Pull Request — master (#31651)

Lock::setToken() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like