Completed
Push — master ( 99c28a...4c4331 )
by Robin
47:48
created
build/license.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -118,6 +118,9 @@  discard block
 block discarded – undo
118 118
 		echo "License updated: $path" . PHP_EOL;
119 119
 	}
120 120
 
121
+	/**
122
+	 * @param string $source
123
+	 */
121 124
 	private function isMITLicensed($source) {
122 125
 		$lines = explode(PHP_EOL, $source);
123 126
 		while(!empty($lines)) {
@@ -131,6 +134,9 @@  discard block
 block discarded – undo
131 134
 		return false;
132 135
 	}
133 136
 
137
+	/**
138
+	 * @param string $source
139
+	 */
134 140
 	private function eatOldLicense($source) {
135 141
 		$lines = explode(PHP_EOL, $source);
136 142
 		while(!empty($lines)) {
Please login to merge, or discard this patch.
core/lostpassword/controller/lostcontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
 	}
132 132
 
133 133
 	/**
134
-	 * @param $message
134
+	 * @param string $message
135 135
 	 * @param array $additional
136 136
 	 * @return array
137 137
 	 */
Please login to merge, or discard this patch.
lib/private/activitymanager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 	/**
330 330
 	 * @param string $app
331 331
 	 * @param string $text
332
-	 * @param array $params
332
+	 * @param string $params
333 333
 	 * @param boolean $stripPath
334 334
 	 * @param boolean $highlightParams
335 335
 	 * @param string $languageCode
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	}
428 428
 
429 429
 	/**
430
-	 * @param array $types
430
+	 * @param string[] $types
431 431
 	 * @param string $filter
432 432
 	 * @return array
433 433
 	 */
Please login to merge, or discard this patch.
lib/private/allconfig.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * Looks up a system wide defined value
112 112
 	 *
113 113
 	 * @param string $key the key of the value, under which it was saved
114
-	 * @param mixed $default the default value to be returned if the value isn't set
114
+	 * @param string $default the default value to be returned if the value isn't set
115 115
 	 * @return mixed the value or $default
116 116
 	 */
117 117
 	public function getSystemValue($key, $default = '') {
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 	 * @param string $userId the userId of the user that we want to store the value under
265 265
 	 * @param string $appName the appName that we stored the value under
266 266
 	 * @param string $key the key under which the value is being stored
267
-	 * @param mixed $default the default value to be returned if the value isn't set
267
+	 * @param null|string $default the default value to be returned if the value isn't set
268 268
 	 * @return string
269 269
 	 */
270 270
 	public function getUserValue($userId, $appName, $key, $default = '') {
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	 *
382 382
 	 * @param string $appName app to get the value for
383 383
 	 * @param string $key the key to get the value for
384
-	 * @param array $userIds the user IDs to fetch the values for
384
+	 * @param string[] $userIds the user IDs to fetch the values for
385 385
 	 * @return array Mapped values: userId => value
386 386
 	 */
387 387
 	public function getUserValueForUsers($appName, $key, $userIds) {
Please login to merge, or discard this patch.
lib/private/api.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	/**
189 189
 	 * merge the returned result objects into one response
190 190
 	 * @param array $responses
191
-	 * @return array|\OC_OCS_Result
191
+	 * @return OC_OCS_Result
192 192
 	 */
193 193
 	public static function mergeResponses($responses) {
194 194
 		// Sort into shipped and third-party
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 
335 335
 	/**
336 336
 	 * http basic auth
337
-	 * @return string|false (username, or false on failure)
337
+	 * @return string (username, or false on failure)
338 338
 	 */
339 339
 	private static function loginUser() {
340 340
 		if(self::$isLoggedIn === true) {
@@ -440,6 +440,7 @@  discard block
 block discarded – undo
440 440
 
441 441
 	/**
442 442
 	 * Based on the requested format the response content type is set
443
+	 * @param string $format
443 444
 	 */
444 445
 	public static function setContentType($format = null) {
445 446
 		$format = is_null($format) ? self::requestedFormat() : $format;
Please login to merge, or discard this patch.
lib/private/app/appmanager.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	/**
89 89
 	 * List all installed apps
90 90
 	 *
91
-	 * @return string[]
91
+	 * @return integer[]
92 92
 	 */
93 93
 	public function getInstalledApps() {
94 94
 		return array_keys($this->getInstalledAppsValues());
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	/**
217 217
 	 * Returns a list of apps that need upgrade
218 218
 	 *
219
-	 * @param array $version ownCloud version as array of version components
219
+	 * @param array $ocVersion ownCloud version as array of version components
220 220
 	 * @return array list of app info from apps that need an upgrade
221 221
 	 *
222 222
 	 * @internal
@@ -289,6 +289,9 @@  discard block
 block discarded – undo
289 289
 		return in_array($appId, $this->shippedApps);
290 290
 	}
291 291
 
292
+	/**
293
+	 * @param string $appId
294
+	 */
292 295
 	private function isAlwaysEnabled($appId) {
293 296
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
294 297
 		return in_array($appId, $alwaysEnabled);
Please login to merge, or discard this patch.
lib/private/app/dependencyanalyzer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
 	 * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1
74 74
 	 * @param string $first
75 75
 	 * @param string $second
76
-	 * @return array first element is the first version, second element is the
76
+	 * @return string[] first element is the first version, second element is the
77 77
 	 * second version
78 78
 	 */
79 79
 	private function normalizeVersions($first, $second) {
Please login to merge, or discard this patch.
lib/private/app/platformrepository.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -206,6 +206,9 @@
 block discarded – undo
206 206
 		throw new \UnexpectedValueException('Invalid version string "' . $version . '"' . $extraMessage);
207 207
 	}
208 208
 
209
+	/**
210
+	 * @param string $stability
211
+	 */
209 212
 	private function expandStability($stability) {
210 213
 		$stability = strtolower($stability);
211 214
 		switch ($stability) {
Please login to merge, or discard this patch.
lib/private/appframework/utility/simplecontainer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
 
114 114
 	/**
115 115
 	 * @param string $name
116
-	 * @param mixed $value
116
+	 * @param string $value
117 117
 	 */
118 118
 	public function registerParameter($name, $value) {
119 119
 		$this[$name] = $value;
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -29,9 +29,7 @@
 block discarded – undo
29 29
 use ReflectionClass;
30 30
 use ReflectionException;
31 31
 use Closure;
32
-
33 32
 use Pimple\Container;
34
-
35 33
 use OCP\AppFramework\QueryException;
36 34
 use OCP\IContainer;
37 35
 
Please login to merge, or discard this patch.