owncloud / core

apps/files_trashbin/tests/trashbin.php

Doc Comments +16 added lines, -3 removed lines

@@ -246,8 +246,8 @@ 
 
 	/**
 	 * verify that the array contains the expected results
-	 * @param array $result
-	 * @param array $expected
+	 * @param OCP\Files\FileInfo[] $result
+	 * @param string[] $expected
 	 */
 	private function verifyArray($result, $expected) {
 		$this->assertSame(count($expected), count($result));
@@ -266,6 +266,11 @@ 
 		}
 	}
 
+	/**
+	 * @param OCP\Files\FileInfo[] $files
+	 * @param string $trashRoot
+	 * @param integer $expireDate
+	 */
 	private function manipulateDeleteTime($files, $trashRoot, $expireDate) {
 		$counter = 0;
 		foreach ($files as &$file) {
@@ -625,7 +630,6 @@ 
 	/**
 	 * @param string $user
 	 * @param bool $create
-	 * @param bool $password
 	 */
 	public static function loginHelper($user, $create = false) {
 		if ($create) {
@@ -648,11 +652,20 @@ 
 
 // just a dummy class to make protected methods available for testing
 class TrashbinForTesting extends Files_Trashbin\Trashbin {
+
+	/**
+	 * @param OCP\Files\FileInfo[] $files
+	 * @param integer $limit
+	 */
 	public function dummyDeleteExpiredFiles($files, $limit) {
 		// dummy value for $retention_obligation because it is not needed here
 		return parent::deleteExpiredFiles($files, \Test_Trashbin::TEST_TRASHBIN_USER1, $limit, 0);
 	}
 
+	/**
+	 * @param OCP\Files\FileInfo[] $files
+	 * @param integer $availableSpace
+	 */
 	public function dummyDeleteFiles($files, $availableSpace) {
 		return parent::deleteFiles($files, \Test_Trashbin::TEST_TRASHBIN_USER1, $availableSpace);
 	}

apps/files_versions/lib/storage.php

Doc Comments +1 added lines, -1 removed lines

@@ -649,7 +649,7 @@
 	/**
 	 * Expire versions which exceed the quota
 	 *
-	 * @param $filename
+	 * @param string $filename
 	 * @param int|null $versionsSize
 	 * @param int $offset
 	 * @return bool|int|null

apps/provisioning_api/tests/groupstest.php

Doc Comments +6 added lines

@@ -58,6 +58,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $gid
+	 */
 	private function createGroup($gid) {
 		$group = $this->getMock('OCP\IGroup');
 		$group
@@ -66,6 +69,9 @@ 
 		return $group;
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	private function createUser($uid) {
 		$user = $this->getMock('OCP\IUser');
 		$user

apps/provisioning_api/tests/userstest.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use OCA\Provisioning_API\Users;
 use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\IGroupManager;
 use OCP\IUserSession;
 use Test\TestCase as OriginalTest;
 use OCP\ILogger;

apps/user_ldap/command/setconfig.php

Doc Comments -2 removed lines

@@ -73,8 +73,6 @@
 	/**
 	 * save the configuration value as provided
 	 * @param string $configID
-	 * @param string $configKey
-	 * @param string $configValue
 	 */
 	protected function setValue($configID, $key, $value) {
 		$configHolder = new Configuration($configID);

apps/user_ldap/lib/configuration.php

Doc Comments -1 removed lines

@@ -281,7 +281,6 @@
 	 * 
 	 * @param string $varName name of config-key
 	 * @param array|string $value to set
-	 * @param boolean $trim Trim value? (default: false)
 	 */
 	protected function setMultiLine($varName, $value) {
 		if(empty($value)) {

apps/user_ldap/lib/jobs.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 	}
 
 	/**
-	 * @return int
+	 * @return string
 	 */
 	static private function getRefreshInterval() {
 		//defaults to every hour

apps/user_ldap/lib/wizard.php

Doc Comments +2 added lines, -2 removed lines

@@ -864,7 +864,7 @@ 
 	 * @param integer $filterType int, for which use case the filter shall be created
 	 * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or
 	 * self::LFILTER_GROUP_LIST
-	 * @return string|false string with the filter on success, false otherwise
+	 * @return string string with the filter on success, false otherwise
 	 * @throws \Exception
 	 */
 	private function composeLdapFilter($filterType) {
@@ -1107,7 +1107,7 @@ 
 	}
 
 	/**
-	 * @param array $reqs
+	 * @param string[] $reqs
 	 * @return bool
 	 */
 	private function checkRequirements($reqs) {

apps/user_ldap/tests/integration/lib/integrationtestfetchusersbyloginname.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 
 namespace OCA\user_ldap\tests\integration\lib;
 
-use OCA\user_ldap\lib\user\Manager as LDAPUserManager;
 use OCA\user_ldap\tests\integration\AbstractIntegrationTest;
 use OCA\User_LDAP\Mapping\UserMapping;
 use OCA\user_ldap\USER_LDAP;