owncloud / core

apps/files_sharing/lib/controllers/externalsharescontroller.php

Doc Comments +1 added lines, -2 removed lines

@@ -45,7 +45,6 @@ 
 	/**
 	 * @param string $appName
 	 * @param IRequest $request
-	 * @param bool $incomingShareEnabled
 	 * @param \OCA\Files_Sharing\External\Manager $externalManager
 	 * @param IClientService $clientService
 	 */
@@ -84,7 +83,7 @@ 
 	 * @NoAdminRequired
 	 * @NoOutgoingFederatedSharingRequired
 	 *
-	 * @param $id
+	 * @param integer $id
 	 * @return JSONResponse
 	 */
 	public function destroy($id) {

apps/files_sharing/lib/controllers/sharecontroller.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
 	 * @UseSession
 	 *
 	 * Authenticates against password-protected shares
-	 * @param $token
+	 * @param string $token
 	 * @param string $password
 	 * @return RedirectResponse|TemplateResponse
 	 */

apps/files_sharing/lib/middleware/sharingcheckmiddleware.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\App\IAppManager;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\AppFramework\Middleware;
-use OCP\AppFramework\Http\TemplateResponse;
 use OCP\Files\NotFoundException;
 use OCP\IConfig;
 use OCP\AppFramework\Utility\IControllerMethodReflector;

apps/files_sharing/lib/sharedmount.php

Doc Comments +5 added lines

@@ -53,6 +53,11 @@
 	 */
 	private $user;
 
+	/**
+	 * @param string $storage
+	 * @param string $mountpoint
+	 * @param \OCP\Files\Storage\IStorageFactory $loader
+	 */
 	public function __construct($storage, $mountpoint, $arguments = null, $loader = null) {
 		// first update the mount point before creating the parent
 		$this->ownerPropagator = $arguments['propagator'];

apps/files_sharing/lib/sharedstorage.php

Unused Use Statements -2 removed lines

@@ -32,8 +32,6 @@
 
 use OC\Files\Filesystem;
 use OCA\Files_Sharing\ISharedStorage;
-use OCA\Files_Sharing\Propagator;
-use OCA\Files_Sharing\SharedMount;
 use OCP\Lock\ILockingProvider;
 
 /**

Doc Comments +3 added lines

@@ -144,6 +144,9 @@
 		return true;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function url_stat($path) {
 		if (isset(self::$data[$path])) {
 			$size = strlen(self::$data[$path]);

apps/files_sharing/tests/api/share20ocstest.php

Doc Comments +10 added lines

@@ -119,6 +119,16 @@
 		$this->assertEquals($expected, $this->ocs->getShare(42));
 	}
 
+	/**
+	 * @param integer $id
+	 * @param integer $permissions
+	 * @param integer $shareTime
+	 * @param integer $parent
+	 * @param string $target
+	 * @param integer $mail_send
+	 * @param string $token
+	 * @param string $password
+	 */
 	public function createShare($id, $shareType, $sharedWith, $sharedBy, $path, $permissions,
 								$shareTime, $expiration, $parent, $target, $mail_send, $token=null,
 								$password=null) {

apps/files_sharing/tests/api/shareestest.php

Doc Comments +7 added lines

@@ -81,6 +81,10 @@ 
 		);
 	}
 
+	/**
+	 * @param string $uid
+	 * @param string $displayName
+	 */
 	protected function getUserMock($uid, $displayName) {
 		$user = $this->getMockBuilder('OCP\IUser')
 			->disableOriginalConstructor()
@@ -97,6 +101,9 @@ 
 		return $user;
 	}
 
+	/**
+	 * @param string $gid
+	 */
 	protected function getGroupMock($gid) {
 		$group = $this->getMockBuilder('OCP\IGroup')
 			->disableOriginalConstructor()

apps/files_sharing/tests/locking.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 
 use OC\Files\Filesystem;
 use OC\Files\View;
-use OC\Lock\MemcacheLockingProvider;
 use OCP\Lock\ILockingProvider;
 
 class Locking extends TestCase {

apps/files_sharing/tests/share.php

Doc Comments +4 added lines

@@ -218,6 +218,10 @@
 
 	}
 
+	/**
+	 * @param OC\Files\FileInfo[] $content
+	 * @param string[] $expected
+	 */
 	public function verifyDirContent($content, $expected) {
 		foreach ($content as $c) {
 			if (!in_array($c['name'], $expected)) {