OCA\Provisioning_API\Tests\AppsTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	82
Duplicated Lines	9.76 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	9	1
A	testGetAppInfo()	0	5	1
A	testGetAppInfoOnBadAppID()	6	6	1
D	testGetApps()	1	15	1
A	testGetAppsEnabled()	0	7	1
A	testGetAppsDisabled()	0	17	2
A	testGetAppsInvalidFilter()	0	6	1

<?php
/**
 * @author Joas Schilling <nickvergessen@owncloud.com>
 * @author Morris Jobke <hey@morrisjobke.de>
 * @author Roeland Jago Douma <rullzer@owncloud.com>
 * @author Tom Needham <tom@owncloud.com>
 *
 * @copyright Copyright (c) 2015, ownCloud, Inc.
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Provisioning_API\Tests;
use OC\OCSClient;
use OCA\Provisioning_API\Apps;
use OCP\API;
use OCP\App\IAppManager;
use OCP\IUserSession;

/**
 * Class AppsTest
 *
 * @group DB
 *
 * @package OCA\Provisioning_API\Tests
 */
class AppsTest extends TestCase {
	/** @var IAppManager */
	private $appManager;
	/** @var Apps */
	private $api;
	/** @var IUserSession */
	private $userSession;
	/** @var OCSClient */
	private $ocsClient;

	public function setup() {
		parent::setup();
		$this->appManager = \OC::$server->getAppManager();
		$this->groupManager = \OC::$server->getGroupManager();
		$this->userSession = \OC::$server->getUserSession();
		$this->ocsClient = $this->getMockBuilder('\OC\OCSClient')
				->disableOriginalConstructor()->getMock();
		$this->api = new Apps($this->appManager, $this->ocsClient);
	}

	public function testGetAppInfo() {
		$result = $this->api->getAppInfo(['appid' => 'provisioning_api']);
		$this->assertInstanceOf('OC_OCS_Result', $result);
		$this->assertTrue($result->succeeded());
	}

	public function testGetAppInfoOnBadAppID() {
		$result = $this->api->getAppInfo(['appid' => 'not_provisioning_api']);
		$this->assertInstanceOf('OC_OCS_Result', $result);
		$this->assertFalse($result->succeeded());
		$this->assertEquals(API::RESPOND_NOT_FOUND, $result->getStatusCode());
	}

	public function testGetApps() {
		$this->ocsClient

The method expects() does not seem to exist on object<OC\OCSClient>.

				->expects($this->any())
				->method($this->anything())
				->will($this->returnValue(null));
		$user = $this->generateUsers();
		$this->groupManager->get('admin')->addUser($user);

It seems like $user defined by $this->generateUsers() on line 77 can also be of type array<integer,object<OCP\IUser>>; however, OCP\IGroup::addUser() does only seem to accept object<OCP\IUser>, maybe add an additional type check?

		$this->userSession->setUser($user);

It seems like $user defined by $this->generateUsers() on line 77 can also be of type array<integer,object<OCP\IUser>>; however, OCP\IUserSession::setUser() does only seem to accept object<OCP\IUser>|null, maybe add an additional type check?

		$result = $this->api->getApps([]);

		$this->assertTrue($result->succeeded());
		$data = $result->getData();
		$this->assertEquals(count(\OC_App::listAllApps(false, true, $this->ocsClient)), count($data['apps']));
	}

	public function testGetAppsEnabled() {
		$_GET['filter'] = 'enabled';
		$result = $this->api->getApps(['filter' => 'enabled']);
		$this->assertTrue($result->succeeded());
		$data = $result->getData();
		$this->assertEquals(count(\OC_App::getEnabledApps()), count($data['apps']));
	}

	public function testGetAppsDisabled() {
		$this->ocsClient

The method expects() does not seem to exist on object<OC\OCSClient>.

				->expects($this->any())
				->method($this->anything())
				->will($this->returnValue(null));
		$_GET['filter'] = 'disabled';
		$result = $this->api->getApps(['filter' => 'disabled']);
		$this->assertTrue($result->succeeded());
		$data = $result->getData();
		$apps = \OC_App::listAllApps(false, true, $this->ocsClient);
		$list =  array();
		foreach($apps as $app) {
			$list[] = $app['id'];
		}
		$disabled = array_diff($list, \OC_App::getEnabledApps());
		$this->assertEquals(count($disabled), count($data['apps']));
	}

	public function testGetAppsInvalidFilter() {
		$_GET['filter'] = 'foo';
		$result = $this->api->getApps([]);
		$this->assertFalse($result->succeeded());
		$this->assertEquals(101, $result->getStatusCode());
	}
}