owncloud / core

core/Migrations/Version20170221114437.php

Unused Use Statements -2 removed lines

@@ -1,12 +1,10 @@
 <?php
 namespace OC\Migrations;
 
-use OC\User\Account;
 use OC\User\AccountMapper;
 use OC\User\AccountTermMapper;
 use OC\User\Database;
 use OC\User\SyncService;
-use OCP\IConfig;
 use OCP\Migration\ISimpleMigration;
 use OCP\Migration\IOutput;
 

lib/private/App/AppManager.php

Doc Comments +6 added lines, -3 removed lines

@@ -122,7 +122,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -355,6 +355,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);
@@ -383,7 +386,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -400,7 +403,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

lib/private/User/AccountMapper.php

Doc Comments +13 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @param array $terms
 	 */
 	public function setTermsForAccount($account_id, array $terms) {
@@ -51,7 +51,7 @@ 
 
 	/**
 	 * Delegate to term mapper to avoid needing to inject term mapper
-	 * @param $account_id
+	 * @param integer $account_id
 	 * @return AccountTerm[] $terms
 	 */
 	public function findByAccountId($account_id) {
@@ -164,6 +164,9 @@ 
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCountPerBackend($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -186,6 +189,9 @@ 
 		return $return;
 	}
 
+	/**
+	 * @param boolean $hasLoggedIn
+	 */
 	public function getUserCount($hasLoggedIn) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select([$qb->createFunction('count(*) as `count`')])
@@ -202,6 +208,11 @@ 
 		return (int) $data['count'];
 	}
 
+	/**
+	 * @param \Closure $callback
+	 * @param string $search
+	 * @param boolean $onlySeen
+	 */
 	public function callForAllUsers($callback, $search, $onlySeen) {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select(['*'])

lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php

Doc Comments +2 added lines, -2 removed lines

@@ -361,7 +361,7 @@ 
 	 *
 	 * @param string $column
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function castColumn($column, $type) {
 		return new QueryFunction(
@@ -372,7 +372,7 @@ 
 	/**
 	 * Returns a query function to find the number of characters in a string column
 	 * @param string $column
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function length($column) {
 		$column = $this->helper->quoteColumnName($column);

apps/provisioning_api/lib/Users.php

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * @param IUser $user user to check access
 	 * @param IGroup|null $group group to check or null
 	 *
-	 * @return true if the user can manage the group
+	 * @return boolean if the user can manage the group
 	 */
 	private function canUserManageGroup($user, $group) {
 		if ($this->groupManager->isAdmin($user->getUID())) {

lib/private/User/User.php

Doc Comments +6 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @param Account $account
 	 * @param AccountMapper $mapper
-	 * @param null $emitter
+	 * @param Manager $emitter
 	 * @param IConfig|null $config
 	 * @param null $urlGenerator
 	 * @param EventDispatcher|null $eventDispatcher
@@ -97,7 +97,7 @@ 
 	/**
 	 * get the user id
 	 *
-	 * @return string
+	 * @return integer
 	 */
 	public function getUID() {
 		return $this->account->getUserId();
@@ -433,6 +433,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);

lib/private/DB/MigrationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -361,7 +361,7 @@
 
 	/**
 	 * @param string $version
-	 * @return mixed
+	 * @return \Doctrine\DBAL\Schema\Schema
 	 * @throws \Exception
 	 */
 	protected function createInstance($version) {

lib/private/legacy/template.php

Doc Comments +1 added lines

@@ -319,6 +319,7 @@
 		* @param string $error_msg The error message to show
 		* @param string $hint An optional hint message - needs to be properly escaped
 		* @param int HTTP Status Code
+		* @param integer $httpStatusCode
 		*/
 	public static function printErrorPage( $error_msg, $hint = '', $httpStatusCode = null ) {
 		if ($error_msg === $hint) {

settings/Application.php

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 
 namespace OC\Settings;
 
-use OC\Files\View;
 use OC\Server;
 use OC\AppFramework\Utility\TimeFactory;
 use OC\Settings\Controller\SettingsPageController;