owncloud / core

lib/private/Lock/Persistent/Lock.php

Doc Comments +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
 	/**
 	 * Unix timestamp when lock was created
 	 *
-	 * @return mixed
+	 * @return integer
 	 * @since 11.0.0
 	 */
 	public function getCreatedAt(): int {

core/Controller/LostController.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	}
 
 	/**
-	 * @param $message
+	 * @param string $message
 	 * @param array $additional
 	 * @return array
 	 */
@@ -281,7 +281,7 @@ 
 
 	/**
 	 * @param string $userId
-	 * @return array
+	 * @return string[]
 	 */
 	public function generateTokenAndLink($userId) {
 		$token = $this->secureRandom->generate(21,

lib/private/Share/MailNotifications.php

Doc Comments +3 added lines, -3 removed lines

@@ -222,10 +222,10 @@
 	 * inform recipient about public link share
 	 *
 	 * @param string $recipient recipient email address
-	 * @param string $filename the shared file
-	 * @param string $link the public link
 	 * @param array $options allows ['to], ['cc'] and ['bcc'] recipients
-	 * @param int $expiration expiration date (timestamp)
+	 * @param string $subject
+	 * @param boolean|string $htmlBody
+	 * @param boolean|string $textBody
 	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = []) {

lib/public/Util.php

Doc Comments +1 added lines, -1 removed lines

@@ -657,7 +657,7 @@
 	/**
 	 * Determine if the string is, strictly-speaking, empty or not
 	 *
-	 * @param $value
+	 * @param string $value
 	 * @return bool
 	 * @since 10.0.1
 	 */

core/Command/Db/Migrations/GenerateCommand.php

Doc Comments +3 added lines

@@ -146,6 +146,9 @@
 		return $path;
 	}
 
+	/**
+	 * @param string $kind
+	 */
 	private function getTemplate($kind) {
 		if ($kind === 'simple') {
 			return self::$_templateSimple;

core/Command/Encryption/ChangeKeyStorageRoot.php

Doc Comments +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
 	/**
 	 * check if target already exists
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 * @throws \Exception
 	 */

core/Command/User/ResetPassword.php

Unused Use Statements -5 removed lines

@@ -32,12 +32,7 @@
 use OC\Helper\EnvironmentHelper;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\IConfig;
-use OCP\IL10N;
-use OCP\IURLGenerator;
 use OCP\IUserManager;
-use OCP\Mail\IMailer;
-use OCP\Security\ISecureRandom;
-use OCP\Util;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputArgument;

lib/public/SystemTag/ISystemTagManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -103,17 +103,19 @@ 
 	 * with the same attributes
 	 *
 	 * @since 9.0.0
+	 * @return void
 	 */
 	public function updateTag($tagId, $newName, $userVisible, $userEditable, $userAssignable);
 
 	/**
 	 * Delete the given tags from the database and all their relationships.
 	 *
-	 * @param string|array $tagIds array of tag ids
+	 * @param string $tagIds array of tag ids
 	 *
 	 * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
 	 *
 	 * @since 9.0.0
+	 * @return void
 	 */
 	public function deleteTags($tagIds);
 
@@ -124,7 +126,7 @@ 
 	 * @param ISystemTag $tag tag to check permission for
 	 * @param IUser $user user to check permission for
 	 *
-	 * @return true if the user is allowed to assign/unassign the tag, false otherwise
+	 * @return boolean if the user is allowed to assign/unassign the tag, false otherwise
 	 *
 	 * @since 9.1.0
 	 */
@@ -134,9 +136,9 @@ 
 	 * Checks whether the given user is allowed to see the tag with the given id.
 	 *
 	 * @param ISystemTag $tag tag to check permission for
-	 * @param IUser $user user to check permission for
+	 * @param IUser $userId user to check permission for
 	 *
-	 * @return true if the user can see the tag, false otherwise
+	 * @return boolean if the user can see the tag, false otherwise
 	 *
 	 * @since 9.1.0
 	 */
@@ -149,6 +151,7 @@ 
 	 * @param string[] $groupIds group ids of groups that can assign/unassign the tag
 	 *
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function setTagGroups(ISystemTag $tag, $groupIds);