owncloud / core

apps/dav/lib/DAV/FileCustomPropertiesBackend.php

Doc Comments +1 added lines, -1 removed lines

@@ -204,7 +204,7 @@
 
 	/**
 	 * @param string $path
-	 * @return INode|null
+	 * @return null|Node
 	 */
 	protected function getNodeForPath($path){
 		$node = parent::getNodeForPath($path);

lib/private/DB/Adapter.php

Doc Comments +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
 
 	/**
 	 * @param string $table name
-	 * @return int id of last insert statement
+	 * @return string id of last insert statement
 	 */
 	public function lastInsertId($table) {
 		return $this->conn->realLastInsertId($table);
@@ -118,7 +118,7 @@ 
 
 	/**
 	 * Inserts, or updates a row into the database. Returns the inserted or updated rows
-	 * @param $table string table name including **PREFIX**
+	 * @param string $table string table name including **PREFIX**
 	 * @param $input array the key=>value pairs to insert into the db row
 	 * @param $compare array columns that should be compared to look for existing arrays
 	 * @return int the number of rows affected by the operation

lib/private/AllConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * In some environments the system config file is readonly. Find out if this
 	 * is the case.
 	 *
-	 * @return boolean
+	 * @return false|string
 	 * @since 10.0.3
 	 */
 	public function isSystemConfigReadOnly() {

lib/private/Mail/Message.php

Doc Comments +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	/**
 	 * Returns the Reply-To address of this message
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getReplyTo() {
 		return $this->swiftMessage->getReplyTo();

apps/dav/lib/Connector/Sabre/CorsPlugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
 	 * This method should set up the required event subscriptions.
 	 *
 	 * @param \Sabre\DAV\Server $server
-	 * @return void
+	 * @return false|null
 	 */
 	public function initialize(\Sabre\DAV\Server $server) {
 		$this->server = $server;
@@ -96,7 +96,7 @@ 
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return false
+	 * @return false|null
 	 */
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
 		$authorization = $request->getHeader('Authorization');

lib/private/App/AppManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -122,7 +122,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppManagerException
 	 */
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -95,7 +95,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry 
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -125,6 +125,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -164,6 +167,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -193,6 +199,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -203,6 +212,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -353,6 +365,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

apps/dav/lib/Connector/Sabre/File.php

Doc Comments +7 added lines, -1 removed lines

@@ -269,6 +269,9 @@ 
 		], 'file', 'create');
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function getPartFileBasePath($path) {
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
 		if ($partFileInStorage) {
@@ -654,7 +657,7 @@ 
 	/**
 	 * Set $algo to get a specific checksum, leave null to get all checksums
 	 * (space seperated)
-	 * @param null $algo
+	 * @param string $algo
 	 * @return string
 	 */
 	public function getChecksum($algo = null) {
@@ -677,6 +680,9 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $string
+	 */
 	protected function header($string) {
 		\header($string);
 	}

apps/encryption/lib/Command/RecreateMasterKey.php

Unused Use Statements -3 removed lines

@@ -23,11 +23,8 @@
 namespace OCA\Encryption\Command;
 
 use OC\Encryption\DecryptAll;
-use OC\Encryption\Exceptions\DecryptionFailedException;
 use OC\Encryption\Manager;
-use OC\Files\Filesystem;
 use OC\Files\View;
-use OC\Memcache\ArrayCache;
 use OCA\Encryption\Crypto\EncryptAll;
 use OCA\Encryption\KeyManager;
 use OCA\Encryption\Users\Setup;