owncloud / core

lib/private/Files/Node/Root.php

Doc Comments +4 added lines, -1 removed lines

@@ -175,7 +175,7 @@ 
 	 * @param string $path
 	 * @throws \OCP\Files\NotFoundException
 	 * @throws \OCP\Files\NotPermittedException
-	 * @return File|Folder
+	 * @return string
 	 */
 	public function get($path) {
 		$path = $this->normalizePath($path);
@@ -373,6 +373,9 @@ 
 		return $folder;
 	}
 
+	/**
+	 * @param string $fullPath
+	 */
 	private function resolveVirtualNode($fullPath) {
 		$pieces = \explode('/', $fullPath);
 		if ($pieces[1] !== 'meta') {

lib/private/legacy/api.php

Doc Comments +2 added lines, -2 removed lines

@@ -269,7 +269,7 @@ 
 	/**
 	 * authenticate the api call
 	 * @param array $action the action details as supplied to OC_API::register()
-	 * @return bool
+	 * @return boolean|string
 	 */
 	private static function isAuthorised($action) {
 		$level = $action['authlevel'];
@@ -318,7 +318,7 @@ 
 
 	/**
 	 * http basic auth
-	 * @return string|false (username, or false on failure)
+	 * @return string|boolean (username, or false on failure)
 	 */
 	private static function loginUser() {
 		if (self::$isLoggedIn === true) {

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -102,7 +102,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -132,6 +132,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -171,6 +174,9 @@ 
 		}
 	}
 
+	/**
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -200,6 +206,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -210,6 +219,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -359,6 +371,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

lib/private/Tags.php

Doc Comments +10 added lines, -2 removed lines

@@ -741,11 +741,19 @@ 
 	}
 
 	// case-insensitive array_search
+
+	/**
+	 * @param string $needle
+	 */
 	protected function array_searchi($needle, $haystack, $mem='getName') {
 		if (!\is_array($haystack)) {
 			return false;
 		}
 		return \array_search(\strtolower($needle), \array_map(
+
+			/**
+			 * @param string $tag
+			 */
 			function ($tag) use ($mem) {
 				return \strtolower(\call_user_func([$tag, $mem]));
 			}, $haystack)
@@ -770,7 +778,7 @@ 
 	* Get a tag by its name.
 	*
 	* @param string $name The tag name.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@ 
 	* Get a tag by its ID.
 	*
 	* @param string $id The tag ID to look for.
-	* @return integer|bool The tag object's offset within the $this->tags
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
 	*                      array or false if it doesn't exist.
 	*/
 	private function getTagById($id) {

lib/public/Files.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
 	/**
 	 * Search for files by mimetype
 	 * @param string $mimetype
-	 * @return array
+	 * @return \OC\Files\FileInfo[]
 	 * @since 6.0.0
 	 */
 	public static function searchByMime($mimetype) {

lib/public/Migration/IOutput.php

Doc Comments +5 added lines, -1 removed lines

@@ -32,18 +32,21 @@ 
 	/**
 	 * @param string $message
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function info($message);
 
 	/**
 	 * @param string $message
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function warning($message);
 
 	/**
 	 * @param int $max
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function startProgress($max = 0);
 
@@ -51,12 +54,13 @@ 
 	 * @param int $step
 	 * @param string $description
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function advance($step = 1, $description = '');
 
 	/**
-	 * @param int $max
 	 * @since 9.1.0
+	 * @return void
 	 */
 	public function finishProgress();
 }

settings/ChangePassword/Controller.php

Doc Comments +3 added lines

@@ -67,6 +67,9 @@
 		}
 	}
 
+	/**
+	 * @param string|boolean $username
+	 */
 	private static function sendNotificationMail($username) {
 		$userObject = \OC::$server->getUserManager()->get($username);
 		$email = $userObject->getEMailAddress();

apps/dav/lib/CardDAV/SyncService.php

Doc Comments +1 added lines, -1 removed lines

@@ -245,7 +245,7 @@
 	}
 
 	/**
-	 * @return array|null
+	 * @return string
 	 */
 	public function getLocalSystemAddressBook() {
 		if ($this->localSystemAddressBook === null) {

apps/files_sharing/lib/Hooks.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use OCP\Share\IShare;
 use Symfony\Component\EventDispatcher\GenericEvent;
 use OCA\Files_Sharing\Service\NotificationPublisher;
-use OCP\Share\Exceptions\ShareNotFound;
 
 class Hooks {
 	/**

Doc Comments +4 added lines

@@ -138,6 +138,10 @@
 		);
 	}
 
+	/**
+	 * @param IShare[] $shares
+	 * @param string $fileId
+	 */
 	private function filterSharesByFileId($shares, $fileId) {
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
 			return \strval($share->getNodeId()) === \strval($fileId);