Completed
Pull Request — master (#27846)
by Philipp
11:21
created
lib/private/User/User.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 *
72 72
 	 * @param Account $account
73 73
 	 * @param AccountMapper $mapper
74
-	 * @param null $emitter
74
+	 * @param Manager $emitter
75 75
 	 * @param IConfig|null $config
76 76
 	 * @param null $urlGenerator
77 77
 	 * @param EventDispatcher|null $eventDispatcher
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	/**
97 97
 	 * get the user id
98 98
 	 *
99
-	 * @return string
99
+	 * @return integer
100 100
 	 */
101 101
 	public function getUID() {
102 102
 		return $this->account->getUserId();
@@ -413,6 +413,10 @@  discard block
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Mapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
Please login to merge, or discard this patch.
lib/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 	/**
330 330
 	 * Checks if the version requires an update and shows
331 331
 	 * @param bool $showTemplate Whether an update screen should get shown
332
-	 * @return bool
332
+	 * @return null|boolean
333 333
 	 */
334 334
 	public static function checkUpgrade($showTemplate = true) {
335 335
 		if (\OCP\Util::needUpgrade()) {
Please login to merge, or discard this patch.
lib/private/User/Account.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 
26 26
 use OCP\AppFramework\Db\Entity;
27
-use OCP\AppFramework\QueryException;
28 27
 use OCP\UserInterface;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
core/Migrations/Version20170221114437.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,11 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace OC\Migrations;
3 3
 
4
-use OC\User\Account;
5 4
 use OC\User\AccountMapper;
6 5
 use OC\User\Database;
7 6
 use OC\User\SyncService;
8
-use OCP\IConfig;
9 7
 use OCP\Migration\ISimpleMigration;
10 8
 use OCP\Migration\IOutput;
11 9
 
Please login to merge, or discard this patch.
lib/private/User/Database.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@
 block discarded – undo
308 308
 	/**
309 309
 	 * counts the users in the database
310 310
 	 *
311
-	 * @return int|bool
311
+	 * @return integer
312 312
 	 */
313 313
 	public function countUsers() {
314 314
 		$query = \OC_DB::prepare('SELECT COUNT(*) FROM `*PREFIX*users`');
Please login to merge, or discard this patch.
settings/Panels/Personal/Profile.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,11 +26,9 @@
 block discarded – undo
26 26
 
27 27
 use OCP\Settings\ISettings;
28 28
 use OCP\Template;
29
-use OCP\IUser;
30 29
 use OCP\IGroupManager;
31 30
 use OCP\IUserSession;
32 31
 use OCP\IConfig;
33
-use OC\Settings\Panels\Helper;
34 32
 use OCP\L10N\IFactory;
35 33
 
36 34
 class Profile implements ISettings {
Please login to merge, or discard this patch.
lib/private/Settings/SettingsManager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,6 @@  discard block
 block discarded – undo
39 39
 use OCP\IGroupManager;
40 40
 use OCP\Defaults;
41 41
 use OCP\IURLGenerator;
42
-
43 42
 use OC\Settings\Panels\Personal\Profile;
44 43
 use OC\Settings\Panels\Personal\Legacy as LegacyPersonal;
45 44
 use OC\Settings\Panels\Admin\Legacy as LegacyAdmin;
@@ -54,7 +53,6 @@  discard block
 block discarded – undo
54 53
 use OC\Settings\Panels\Admin\Mail;
55 54
 use OC\Settings\Panels\Admin\Logging;
56 55
 use OC\Settings\Panels\Admin\SecurityWarning;
57
-use OC\Settings\Panels\Admin\Updater;
58 56
 use OC\Settings\Panels\Admin\Tips;
59 57
 use OC\Settings\Panels\Admin\Status;
60 58
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use Sabre\DAV\ServerPlugin;
31 31
 use Sabre\DAV\Tree;
32 32
 use Sabre\DAV\Xml\Element\Response;
33
-use Sabre\DAV\Xml\Response\MultiStatus;
34 33
 use Sabre\DAV\PropFind;
35 34
 use OCP\SystemTag\ISystemTagObjectMapper;
36 35
 use OCP\IUserSession;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 * This will be used in the {DAV:}supported-report-set property.
153 153
 	 *
154 154
 	 * @param string $uri
155
-	 * @return array
155
+	 * @return string[]
156 156
 	 */
157 157
 	public function getSupportedReportSet($uri) {
158 158
 		return [self::REPORT_NAME];
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @param string $reportName
165 165
 	 * @param mixed $report
166 166
 	 * @param string $uri
167
-	 * @return bool
167
+	 * @return null|false
168 168
 	 * @throws BadRequest
169 169
 	 * @throws PreconditionFailed
170 170
 	 * @internal param $ [] $report
@@ -350,6 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * with a leading slash but no trailing slash
351 351
 	 * @param string[] $requestedProps requested properties
352 352
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
353
+	 * @param Node[] $nodes
353 354
 	 * @return Response[]
354 355
 	 */
355 356
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {
Please login to merge, or discard this patch.