owncloud / core

core/Middleware/TwoFactorMiddleware.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
 	}
 
 	/**
-	 * @param $controller
-	 * @param $methodName
+	 * @param Controller $controller
+	 * @param string $methodName
 	 * @throws TwoFactorAuthRequiredException
 	 * @throws UserAlreadyLoggedInException
 	 */

lib/private/legacy/response.php

Doc Comments +2 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
 	 * @param string $userId
 	 * @param string $domain
 	 * @param \OCP\IConfig $config
-	 * @param array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [
@@ -318,7 +318,7 @@ 
 	 * This function adds the CORS headers for all domains
 	 *
 	 * @param Sabre\HTTP\ResponseInterface $response
-	 * @param Array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [

settings/Application.php

Unused Use Statements -3 removed lines

@@ -39,11 +39,8 @@
 use OC\Settings\Controller\AuthSettingsController;
 use OC\Settings\Controller\CertificateController;
 use OC\Settings\Controller\CheckSetupController;
-use OC\Settings\Controller\GroupsController;
 use OC\Settings\Controller\LogSettingsController;
 use OC\Settings\Controller\MailSettingsController;
-use OC\Settings\Controller\UsersController;
-use OC\Settings\Middleware\SubadminMiddleware;
 use OCP\AppFramework\App;
 use OCP\IContainer;
 use OCP\Util;

apps/files/lib/Command/VerifyChecksums.php

Doc Comments +2 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
 
 	/**
 	 * @param Node $node
-	 * @param $correctChecksum
+	 * @param string $correctChecksum
 	 * @throws NotFoundException
 	 * @throws \OCP\Files\InvalidPathException
 	 * @throws \OCP\Files\StorageNotAvailableException
@@ -188,7 +188,7 @@ 
 	}
 
 	/**
-	 * @param $path
+	 * @param string $path
 	 * @param IStorage $storage
 	 * @return string
 	 * @throws \OCP\Files\StorageNotAvailableException

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -270,6 +270,9 @@ 
 		return \array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = \array_values($this->propertyMap);
@@ -1276,7 +1279,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 * @throws Forbidden
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
@@ -1682,6 +1685,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

apps/dav/lib/CardDAV/SyncService.php

Doc Comments +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
 	}
 
 	/**
-	 * @return array|null
+	 * @return string
 	 */
 	public function getLocalSystemAddressBook() {
 		if (\is_null($this->localSystemAddressBook)) {

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -172,6 +172,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return \hash_equals($storedToken, $token);

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -284,6 +284,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = \trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -673,7 +676,7 @@ 
 	 * if smb.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -700,6 +703,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) {
 			Util::writeLog('smb', "$function swallowing ".\get_class($exception)

apps/files_sharing/lib/Controller/ShareesController.php

Doc Comments +2 added lines, -2 removed lines

@@ -443,7 +443,7 @@ 
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {
@@ -658,7 +658,7 @@ 
 	 * trusted domain entries
 	 *
 	 * @param string $target target
-	 * @return true if one match was found, false otherwise
+	 * @return boolean if one match was found, false otherwise
 	 */
 	protected function isInstanceDomain($target) {
 		if (\strpos($target, '/') !== false) {