Issues in mock.php (master) - Issues in master - owncloud/contacts - Measure and Improve Code Quality continuously with Scrutinizer

Issues (493)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/unit/lib/backend/mock.php (30 issues)

Labels

Severity

Minor 30

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c) 2013 Thomas Tanghus ([email protected])
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Contacts\Backend;

class Mock extends AbstractBackend {

	public $name = 'mock';
	public $addressBooks;
	public $contacts;
	public $userid;

	/**
	 * @param string $userid
	 */
	function __construct($userid = null, $addressBooks = null, $contacts = null) {


		$this->userid = $userid ? $userid : \OC::$server->getUserSession()->getUser()->getUId();
		$this->addressBooks = $addressBooks;
		$this->contacts = $contacts;

		if (is_null($this->addressBooks)) {
			$this->addressBooks = array(
				array(
					'id' => 'foo',
					'owner' => $userid,
					'displayname' => 'd-name',
					'permissions' => \OCP\PERMISSION_ALL,
				),
			);

			$this->contacts = array(
				'foo' => array(
					'123' =>
					array(
						'id' => '123',
						'displayname' => 'Max Mustermann',
						'carddata' => file_get_contents(__DIR__ . '/../../data/test1.vcf')
					)
				),
			);
		}

	}


	function getAddressBooksForUser(array $options = array()) {


		$books = array();
		foreach($this->addressBooks as $book) {
			if ($book['owner'] === $this->userid) {
				$books[] = $book;
			}
		}
		return $books;

	}

	function getAddressBook($addressBookId, array $options = array()) {


		foreach($this->addressBooks as &$book) {
			if ($book['id'] === $addressBookId) {
				return $book;
			}
		}

	}

	function updateAddressBook($addressBookId, array $changes, array $options = array()) {


		if(count($changes) === 0 || !isset($changes['displayname'])) {
			return false;
		}

		foreach($this->addressBooks as &$book) {
			if ($book['id'] === $addressBookId) {
				foreach($changes as $key => $value) {
					$book[$key] = $value;
					return true;
				}
			}
		}

		return false;

	}

	function createAddressBook(array $properties, array $options = array()) {


		if(count($properties) === 0 || !isset($properties['displayname'])) {
			return false;
		}

		$id = \OC::$server->getSecureRandom()->getMediumStrengthGenerator()->generate('4');
		$this->addressBooks[] = array_merge($properties, array(
			'id' => $id,
			'permissions' => \OCP\PERMISSION_ALL,
			'owner' => $this->userid,
		));

		return $id;
	}

	function deleteAddressBook($addressBookId, array $options = array()) {


		foreach($this->addressBooks as $key => $value) {
			if ($value['id'] === $addressBookId) {
				unset($this->addressBooks[$key]);
			}
		}
		if(isset($this->contacts[$addressBookId])) {
			unset($this->contacts[$addressBookId]);
			return true;
		}
		return false;

	}

	function getContacts($addressBookId, array $options = array()) {


		$contacts = array();
		$omitdata = isset($options['omitdata']) ? $options['omitdata'] : false;
		$book = $this->getAddressBook($addressBookId);
		if(!$book) {
			return $contacts;
		}
		foreach($this->contacts[$addressBookId] as $contact) {
			$contact['permissions'] = $book['permissions'];
			$contact['owner'] = $book['owner'];
			if($omitdata) {
				unset($contact['carddata']);
			}
			$contacts[] = $contact;
		}

		return $contacts;

	}

	function getContact($addressBookId, $id, array $options = array()) {


		$book = $this->getAddressBook($addressBookId);
		if(!$book) {
			return null;
		}
		if (!isset($this->contacts[$addressBookId][$id])) {
			return null;
		}

		$contact = $this->contacts[$addressBookId][$id];
		$contact['permissions'] = $book['permissions'];
		$contact['owner'] = $book['owner'];

		return $contact;

	}

	function createContact($addressBookId, $contact, array $options = array()) {


		$id = \OC::$server->getSecureRandom()->getMediumStrengthGenerator()->generate('4');
		$this->contacts[$addressBookId][$id] = array(
						'id' => $id,
						'displayname' => $contact->FN,
						'carddata' => $contact->serialize()
					);

		return $id;
	}

	function updateContact($addressBookId, $id, $contact, array $options = array()) {

		//echo __METHOD__ . $addressBookId .', ' . $id . ', ' . print_r($contact, true);
		$this->contacts[$addressBookId][$id] = array(
						'displayname' => $contact->FN,
						'carddata' => $contact->serialize()
					);

		return true;

	}

	function deleteContact($addressBookId, $id, array $options = array()) {


		if(isset($this->contacts[$addressBookId][$id])) {
			unset($this->contacts[$addressBookId][$id]);
			return true;
		}
		return false;

	}

	function numContacts($addressBookId) {

		return count($this->contacts[$addressBookId]);
	}
}


1			<?php
2			/**
3			* Copyright (c) 2013 Thomas Tanghus ([email protected])
4			* This file is licensed under the Affero General Public License version 3 or
5			* later.
6			* See the COPYING-README file.
7			*/
8
9			namespace OCA\Contacts\Backend;
10
11			class Mock extends AbstractBackend {
12
13			public $name = 'mock';
14			public $addressBooks;
15			public $contacts;
16			public $userid;
17
18			/**
19			* @param string $userid
20			*/
21			function __construct($userid = null, $addressBooks = null, $contacts = null) {
			0 ignored issues – show Best Practice introduced 2015-11-26 05:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Comprehensibility Best Practice introduced 2015-11-26 05:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `__construct`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
22
23			$this->userid = $userid ? $userid : \OC::$server->getUserSession()->getUser()->getUId();
24			$this->addressBooks = $addressBooks;
25			$this->contacts = $contacts;
26
27			if (is_null($this->addressBooks)) {
28			$this->addressBooks = array(
29			array(
30			'id' => 'foo',
31			'owner' => $userid,
32			'displayname' => 'd-name',
33			'permissions' => \OCP\PERMISSION_ALL,
34			),
35			);
36
37			$this->contacts = array(
38			'foo' => array(
39			'123' =>

owncloud / contacts

Issues (493)

Security Analysis not enabled

tests/unit/lib/backend/mock.php (30 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like