owncloud / contacts

tests/unit/lib/addressbookproviderTest.php

<?php
/**
 * Copyright (c) 2013 Thomas Tanghus (thomas@tanghus.net)
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Contacts;

use Test\TestCase;

class AddressBookProviderTest extends TestCase {

	/**
	* @var array
	*/
	protected $abinfo;
	/**
	* @var \OCA\Contacts\Addressbook
	*/
	protected $ab;
	/**
	* @var \OCA\Contacts\Backend\AbstractBackend
	*/
	protected $backend;

	/**
	 * @var \OCA\Contacts\AddressbookProvider
	 */
	private $provider;

	/**
	 * @var string
	 */
	protected $testUser;

	/**
	 * @var array
	 */
	private $contactIds = array();

	public function setUp() {
		parent::setUp();

		$this->testUser = $this->getUniqueID('user_');
		// needed because some parts of code call "getRequest()" and "getSession()"
		$session = $this->getMockBuilder('\OC\Session\Memory')
			->disableOriginalConstructor()
			->getMock();
		$session->expects($this->any())
			->method('get')
			->with('user_id')
			->will($this->returnValue($this->testUser));
		$userObject = $this->getMock('\OCP\IUser');
		$userObject->expects($this->any())
			->method('getUId')
			->will($this->returnValue($this->testUser));
		$userSession = $this->getMockBuilder('\OC\User\Session')
			->disableOriginalConstructor()
			->getMock();
		$userSession->expects($this->any())
			->method('getUser')
			->will($this->returnValue($userObject));
		$userSession->expects($this->any())
			->method('getSession')
			->will($this->returnValue($session));
		\OC::$server->registerService('UserSession', function (\OCP\IServerContainer $c) use ($userSession){

The parameter $c is not used and could be removed.

			return $userSession;
		});


		$this->backend = new Backend\Database($this->testUser);
		$this->abinfo = array('displayname' => uniqid('display_'));
		$this->ab = new AddressBook($this->backend, $this->abinfo);
		$this->provider = new AddressbookProvider($this->ab);

		$card = new \OCA\Contacts\VObject\VCard();

The call to VCard::__construct() misses a required argument $name.

		$uid = substr(md5($this->getUniqueID()), 0, 10);
		$card->add('UID', $uid);
		$card->add('FN', 'Max Mustermann');
		$id = $this->ab->addChild($card);
		Utils\Properties::updateIndex($id, $card);

It seems like $id defined by $this->ab->addChild($card) on line 82 can also be of type false or null; however, OCA\Contacts\Utils\Properties::updateIndex() does only seem to accept string, maybe add an additional type check?

		$this->contactIds[] = $id;

		// Add extra contact
		$card = new \OCA\Contacts\VObject\VCard();

The call to VCard::__construct() misses a required argument $name.

		$uid = substr(md5(rand().time()), 0, 10);
		$card->add('UID', $uid);
		$card->add('FN', 'Jan Janssens');
		$id = $this->ab->addChild($card);
		Utils\Properties::updateIndex($id, $card);

It seems like $id defined by $this->ab->addChild($card) on line 91 can also be of type false or null; however, OCA\Contacts\Utils\Properties::updateIndex() does only seem to accept string, maybe add an additional type check?

		$this->contactIds[] = $id;
	}

	public function tearDown() {
		unset($this->backend);
		unset($this->ab);
		Utils\Properties::purgeIndexes($this->contactIds);

		parent::tearDown();
	}

	/**
	 * @dataProvider providesSearchData
	 */
	public function testSearch($expected, $pattern) {
		$result = $this->provider->search($pattern, ['FN'], array());

		$this->assertTrue(is_array($result));
		$this->assertEquals(count($expected), count($result));
		$result = array_map(function($c){
			return $c['FN'];
		}, $result);
		$this->assertEquals($expected, $result, '', 0.0, 10, true);
	}

	public function providesSearchData() {
		return [
			'empty pattern' => [['Max Mustermann', 'Jan Janssens'], ''],
			'case insensitive' => [['Max Mustermann'], 'max'],
		];
	}

}