Issues in loader.js (master) - Issues in master - owncloud/contacts - Measure and Improve Code Quality continuously with Scrutinizer

Issues (493)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

js/loader.js (2 issues)

Labels

Coding Style 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

/**
 * Copyright (c) 2013 Thomas Tanghus ([email protected])
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */
OC.ContactsImporter = OC.ContactsImporter || {
	init:function(fileName) {
		var self = OC.ContactsImporter;
		self.path = $('#dir').val();
		self.fileName = fileName;
		console.log('fileName', self.path, self.fileName);
		/*OC.addScript('contacts', 'addressbooks', function() {
			OC.addScript('contacts', 'storage', function() {
				$.when(self._getTemplate()).then(function($tmpl) {
					self.$template = $tmpl;
					if(self.$dialog) {
						self.$dialog.ocdialog('close');
					}
					self.$dialog = self.$template.octemplate({
						selectText: t('contacts', 'Please choose the addressbook'),
						defaultText: t('contacts', 'Import into...')
					});
					self.$dialog.appendTo($('body'));
					self.addressBooks = new OC.Contacts.AddressBookList(
						new OC.Contacts.Storage(), self.$dialog, null, true
					);
					self.showDialog();
				})
				.fail(function() {
					alert(t('contacts', 'Error loading import template'));
				});
			})
			.fail(function(jqxhr, settings, exception) {
				console.warn('Error loading storage backend', jqxhr, settings, exception);
			});
		})
		.fail(function(jqxhr, settings, exception) {
			console.warn('Error loading address book backend', jqxhr, settings, exception);
		});*/
	},
	showDialog:function() {
		var self = this;
		$.when(self.addressBooks.loadAddressBooks()).then(function(response) {
			if(!response.error) {
				self.$dialog.ocdialog({
					modal: true,
					title: t('contacts', 'Import contacts'),
					close: function() {
						$(this).ocdialog('destroy').remove();
						self.$dialog = null;
					}
				});
				self.$importIntoSelect = $('#contacts-import-into');
				self.$importIntoSelect.on('change', function() {
					var $selected = $(this).find('option:selected');
					if($(this).val() === '-1') {
						self.$dialog.ocdialog('option', 'buttons', []);
					} else {
						self.$dialog.ocdialog('option', 'buttons', [{
							text: t('contacts', 'Import'),
							defaultButton: true,
							click:function() {
								console.log('Selected', $selected);
								self.$dialog.ocdialog('option', {
									buttons: [],
									closeButton: false,
									title: t('contacts', 'Importing...')
								});
								self.startImport($selected.data('backend'), $selected.val(), self.$importFormatSelect.find('option:selected').val());
							}
						}]);
					}
				});
			} else {
				console.warn('response.message');
			}
		})
		.fail(function(response) {
			console.warn(response);
		});
	},
	startImport: function(backend, addressBookId, importType) {
		var self = this;
		$('.import-select').hide();
		$('.import-status').show();
		$.when(self.addressBooks.prepareImport(backend, addressBookId, importType, this.path, this.fileName))
		.then(function(response) {
			if(!response.error) {
				$.when(self.addressBooks.doImport(response)).then(function(response) {
					self.$dialog.ocdialog('option', {
						title: t('contacts', 'Import done'),
						closeButton: true,
						buttons: [{
							text: t('contacts', 'Close'),
							defaultButton: true,
							click:function() {
								self.$dialog.ocdialog('close');
							}
						}]
					});
				})
				.fail(function(response) {
					console.warn(response);
				});
			} else {
				console.warn('response.message');
			}
		})
		.fail(function(response) {
			console.warn(response);
		});
	},
	_getTemplate: function() {
		var defer = $.Deferred();
		if(!this.$template) {
			$.get(OC.filePath('contacts', 'templates', 'importdialog.html'), function(tmpl) {
				defer.resolve($(tmpl));
			})
			.fail(function() {
				defer.reject();
			});
		} else {
			defer.resolve(this.$template);
		}
		return defer.promise();
	}
};

$(document).ready(function(){

	// translate search result type
	OC.search.resultTypes.contact = t('contacts', 'Contact');

	OC.search.customResults.contact = function (row, item){
		var text = '';
		if (item.email) {
			text += '✉ ' + item.email;
			if (item.phone) {
				text += ', '

			}
		}
		if (item.phone) {
			text += '☎ ' + item.phone

		}
		row.find('td.result .text').text(text);
	};

	// If the app is already active there's no need for the FileActions
	if(OC.Contacts) {
		return;
	}

	$(document).bind('status.contacts.error', function(e, data) {
		console.warn(data.message);
		//console.trace();
		//OC.notify({message:data.message});
	});

	if(typeof FileActions !== 'undefined'){
		FileActions.register('text/vcard','importaddressbook', OC.PERMISSION_READ, '', OC.ContactsImporter.init);
		FileActions.setDefault('text/vcard','importaddressbook');
		FileActions.register('text/x-vcard','importaddressbook', OC.PERMISSION_READ, '', OC.ContactsImporter.init);
		FileActions.setDefault('text/x-vcard','importaddressbook');
	}
	
});


1			/**
2			* Copyright (c) 2013 Thomas Tanghus ([email protected])
3			* This file is licensed under the Affero General Public License version 3 or
4			* later.
5			* See the COPYING-README file.
6			*/
7			OC.ContactsImporter = OC.ContactsImporter \|\| {
8			init:function(fileName) {
9			var self = OC.ContactsImporter;
10			self.path = $('#dir').val();
11			self.fileName = fileName;
12			console.log('fileName', self.path, self.fileName);
13			/*OC.addScript('contacts', 'addressbooks', function() {
14			OC.addScript('contacts', 'storage', function() {
15			$.when(self._getTemplate()).then(function($tmpl) {
16			self.$template = $tmpl;
17			if(self.$dialog) {
18			self.$dialog.ocdialog('close');
19			}
20			self.$dialog = self.$template.octemplate({
21			selectText: t('contacts', 'Please choose the addressbook'),
22			defaultText: t('contacts', 'Import into...')
23			});
24			self.$dialog.appendTo($('body'));
25			self.addressBooks = new OC.Contacts.AddressBookList(
26			new OC.Contacts.Storage(), self.$dialog, null, true
27			);
28			self.showDialog();
29			})
30			.fail(function() {
31			alert(t('contacts', 'Error loading import template'));
32			});
33			})
34			.fail(function(jqxhr, settings, exception) {
35			console.warn('Error loading storage backend', jqxhr, settings, exception);
36			});
37			})
38			.fail(function(jqxhr, settings, exception) {
39			console.warn('Error loading address book backend', jqxhr, settings, exception);
40			});*/
41			},
42			showDialog:function() {
43			var self = this;
44			$.when(self.addressBooks.loadAddressBooks()).then(function(response) {
45			if(!response.error) {
46			self.$dialog.ocdialog({
47			modal: true,
48			title: t('contacts', 'Import contacts'),
49			close: function() {
50			$(this).ocdialog('destroy').remove();
51			self.$dialog = null;
52			}
53			});
54			self.$importIntoSelect = $('#contacts-import-into');
55			self.$importIntoSelect.on('change', function() {
56			var $selected = $(this).find('option:selected');
57			if($(this).val() === '-1') {
58			self.$dialog.ocdialog('option', 'buttons', []);
59			} else {
60			self.$dialog.ocdialog('option', 'buttons', [{
61			text: t('contacts', 'Import'),
62			defaultButton: true,
63			click:function() {
64			console.log('Selected', $selected);
65			self.$dialog.ocdialog('option', {
66			buttons: [],
67			closeButton: false,
68			title: t('contacts', 'Importing...')
69			});
70			self.startImport($selected.data('backend'), $selected.val(), self.$importFormatSelect.find('option:selected').val());
71			}
72			}]);
73			}
74			});
75			} else {
76			console.warn('response.message');
77			}
78			})
79			.fail(function(response) {
80			console.warn(response);
81			});
82			},
83			startImport: function(backend, addressBookId, importType) {
84			var self = this;
85			$('.import-select').hide();
86			$('.import-status').show();
87			$.when(self.addressBooks.prepareImport(backend, addressBookId, importType, this.path, this.fileName))
88			.then(function(response) {
89			if(!response.error) {
90			$.when(self.addressBooks.doImport(response)).then(function(response) {
91			self.$dialog.ocdialog('option', {
92			title: t('contacts', 'Import done'),
93			closeButton: true,
94			buttons: [{
95			text: t('contacts', 'Close'),
96			defaultButton: true,
97			click:function() {
98			self.$dialog.ocdialog('close');
99			}
100			}]
101			});
102			})
103			.fail(function(response) {
104			console.warn(response);
105			});
106			} else {
107			console.warn('response.message');
108			}
109			})
110			.fail(function(response) {
111			console.warn(response);
112			});
113			},
114			_getTemplate: function() {
115			var defer = $.Deferred();
116			if(!this.$template) {
117			$.get(OC.filePath('contacts', 'templates', 'importdialog.html'), function(tmpl) {
118			defer.resolve($(tmpl));
119			})
120			.fail(function() {
121			defer.reject();
122			});
123			} else {
124			defer.resolve(this.$template);
125			}
126			return defer.promise();
127			}
128			};
129
130			$(document).ready(function(){
131
132			// translate search result type
133			OC.search.resultTypes.contact = t('contacts', 'Contact');
134
135			OC.search.customResults.contact = function (row, item){
136			var text = '';
137			if (item.email) {
138			text += '✉ ' + item.email;
139			if (item.phone) {
140			text += ', '
			0 ignored issues – show Coding Style introduced 2015-11-26 05:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
141			}
142			}
143			if (item.phone) {
144			text += '☎ ' + item.phone
			0 ignored issues – show Coding Style introduced 2015-11-26 05:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
145			}
146			row.find('td.result .text').text(text);
147			};
148
149			// If the app is already active there's no need for the FileActions
150			if(OC.Contacts) {
151			return;
152			}
153
154			$(document).bind('status.contacts.error', function(e, data) {
155			console.warn(data.message);
156			//console.trace();
157			//OC.notify({message:data.message});
158			});
159
160			if(typeof FileActions !== 'undefined'){
161			FileActions.register('text/vcard','importaddressbook', OC.PERMISSION_READ, '', OC.ContactsImporter.init);
162			FileActions.setDefault('text/vcard','importaddressbook');
163			FileActions.register('text/x-vcard','importaddressbook', OC.PERMISSION_READ, '', OC.ContactsImporter.init);
164			FileActions.setDefault('text/x-vcard','importaddressbook');
165			}
166
167			});
168

owncloud / contacts

Issues (493)

Security Analysis not enabled

js/loader.js (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like